Skip to content

Dynamic backend tests cause errors. #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
negiyas opened this issue Mar 7, 2024 · 3 comments
Closed

Dynamic backend tests cause errors. #2743

negiyas opened this issue Mar 7, 2024 · 3 comments

Comments

@negiyas
Copy link
Collaborator

negiyas commented Mar 7, 2024

(Updated in 2024/05/08)
All issues errors with dynamic backend tests (on CPU) are fixed. Thanks!

(Updated in 2024/03/26)

PR #2735 enables dynamic backend tests, but the following backend tests still fail.
Accordingly PR #2735 temporally disables these failed dynamic backend tests to pass the Jenkins tests.

Please look at the failed tests if you have time. We may have to (1) fix the issues, (2) change the test conditions, or (3) remove the tests if we can confirm that they are not supported.

Please check the following marks if fixed some of them. Thanks.
PR #2753 executes the failed dynamic backend tests, and you can look at the error log at https://www.onnxmlir.xyz/jenkins/job/ONNX-MLIR-Pipeline-Docker-Build/14379/consoleText .

[X] 1. "test_castlike_FLOAT_to_DOUBLE_cpu" # Fixed by PR#2762
[X] 2. "test_castlike_DOUBLE_to_FLOAT_cpu" # Fixed by PR#2762
[X] 3. "test_castlike_FLOAT_to_FLOAT16_cpu" # Fixed by PR#2762
[X] 4. "test_castlike_FLOAT16_to_FLOAT_cpu" # Fixed by PR#2762
[X] 5. "test_castlike_FLOAT16_to_DOUBLE_cpu" # Fixed by PR#2762
[X] 6. "test_castlike_DOUBLE_to_FLOAT16_cpu" # Fixed by PR#2762
[X] 7. "test_convtranspose_1d_cpu"
[X] 8. "test_convtranspose_3d_cpu"
[X] 9. "test_convtranspose_autopad_same_cpu"
[X] 10. "test_convtranspose_cpu"
[X] 11. "test_convtranspose_dilations_cpu"
[X] 12. "test_convtranspose_kernel_shape_cpu"
[X] 13. "test_convtranspose_output_shape_cpu"
[X] 14. "test_convtranspose_pad_cpu"
[X] 15. "test_convtranspose_pads_cpu"
[X] 16. "test_depthtospace_example_cpu"
[X] 17. "test_depthtospace_crd_mode_example_cpu"
[X] 18. "test_einsum_batch_diagonal_cpu"
[X] 19. "test_einsum_batch_matmul_cpu"
[X] 20. "test_einsum_inner_prod_cpu"
[X] 21. "test_einsum_sum_cpu"
[X] 22. "test_einsum_transpose_cpu"
[X] 23. "test_gathernd_example_int32_cpu" # Fixed by PR#2748
[X] 24. "test_gathernd_example_float32_cpu" # Fixed by PR#2748
[X] 25. "test_gathernd_example_int32_batch_dim1_cpu" # Fixed by PR#2748
[X] 26. "test_instancenorm_example_cpu" # Fixed by PR#2763
[X] 27. "test_instancenorm_epsilon_cpu" # Fixed by PR#2763
[X] 28. "test_constant_pad_cpu" # Fixed by PR#2754
[X] 29. "test_edge_pad_cpu" # Fixed by PR#2754
[X] 30. "test_reflect_pad_cpu" # FIxed by PR#2754
[X] 31. "test_spacetodepth_example_cpu"
[X] 32. "test_top_k_cpu" # Fixed by PR#2735
[X] 33. "test_top_k_smallest_cpu" # Fixed by PR#2735
[X] 34. "test_top_k_negative_axis_cpu" # Fixed by PR#2735
[X] 35. "test_onnxmlir_top_k_float16_cpu" # Fixed by PR#2735
[X] 36. "test_onnxmlir_top_k_smallest_float16_cpu" # Fixed by PR#2735

(This issue replaces the issue #2639 , since the situation is changed by PR #2735.)

negiyas added a commit that referenced this issue Mar 7, 2024
Enables dynamic backend tests, and Disabled the failed backend tests to pass the Jenkins backend tests temporally.
Remaining issues are traced at Issue #2743.
---------

Signed-off-by: Yasushi Negishi <[email protected]>
@AlexandreEichenberger
Copy link
Collaborator

Update on the 2 instance norm failing tests. When I compile a model with dynamic shape, and then set the shapes at runtime, it works. But when we compile a model with dynamic shape AND set the size of these shapes by a compiler option, the compiler exit with an error. @chentong319 has a similar problem with another program, and he will test his solution (setting the output type to the same as the original type). Once Tong confirms that this work on his case, will do the same on these 2 cases of instance norm.

brnorris03 added a commit to brnorris03/onnx-mlir that referenced this issue Mar 19, 2024
Squashed commit of the following:

commit 8298ca3
Author: philass <[email protected]>
Date:   Sun Mar 17 20:06:29 2024 -0700

    Test patch

    Signed-off-by: philass <[email protected]>

commit caf33a3
Author: philass <[email protected]>
Date:   Wed Mar 13 17:31:13 2024 -0700

    Add argmax

    Signed-off-by: philass <[email protected]>

commit 29add14
Author: philass <[email protected]>
Date:   Wed Mar 13 14:20:18 2024 -0700

    clang format

    Signed-off-by: philass <[email protected]>

commit c5bfc12
Author: philass <[email protected]>
Date:   Mon Feb 26 14:36:49 2024 -0800

    Update LLVM to e899641df2391179e8ec29ca14c53b09ae7ce85c

    Signed-off-by: philass <[email protected]>

    StableHLO fixes

    Signed-off-by: philass <[email protected]>

    More fixes

    Signed-off-by: philass <[email protected]>

    Fix build warnings for deprecated functions

    Signed-off-by: philass <[email protected]>

    Some lit test fixes

    Signed-off-by: philass <[email protected]>

    Fix all onnx-mlir lit tests

    Signed-off-by: philass <[email protected]>

    Add stablehlo pooling lit test

    Signed-off-by: philass <[email protected]>

    Fix remaining lit tests

    Signed-off-by: philass <[email protected]>

    Fix warnings

    Signed-off-by: philass <[email protected]>

    Fix nnpa lit tests

    Signed-off-by: philass <[email protected]>

    Disable mhlo on windows builds

    Signed-off-by: philass <[email protected]>

    Update docs

    Signed-off-by: philass <[email protected]>

commit ea8e277
Author: Yan Xu <[email protected]>
Date:   Wed Mar 13 01:52:02 2024 -0700

    [stablehlo] Reduction upgrade (onnx#2745)

    * [Stablehlo] Reduction Op Upgrade

    Signed-off-by: yan.xu0210 <[email protected]>

    * add test for reduction ops

    Signed-off-by: yan.xu0210 <[email protected]>

    ---------

    Signed-off-by: yan.xu0210 <[email protected]>

commit 18f4e07
Author: Boyana Norris <[email protected]>
Date:   Thu Mar 7 01:36:43 2024 -0600

    [StableHLO] Add `onnx.Dim` lowering to StableHLO (onnx#2738)

    * ONNX to StableHLO, add lowering of Dim op

    Signed-off-by: Boyana Norris <[email protected]>

    ---------

    Signed-off-by: Boyana Norris <[email protected]>
    Co-authored-by: Tung D. Le <[email protected]>

commit a4438fe
Author: srcarroll <[email protected]>
Date:   Wed Mar 6 23:20:15 2024 -0600

    Fix `onnx.Gather` conversion to `stablehlo` in dynamic case (onnx#2736)

    * Fix onnx.Gather conversion to stablehlo in dynamic case

    Signed-off-by: Sam <[email protected]>

    ---------

    Signed-off-by: Sam <[email protected]>
    Co-authored-by: Tung D. Le <[email protected]>

commit d84e0a4
Author: Yasushi Negishi <[email protected]>
Date:   Thu Mar 7 12:32:50 2024 +0900

    Fix an issue about "make check-onnx-backend-dynamic" (onnx#2735)

    Enables dynamic backend tests, and Disabled the failed backend tests to pass the Jenkins backend tests temporally.
    Remaining issues are traced at Issue onnx#2743.
    ---------

    Signed-off-by: Yasushi Negishi <[email protected]>

commit 1f4ab03
Author: srcarroll <[email protected]>
Date:   Wed Mar 6 19:35:16 2024 -0600

    Support dynamic shapes for `onnx.Matmul` in `stablehlo` conversion (onnx#2737)

    * Support dynamic output for `onnx.Matmul` in `stablehlo` conversion

    Signed-off-by: Sam <[email protected]>

    * Refactor common logic into single lambda

    Signed-off-by: Sam <[email protected]>

    ---------

    Signed-off-by: Sam <[email protected]>
    Co-authored-by: Tung D. Le <[email protected]>

commit 12bab05
Author: Tung D. Le <[email protected]>
Date:   Wed Mar 6 09:28:33 2024 +0900

    Elide DenseResourceElementsAttr (onnx#2739)

    * Elide ResourceDenseElemAttrs that is used for constant stickifies

    Signed-off-by: Tung D. Le <[email protected]>

    ---------

    Signed-off-by: Tung D. Le <[email protected]>

Signed-off-by: Boyana Norris <[email protected]>
@AlexandreEichenberger
Copy link
Collaborator

@chentong319 thanks for the suggested fix, it worked. PR #2763 implements the change for instance norm cases (added also group norm which needs the same pattern, even if it may not be tested at this time).

@negiyas
Copy link
Collaborator Author

negiyas commented May 8, 2024

I am closing this issue, since ll issues errors with dynamic backend tests (on CPU) are fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants