-
Notifications
You must be signed in to change notification settings - Fork 347
Dynamic backend tests on NNPA cause errors #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I found that most test cases for avgpool run on CPU because we don't know they meet one of the parameter restriction Since we can't check it at compile time, I think we can ignore it in unknown dimension case. (If this doesn't meet at runtime, the execution fails at runtime. ) By fixing the legality check, I confirmed most of the case can run on NNPA.
[ ] test_averagepool_2d_default_cpu,zdnn_avgpool2d, maxpool is also same. |
Now only test cases with [ ] test_averagepool_2d_default_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST |
Closing this issue, since all tests were fixed or confirmed. Thanks. |
Dynamic backend tests on NNPA cause runtime errors. (c.f. This Issue is similar to Issue #2743 "Dynamic backend tests cause errors on CPU," but this issue for errors on NNPA.)
PR #2781 introduces "--dimParams" option for specifying relationships among dimensions of model inputs. It also enables dynamic backend tests on NNPA with the --dimParams option, but some tests cannot be enabled because of runtime errors, and they are temporally disabled by the PR. We need to fix these runtime issues or confirm that they are reasonable.
The following is a list of backend tests on NNPA not causing errors with static shapes, but causing errors with dynamic shapes. Please fix errors or confirm that they are reasonable. Thanks.
[ ] test_averagepool_2d_default_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_averagepool_2d_precomputed_pads_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_averagepool_2d_precomputed_same_upper_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_averagepool_2d_precomputed_strides_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_averagepool_2d_same_upper_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_averagepool_2d_strides_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_batchnorm_epsilon_cpu,zdnn_mul,NO_DYNAMIC_SHAPE_TEST
[ ] test_batchnorm_example_cpu,zdnn_mul,NO_DYNAMIC_SHAPE_TEST
[ ] test_basic_conv_with_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_basic_conv_without_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_conv_with_strides_no_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_conv_with_strides_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE _TEST
[ ] test_globalaveragepool_cpu,zdnn_meanreduce2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_globalaveragepool_precomputed_cpu,zdnn_meanreduce2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_logsoftmax_example_1_cpu,zdnn_softmax,NO_DYNAMIC_SHAPE_TEST
[ ] test_max_float32_cpu,zdnn_max,NO_DYNAMIC_SHAPE_TEST
[ ] test_maxpool_2d_default_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_maxpool_2d_precomputed_same_upper_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_maxpool_2d_precomputed_strides_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_maxpool_2d_same_upper_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_maxpool_2d_strides_cpu,zdnn_avgpool2d,NO_DYNAMIC_SHAPE_TEST
[ ] test_min_float32_cpu,zdnn_min,NO_DYNAMIC_SHAPE_TEST
The text was updated successfully, but these errors were encountered: