[NNPA] Update configurations for test cases of backend test for dynamic dimensions #2831
Conversation
Signed-off-by: Haruki Imai <[email protected]>
| @@ -103,7 +103,8 @@ bool checkLegalityPoolOpsCommon(POOLOP op, Value Y) { | |||
| // Check "MaxPool2D/AvgPool2D Parameter Restrictions". These restrictions are | |||
| // described in "zDNN API Reference". Input tensor N(batchNum) and C(Channel) | |||
| // dimensions must always match the output tensor's respective dimensions. | |||
| if (shapeInput[0] != shapeOutput[0] || shapeInput[1] != shapeOutput[1]) | |||
| if ((inputType.hasStaticShape() && outputType.hasStaticShape()) && | |||
| (shapeInput[0] != shapeOutput[0] || shapeInput[1] != shapeOutput[1])) | |||
There was a problem hiding this comment.
Can we use DimAnalysis to check dynamic dims here?
| test_globalaveragepool_cpu,zdnn_meanreduce2d,NO_DYNAMIC_SHAPE_TEST | ||
| test_globalaveragepool_precomputed_cpu,zdnn_meanreduce2d,NO_DYNAMIC_SHAPE_TEST | ||
| test_globalaveragepool_cpu,zdnn_meanreduce2d,NO_DYNAMIC_SHAPE_TEST # Height and Width dimension must be static dimension. | ||
| test_globalaveragepool_precomputed_cpu,zdnn_meanreduce2d,NO_DYNAMIC_SHAPE_TEST # Height and Width dimension must be static dimension. |
There was a problem hiding this comment.
Comments here look the same as ==LIM==, are they necessary?
| test_basic_conv_with_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE_TEST | ||
| test_basic_conv_without_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE_TEST | ||
| test_basic_conv_with_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE_TEST # Height and/or width must be static dimensions. | ||
| test_basic_conv_without_padding_cpu,zdnn_conv2d,NO_DYNAMIC_SHAPE_TEST # Height and/or width must be static dimensions. |
There was a problem hiding this comment.
Comments here look the same as ==LIM==, are they necessary?
Signed-off-by: Haruki Imai <[email protected]>
Signed-off-by: Haruki Imai <[email protected]>
Signed-off-by: Haruki Imai <[email protected]>
imaihal
changed the title
Signed-off-by: Haruki Imai <[email protected]>
Signed-off-by: Haruki Imai <[email protected]>
Signed-off-by: Haruki Imai <[email protected]>
Signed-off-by: Haruki Imai <[email protected]>
|
Jenkins Linux s390x Build #14960 [push] [NNPA] Update configurat... started at 03:26 |
|
Jenkins Linux ppc64le Build #13985 [push] [NNPA] Update configurat... started at 03:35 |
|
Jenkins Linux amd64 Build #14955 [push] [NNPA] Update configurat... started at 02:26 |
|
Jenkins Linux amd64 Build #14955 [push] [NNPA] Update configurat... passed after 1 hr 27 min |
|
Jenkins Linux s390x Build #14960 [push] [NNPA] Update configurat... passed after 2 hr 10 min |
|
Jenkins Linux ppc64le Build #13985 [push] [NNPA] Update configurat... passed after 2 hr 19 min |
As written in issue #2817, some backend tests with dynamic shapes for NNPA was disabled by using
NO_DYNAMIC_SHAPE_TESTflag.This PR enables some of them by fixing legality check and using
--dimParamoption. There are still test cases withNO_DYNAMIC_SHAPE_TEST.Enabled 22 test cases in dynamic backend tests. (test cases with NO_DYNAMIC_SHAPE_TEST from 30 to 8)