Skip to content

[stablehlo] Reduction upgrade #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged

[stablehlo] Reduction upgrade #2745

merged 3 commits into from
Mar 13, 2024

Conversation

Connor-XY
Copy link
Contributor

@Connor-XY Connor-XY commented Mar 8, 2024

This pull request updates conversion for Reduction ops to stablehlo.

Copy link
Collaborator

@chentong319 chentong319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Connor-XY
Copy link
Contributor Author

Thanks for your review, Tong! Could someone with write access merge my pull request for me?

@tungld tungld merged commit ea8e277 into onnx:main Mar 13, 2024
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #14333 [push] [stablehlo] Reduction up... started at 03:53

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #13358 [push] [stablehlo] Reduction up... started at 05:01

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #14363 [push] [stablehlo] Reduction up... started at 04:53

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #14333 [push] [stablehlo] Reduction up... passed after 1 hr 19 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #14363 [push] [stablehlo] Reduction up... passed after 1 hr 46 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #13358 [push] [stablehlo] Reduction up... passed after 1 hr 56 min

brnorris03 added a commit to brnorris03/onnx-mlir that referenced this pull request Mar 19, 2024
Squashed commit of the following:

commit 8298ca3
Author: philass <[email protected]>
Date:   Sun Mar 17 20:06:29 2024 -0700

    Test patch

    Signed-off-by: philass <[email protected]>

commit caf33a3
Author: philass <[email protected]>
Date:   Wed Mar 13 17:31:13 2024 -0700

    Add argmax

    Signed-off-by: philass <[email protected]>

commit 29add14
Author: philass <[email protected]>
Date:   Wed Mar 13 14:20:18 2024 -0700

    clang format

    Signed-off-by: philass <[email protected]>

commit c5bfc12
Author: philass <[email protected]>
Date:   Mon Feb 26 14:36:49 2024 -0800

    Update LLVM to e899641df2391179e8ec29ca14c53b09ae7ce85c

    Signed-off-by: philass <[email protected]>

    StableHLO fixes

    Signed-off-by: philass <[email protected]>

    More fixes

    Signed-off-by: philass <[email protected]>

    Fix build warnings for deprecated functions

    Signed-off-by: philass <[email protected]>

    Some lit test fixes

    Signed-off-by: philass <[email protected]>

    Fix all onnx-mlir lit tests

    Signed-off-by: philass <[email protected]>

    Add stablehlo pooling lit test

    Signed-off-by: philass <[email protected]>

    Fix remaining lit tests

    Signed-off-by: philass <[email protected]>

    Fix warnings

    Signed-off-by: philass <[email protected]>

    Fix nnpa lit tests

    Signed-off-by: philass <[email protected]>

    Disable mhlo on windows builds

    Signed-off-by: philass <[email protected]>

    Update docs

    Signed-off-by: philass <[email protected]>

commit ea8e277
Author: Yan Xu <[email protected]>
Date:   Wed Mar 13 01:52:02 2024 -0700

    [stablehlo] Reduction upgrade (onnx#2745)

    * [Stablehlo] Reduction Op Upgrade

    Signed-off-by: yan.xu0210 <[email protected]>

    * add test for reduction ops

    Signed-off-by: yan.xu0210 <[email protected]>

    ---------

    Signed-off-by: yan.xu0210 <[email protected]>

commit 18f4e07
Author: Boyana Norris <[email protected]>
Date:   Thu Mar 7 01:36:43 2024 -0600

    [StableHLO] Add `onnx.Dim` lowering to StableHLO (onnx#2738)

    * ONNX to StableHLO, add lowering of Dim op

    Signed-off-by: Boyana Norris <[email protected]>

    ---------

    Signed-off-by: Boyana Norris <[email protected]>
    Co-authored-by: Tung D. Le <[email protected]>

commit a4438fe
Author: srcarroll <[email protected]>
Date:   Wed Mar 6 23:20:15 2024 -0600

    Fix `onnx.Gather` conversion to `stablehlo` in dynamic case (onnx#2736)

    * Fix onnx.Gather conversion to stablehlo in dynamic case

    Signed-off-by: Sam <[email protected]>

    ---------

    Signed-off-by: Sam <[email protected]>
    Co-authored-by: Tung D. Le <[email protected]>

commit d84e0a4
Author: Yasushi Negishi <[email protected]>
Date:   Thu Mar 7 12:32:50 2024 +0900

    Fix an issue about "make check-onnx-backend-dynamic" (onnx#2735)

    Enables dynamic backend tests, and Disabled the failed backend tests to pass the Jenkins backend tests temporally.
    Remaining issues are traced at Issue onnx#2743.
    ---------

    Signed-off-by: Yasushi Negishi <[email protected]>

commit 1f4ab03
Author: srcarroll <[email protected]>
Date:   Wed Mar 6 19:35:16 2024 -0600

    Support dynamic shapes for `onnx.Matmul` in `stablehlo` conversion (onnx#2737)

    * Support dynamic output for `onnx.Matmul` in `stablehlo` conversion

    Signed-off-by: Sam <[email protected]>

    * Refactor common logic into single lambda

    Signed-off-by: Sam <[email protected]>

    ---------

    Signed-off-by: Sam <[email protected]>
    Co-authored-by: Tung D. Le <[email protected]>

commit 12bab05
Author: Tung D. Le <[email protected]>
Date:   Wed Mar 6 09:28:33 2024 +0900

    Elide DenseResourceElementsAttr (onnx#2739)

    * Elide ResourceDenseElemAttrs that is used for constant stickifies

    Signed-off-by: Tung D. Le <[email protected]>

    ---------

    Signed-off-by: Tung D. Le <[email protected]>

Signed-off-by: Boyana Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants