-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor code #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor code #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vozhyk-
reviewed
Apr 17, 2025
vozhyk-
reviewed
Apr 17, 2025
cd24b85
to
2df388d
Compare
vozhyk-
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some things I noticed when fixing this to pass the tests.
61b97df
to
6b642c4
Compare
This was referenced May 6, 2025
Closed
Also, add device.name to devices_switch_routing_interface key, since it's part of a device.
- net_group_policies - net_settings - net_snmp - net_syslog_servers - net_vlan_profiles - net_floor_plans: This also adds missing fields: - `center_*` - this was part of an earlier schema. - `floor_number` - from schema 1.56.
…_server: Fix name path in key
…partially regenerate) fields
…(and partially regenerate) fields Remove duplication - use a single resource for dhcp of `_first` and `_not_first` routing interfaces. Get their IDs using a local mapping instead. Remove the "depends_on", as the dependency should already be added via interface IDs anyway.
- Apply defaults to ipv6_prefix_assignments. - Fix `mandatory_dhcp{.enabled -> }` for the current schema.
…ing syslog_default_rule
…enerate) fields Add missing log and tcp_established fields (schema 1.53).
… Fix defaults path
vozhyk-
added a commit
that referenced
this pull request
May 9, 2025
…ore loop check Without this check, the resource is created even when `l3_firewall_rules` is not specified. Then resource creation fails because the `rules` field is mandatory in the provider. This was mistakenly removed during manual (not generated) changes in #47.
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: refactor resource keys:
instead of only resources that are referred to by other resources.
This way, inserting a resource in the middle of the list
does not cause existing resources to be modified/recreated.
${domain.name}/
to all keys.format()
for keys instead of string interpolation.Breaking change: replace
net_switch_stacks_routing_interfaces_dhcp_{first,not_first}
with a singlenet_switch_stacks_routing_interfaces_dhcp
resource.Apply default values consistently:
domains.
instead of having different roots for domain/organization/network resources.null
in the variable directly.data
field and map all nested values explicitly - this is necessary to apply defaults everywhere.if try(...)
after loops that result in empty arrays by default anyway.Fix a lot of fields where schema differences were missed previously.