meraki_appliance: networks_appliance_firewall_l3_firewall_rules: Restore loop check #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore loop check Without this check, the resource is created even when `l3_firewall_rules` is not specified. Then resource creation fails because the `rules` field is mandatory in the provider. This was mistakenly removed during manual (not generated) changes in #47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, the resource is created
even when
l3_firewall_rulesis not specified.Then resource creation fails
because the
rulesfield is mandatory in the provider.This was mistakenly removed during manual (not generated) changes in #47.
Also, don't convert the
rulesfield tonullif it is an empty list or unspecified - it is mandatory in the provider, so passingnullwould break the use case ofrules=[]; syslog_default_rule=true.