Fix issues noticed during the refactor #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd missing fields - regenerate fields - public_hostname - ipsec_policies_preset
…slog_default_rule field
…g subnet_nat_is_allowed field - regenerate fields
… name to network ID mapping
…rce if no vlans configured
To get the fix for meraki_appliance_vpn_firewall_rules syslog_default_rule idempotency. (CiscoDevNet/terraform-provider-meraki@8762239, CiscoDevNet/terraform-provider-meraki#73)
vozhyk-
commented
May 12, 2025
| @@ -519,7 +519,7 @@ locals { | |||
| key = format("%s/%s/%s", domain.name, organization.name, network.name) | |||
| network_id = meraki_network.organizations_networks[format("%s/%s/%s", domain.name, organization.name, network.name)].id | |||
| vlans_enabled = try(length(network.appliance.vlans) > 0, false) | |||
| } if try(length(network.appliance.vlans) > 0, false) | |||
| } if try(network.appliance, null) != null | |||
There was a problem hiding this comment.
@jon-humphries under what condition should the networks_appliance_vlans_settings resource be created?
Originally, it was always created; then #47 changed it to check network.appliance.vlans (i.e. to create a resource only if a VLAN is configured, i.e. only with vlans_enabled = true.
jon-humphries
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues noticed during #47 and #53 that were dependent on other things being fixed.
meraki_organization:organizations_appliance_third_party_vpn_peers: Add missing fields - regenerate fieldspublic_hostname. Note: Meraki API returns an error if bothpublic_hostnameandpublic_ipare specified.ipsec_policies_preset. Note: Meraki API ignoresipsec_policiesifipsec_policies_presetis specified. Idempotency breaks in that case.meraki_organization:organizations_vpn_firewall_rules: Add missingsyslog_default_rulefieldmeraki_appliance:networks_appliance_vpn_site_to_site_vpn: Add missing subnet_nat_is_allowed field - regenerate fieldsmeraki_appliance:networks_appliance_vlans_settings: Create the resource if no VLANs are configured.length(vlans) > 0, it's not possible to have it set tofalseafter that change. It was originally created ifdomains.organizationsare specified, which was always, sincenetworksare underorganizations.network.applianceis specified instead.