Add a new Page scrolling mode (issue 2638, 8952, 10907) #14112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
ScrollMode-PAGE
branch
14 times, most recently
from
5e239e2 to
c346f10
Compare
Snuffleupagus
force-pushed
the
ScrollMode-PAGE
branch
2 times, most recently
from
fa6f3ec to
e4cf1e2
Compare
Snuffleupagus
force-pushed
the
ScrollMode-PAGE
branch
from
e4cf1e2 to
52edfd1
Compare
|
Thanks @Snuffleupagus, I think it was one of the last big missing UX features in this project. Happy to see this coming ! |
Snuffleupagus
force-pushed
the
ScrollMode-PAGE
branch
from
52edfd1 to
3ba5d9e
Compare
Snuffleupagus
force-pushed
the
ScrollMode-PAGE
branch
3 times, most recently
from
14bb51a to
2cbc758
Compare
This implements a new Page scrolling mode, essentially bringing (and extending) the functionality from `PDFSinglePageViewer` into the regular `PDFViewer`-class. Compared to `PDFSinglePageViewer`, which as its name suggests will only display one page at a time, in the `PDFViewer`-implementation this new Page scrolling mode also support spreadModes properly (somewhat similar to e.g. Adobe Reader). Given the size and scope of these changes, I've tried to focus on implementing the basic functionality. Hence there's room for further clean-up and/or improvements, including e.g. simplifying the CSS/JS related to PresentationMode and implementing easier page-switching with the mouse-wheel/arrow-keys.
With the previous commit, both of the `PDFViewer` and `PDFSinglePageViewer` clases are now small/simple enough that it no longer seems necessary to keep them in separate files.
Snuffleupagus
force-pushed
the
ScrollMode-PAGE
branch
from
2cbc758 to
e1a2e91
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fe02baa63f4b2a2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fe02baa63f4b2a2/output.txt Total script time: 4.36 mins Published |
timvandermeij
approved these changes
Oct 15, 2021
|
Nice implementation! It helped that you limited the scope here because it was indeed quite some code to review carefully. |
|
@timvandermeij Thank you so much for reviewing this; I know it cannot have been easy! |
This was referenced Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new Page scrolling mode, essentially bringing (and extending) the functionality from
PDFSinglePageViewerinto the regularPDFViewer-class. Compared toPDFSinglePageViewer, which as its name suggests will only display one page at a time, in thePDFViewer-implementation this new Page scrolling mode also support spreadModes properly (somewhat similar to e.g. Adobe Reader).Given the size and scope of these changes, I've tried to focus on implementing the basic functionality. Hence there's room for further clean-up and/or improvements, including e.g. simplifying the CSS/JS related to PresentationMode and implementing easier page-switching with the mouse-wheel/arrow-keys.
Fixes #2638
Fixes #8952
Fixes #10907