Center pages vertically in PresentationMode (issue 10906) #14298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
issue-10906
branch
from
1d7a009 to
15c83b8
Compare
Snuffleupagus
force-pushed
the
issue-10906
branch
from
15c83b8 to
90a0639
Compare
*This patch can be tested e.g. with the `sizes.pdf` document in the test-suite.* While this patch isn't necessarily the best solution, e.g. it might be possible to solve this with *only* CSS, it's what I was able to come up with to address an old issue. The solution here re-uses the `spread`-class in PresentationMode, since that one already takes care of centering pages *vertically*, together with a dummy-page that takes up the entire height of the window. Finally, some PresentationMode-related CSS-rules are also simplified slightly, since the changes in PR 14112 (using Page-scrolling) allows some clean-up here.
Snuffleupagus
force-pushed
the
issue-10906
branch
from
90a0639 to
f7b1da4
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/729566bb79e633e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/729566bb79e633e/output.txt Total script time: 4.31 mins Published |
timvandermeij
approved these changes
Nov 24, 2021
|
Let's do this; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch can be tested e.g. with the
sizes.pdfdocument in the test-suite.While this patch isn't necessarily the best solution, e.g. it might be possible to solve this with only CSS, it's what I was able to come up with to address an old issue.
The solution here re-uses the
spread-class in PresentationMode, since that one already takes care of centering pages vertically, together with a dummy-page that takes up the entire height of the window.Finally, some PresentationMode-related CSS-rules are also simplified slightly, since the changes in PR #14112 (using Page-scrolling) allows some clean-up here.
Fixes #10906