Slightly optimize spreadMode toggling with ScrollMode.PAGE set (PR 14112 follow-up)
#14280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
spreadMode toggling with scrollMode.PAGE set (PR 14112 follow-up)spreadMode toggling with ScrollMode.PAGE set (PR 14112 follow-up)
…R 14112 follow-up) It shouldn't be necessary to iterate through *all* pages when using a non-default `spreadMode`, since we already know which page(s) should become visible. This code is a left-over from the initial (local) implementation that resulted in PR 14112, however I forgot to clean-up some things such as e.g. this loop. Also fixes an outdated comment, see PR 14204 which removed the mentioned data-structure.
Snuffleupagus
force-pushed
the
scrollMode-PAGE-spread-loop
branch
from
1f2806f to
1214c05
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8079f063162c545/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8079f063162c545/output.txt Total script time: 4.34 mins Published |
timvandermeij
approved these changes
Nov 17, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shouldn't be necessary to iterate through all pages when using a non-default
spreadMode, since we already know which page(s) should become visible.This code is a left-over from the initial (local) implementation that resulted in PR #14112, however I forgot to clean-up some things such as e.g. this loop.
Also fixes an outdated comment, see PR #14204 which removed the mentioned data-structure.