Update Octicons

[miguelsolorio]

Fixes #65508 and fixes #36053

This updates our version of Octicons, while still having backward compatibility with icons that have been removed in the newer versions. I've created this tool that generates the new icon from the Octicon npm module.

The only minor changes are that organization and person are now filled versions instead of outlines.

Additions

• arrow-both
• bold
• eye-closed
• fold-down
• fold-up
• grabber
• italic
• kebab-horizontal
• kebab-vertical
• logo-gist
• note
• plus-small
• project
• screen-full
• screen-normal
• smiley
• tasklist
• text-size
• unverified
• verified

Updated

• color-mode is persisted
• organization-filled is for the new version of the icon
• person-filled is for the new version of the icon

Comparison

After installing a few extensions that use octicons in the statusbar (vscode-spotify, live share, github pull request), you can compare the differences.

[bpasero]

@misolori very cool. some thoughts:

Here is a screenshot of the new icons we get:

I feel like some we should maybe revisit (maybe exclude?), especially:

• the ones that show up very small (e.g. the + icon)
• the "Gist" one does not make a lot of sense imho.

Otherwise, I would suggest that we maybe keep those icons that change a lot (e.g. the people icon for live share) and have the new one under a different name?

[bpasero]

Approving, the change looks to me good otherwise.

[bpasero]

@misolori just noticed two things:

• please keep in mind to release note this properly, I would also think we could create an issue over in vscode-docs to document the valid icons a bit better (maybe with showing the icon on the website?)
• run a search for octicon in our repo to see where we use octicons in our core and verify nothing is broken, e.g. it looks like in some places we directly reference an icon through CSS
• finally it would be good to run a full build with your changes just to make sure things are packaged up properly. e.g. I noticed some build rules in our gulpfiles related to octicons

[miguelsolorio]

@bpasero:

• Removing the logo-gist and plus-small is totally fine. I've seen people not wanting the Gist logo in other issues and we already have a regular plus.
• I can do a swap of the people and organization icons for Live Share and move the new ones to the appended name
• I was already planning on mentioning this in the release notes, I've created Document changes to Octicons vscode-docs#2315 to track this is
• I'll also do a final test and double-check the other areas Octicons are being used and create a custom build

👍 Thanks for feedback!

[bpasero]

@misolori great, feel free to merge then after you tested the build

[miguelsolorio]

Fixed a rendering bug that appeared in Windows, still need to test on Linux and then will merge.

[miguelsolorio]

Verified the changes on macOS/Win10/Linux and it all looks good, will merge this in.