Skip to content

Document changes to Octicons #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miguelsolorio opened this issue Jan 4, 2019 · 7 comments
Closed

Document changes to Octicons #2315

miguelsolorio opened this issue Jan 4, 2019 · 7 comments
Assignees
Milestone

Comments

@miguelsolorio
Copy link

miguelsolorio commented Jan 4, 2019

Once the new version of Octicons is merged into master (microsoft/vscode#65989) we're going to need proper documentation of these changes in the release notes.

We should also try to address #1094 and provide proper documentation for Octicons in our extensible docs. @octref, do you have any ideas of where this should be placed in our docs?

@octref
Copy link
Contributor

octref commented Jan 4, 2019

Here's our only reference to it: https://code.visualstudio.com/api/references/vscode-api#StatusBarItem

@miguelsolorio
Copy link
Author

Are there other places where extension authors could use Octicon?

As far as I know it's only the Status Bar and Quick Pick (see GitLens > Show Commit Details). @bpasero, can you confirm?

@octref
Copy link
Contributor

octref commented Jan 4, 2019

Reminder: need to reference to it in https://github.com/Microsoft/vscode-extension-samples/tree/master/quickinput-sample too, then.

@gregvanl gregvanl added this to the January 2019 milestone Jan 4, 2019
@bpasero
Copy link
Member

bpasero commented Jan 5, 2019

@misolori I think octicons can also be used in hovers, I believe the GitLens extension (@eamodio) is doing that. He might also know more locations from his usage.

@eamodio
Copy link
Contributor

eamodio commented Jan 5, 2019

AFAIK, they can only be in the status bar and quick picks. I had to resort to unicode "icons" in the hovers 😉

@bpasero
Copy link
Member

bpasero commented Jan 5, 2019

Ah ok 👍

@gregvanl
Copy link

gregvanl commented Feb 6, 2019

@gregvanl gregvanl closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants