[Settings Editor] Fix add button visibility in object settings #101810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9at8
changed the title
additionalProperties is false
roblourens
approved these changes
Jul 6, 2020
9at8
force-pushed
the
adi/add-button-visibility
branch
from
a22dfa9 to
493cc54
Compare
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jul 8, 2020
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jul 9, 2020
gopherbot
pushed a commit
to golang/vscode-go
that referenced
this pull request
Jul 15, 2020
When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `additionalProperties` to `false` for the objects that don't expect more properties would be great! As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if `additionalProperties` is `false` and all known properties are present. Change-Id: I92380610b24f7cd6ee790f2e020b9c689c3ff25b GitHub-Last-Rev: 695aa78 GitHub-Pull-Request: #284 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240907 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101354
Only hide the add button if and only if
additionalPropertiesis false and all known properties are present.