Skip to content

Commit a22dfa9

Browse files
author
Aditya Thakral
committed
Hide button iff additionalProperties is false
Fixes #101354
1 parent 86ee453 commit a22dfa9

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/vs/workbench/contrib/preferences/browser/settingsTree.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,13 +1116,15 @@ export class SettingObjectRenderer extends AbstractSettingRenderer implements IT
11161116

11171117
protected renderValue(dataElement: SettingsTreeSettingElement, template: ISettingObjectItemTemplate, onChange: (value: string) => void): void {
11181118
const items = getObjectDisplayValue(dataElement);
1119+
const { objectProperties, objectPatternProperties, objectAdditionalProperties } = dataElement.setting;
11191120

11201121
template.objectWidget.setValue(items, {
1121-
showAddButton: (
1122-
typeof dataElement.setting.objectAdditionalProperties === 'object' ||
1123-
isDefined(dataElement.setting.objectPatternProperties) ||
1124-
!areAllPropertiesDefined(Object.keys(dataElement.setting.objectProperties ?? {}), items)
1125-
),
1122+
showAddButton: objectAdditionalProperties === false
1123+
? (
1124+
!areAllPropertiesDefined(Object.keys(objectProperties ?? {}), items) ||
1125+
isDefined(objectPatternProperties)
1126+
)
1127+
: true,
11261128
keySuggester: createObjectKeySuggester(dataElement),
11271129
valueSuggester: createObjectValueSuggester(dataElement),
11281130
});

0 commit comments

Comments
 (0)