Skip to content

Commit 493cc54

Browse files
author
Aditya Thakral
committed
Hide button iff additionalProperties is false
Fixes #101354
1 parent 71a147f commit 493cc54

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/vs/workbench/contrib/preferences/browser/settingsTree.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,14 +1130,16 @@ export class SettingObjectRenderer extends AbstractSettingRenderer implements IT
11301130

11311131
protected renderValue(dataElement: SettingsTreeSettingElement, template: ISettingObjectItemTemplate, onChange: (value: string) => void): void {
11321132
const items = getObjectDisplayValue(dataElement);
1133+
const { key, objectProperties, objectPatternProperties, objectAdditionalProperties } = dataElement.setting;
11331134

11341135
template.objectWidget.setValue(items, {
1135-
settingKey: dataElement.setting.key,
1136-
showAddButton: (
1137-
typeof dataElement.setting.objectAdditionalProperties === 'object' ||
1138-
isDefined(dataElement.setting.objectPatternProperties) ||
1139-
!areAllPropertiesDefined(Object.keys(dataElement.setting.objectProperties ?? {}), items)
1140-
),
1136+
settingKey: key,
1137+
showAddButton: objectAdditionalProperties === false
1138+
? (
1139+
!areAllPropertiesDefined(Object.keys(objectProperties ?? {}), items) ||
1140+
isDefined(objectPatternProperties)
1141+
)
1142+
: true,
11411143
keySuggester: createObjectKeySuggester(dataElement),
11421144
valueSuggester: createObjectValueSuggester(dataElement),
11431145
});

0 commit comments

Comments
 (0)