Skip to content

Remove fast components as a package and subsequently remove fast-component-explorer #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 6, 2022

Conversation

chrisdholt
Copy link
Member

@chrisdholt chrisdholt commented Apr 15, 2022

Pull Request

📖 Description

This PR removes the @microsoft/fast-components package from the repository and also subsequently removes the component explorer.

While the package will be removed, we should keep the component explorer up until any documentation changes are addressed as the package still exists - it's simply locked at it's current implementation.

This PR should go in after we clear a few key PR's out of the queue. Any PR's solely impacting fast-foundation behavior can likely either go in before this or after.

We should publish one additional time before removing this to clear the queue of changes waiting to be shipped.

🎫 Issues

resolves #5849
resolves #3854

👩‍💻 Reviewer Notes

  1. The build should pass
  2. The sites should build without failure

📑 Test Plan

Please validate that the website builds as expected.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@chrisdholt chrisdholt added area:fast-components community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. labels Apr 15, 2022
@chrisdholt chrisdholt self-assigned this Apr 15, 2022
@chrisdholt chrisdholt changed the title Users/chhol/remove fast components as a package Remove fast components as a package and subsequently remove fast-component-explorer Apr 15, 2022
@awentzel
Copy link
Collaborator

@chrisdholt should we delete the component explorer workflow file as well or would you like me to come in with a follow up PR to remove all DevOps related to Component Explorer?

@chrisdholt chrisdholt force-pushed the users/chhol/remove-fast-components-as-a-package branch from 84b5f4b to 48e15a2 Compare April 20, 2022 19:39
@chrisdholt chrisdholt force-pushed the users/chhol/remove-fast-components-as-a-package branch from 039f8ea to fe4c475 Compare May 6, 2022 18:33
@github-actions
Copy link

github-actions bot commented May 6, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5853.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented May 6, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5853.centralus.azurestaticapps.net

@chrisdholt chrisdholt force-pushed the users/chhol/remove-fast-components-as-a-package branch from 5ae5934 to 6acb6cd Compare May 6, 2022 21:00
@chrisdholt
Copy link
Member Author

@chrisdholt should we delete the component explorer workflow file as well or would you like me to come in with a follow up PR to remove all DevOps related to Component Explorer?

Removed as part of this the deploy to staging!

@github-actions
Copy link

github-actions bot commented May 6, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5853.centralus.azurestaticapps.net

@chrisdholt chrisdholt merged commit 890ff05 into master May 6, 2022
@chrisdholt chrisdholt deleted the users/chhol/remove-fast-components-as-a-package branch May 6, 2022 21:19
@github-actions
Copy link

github-actions bot commented May 6, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5853.centralus.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community:noteworthy An issue or PR of particular interest to the community or planned for an announcement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The future of FAST Components Update Component Explorer to use Web Components
3 participants