Skip to content

Correct elevation algorithm in web-components #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicholasrice opened this issue Mar 10, 2020 · 4 comments
Closed

Correct elevation algorithm in web-components #2778

nicholasrice opened this issue Mar 10, 2020 · 4 comments
Labels
area:fast-foundation Pertains to fast-foundation feature A new feature status:needs-investigation Needs additional investigation warning:stale No recent activity within a reasonable amount of time

Comments

@nicholasrice
Copy link
Contributor

The elevation is algorithm is dependent on the relative luminance of the regions background. Right now the value is hard-coded to the relative luminance of white, but we'll want to update this implementation when we get recipe support from @microsoft/fast-element.

We'll want to land implementation details, but a few options are:

  • When the background color is set by any recipe, the relative luminance of that background color should also be written. Then this recipe could always be used.
  • Bind an "elevation" recipe to the control that would write the --background-luminance value.
@ghost ghost added the status:triage New Issue - needs triage label Mar 10, 2020
@nicholasrice nicholasrice added the feature A new feature label Mar 10, 2020
@ghost ghost removed the status:triage New Issue - needs triage label Mar 10, 2020
@nicholasrice nicholasrice mentioned this issue Mar 10, 2020
Merged
8 tasks
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the reason : stale label Jul 18, 2020
@EisenbergEffect EisenbergEffect added area:fast-components area:fast-foundation Pertains to fast-foundation status:needs-investigation Needs additional investigation and removed reason : stale labels Jul 20, 2020
@nicholasrice
Copy link
Contributor Author

related to #3443

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Dec 25, 2020
@chrisdholt
Copy link
Member

Closing given #5853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:fast-foundation Pertains to fast-foundation feature A new feature status:needs-investigation Needs additional investigation warning:stale No recent activity within a reasonable amount of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EisenbergEffect @nicholasrice @chrisdholt