Skip to content

Add support for text in slots to Explorer #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bheston opened this issue Aug 17, 2020 · 5 comments
Closed

Add support for text in slots to Explorer #3732

bheston opened this issue Aug 17, 2020 · 5 comments
Labels
status:under-consideration Issue is being reviewed by the team. warning:stale No recent activity within a reasonable amount of time

Comments

@bheston
Copy link
Collaborator

bheston commented Aug 17, 2020

What feature are you requesting?

Currently in Explorer it's possible to add "Text" elements as the content of a slot, say for a fast-button, however it isn't marked to appear in the correct slot.

What would be the benefit of adding this feature?

It makes the tool look like it's broken. We should wrap it in whatever is necessary to make it appear in the correct slot.

What solution would be ideal for you?

Possibly wrapping text in a span, but anything that works is fine.

Slots with "Text":
fast-button slots-text

Slots with fast-badge:
fast-button-slots-badge

@bheston bheston added status:under-consideration Issue is being reviewed by the team. area:tools labels Aug 17, 2020
@janechu
Copy link
Collaborator

janechu commented Aug 25, 2020

In order to do this we should:

  • Ensure we cannot add text to any other slot than the default
  • Create a configuration for the span (and other elements) so that when added there is some content

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Dec 25, 2020
@janechu janechu removed the warning:stale No recent activity within a reasonable amount of time label Mar 1, 2021
@chrisdholt
Copy link
Member

@janechu are we still tracking this as an issue? Just wanted to check if it's still open or if we can close it out

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Apr 16, 2022
@chrisdholt
Copy link
Member

closing given #5853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under-consideration Issue is being reviewed by the team. warning:stale No recent activity within a reasonable amount of time
Projects
None yet
Development

No branches or pull requests

3 participants