chain: add testnet4 support #9620

guggero · 2025-03-20T17:09:00Z

Adds testnet4 support to lnd.

Fixes #8966.

Depends on btcsuite/btcwallet#994 and lightninglabs/neutrino#311.

coderabbitai · 2025-03-20T17:09:07Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Impa10r · 2025-03-20T21:13:41Z

builds fine, but cannot bootstrap:

2025-03-20 22:09:29.545 [INF] DISC: Attempting to bootstrap with: Authenticated Channel Graph
2025-03-20 22:09:29.547 [ERR] SRVR: Unable to retrieve initial bootstrap peers: no addresses found

don't know if related or not, create followed by getinfo also fails:

~ $ lncli create
Input wallet password:
Confirm password:

Do you have an existing cipher seed mnemonic or extended master root key you want to use?
Enter 'y' to use an existing cipher seed mnemonic, 'x' to use an extended master root key
or 'n' to create a new seed (Enter y/x/n): n

Your cipher seed can optionally be encrypted.
Input your passphrase if you wish to encrypt it (or press enter to proceed without a cipher seed passphrase):

Generating fresh cipher seed...

!!!YOU MUST WRITE DOWN THIS SEED TO BE ABLE TO RESTORE THE WALLET!!!

---------------BEGIN LND CIPHER SEED---------------
 ...
---------------END LND CIPHER SEED-----------------

!!!YOU MUST WRITE DOWN THIS SEED TO BE ABLE TO RESTORE THE WALLET!!!

lnd successfully initialized!
~ $ lncli getinfo
[lncli] rpc error: code = Unknown desc = verification failed: signature mismatch after caveat verification

Roasbeef · 2025-03-20T23:12:28Z

builds fine, but cannot bootstrap:
2025-03-20 22:09:29.547 [ERR] SRVR: Unable to retrieve initial bootstrap peers: no addresses found

So it's an entirely new network. Someone needs to run DNS seed infrastructure for it, but none for the network currently exist at present.

don't know if related or not, create followed by getinfo also fails:

I suspect some code is still using the testnet3 path when it should be using the testnet4 path (or you forgot to set the flag in lncli).

Roasbeef · 2025-03-20T23:13:44Z

chainreg/chainparams.go

@@ -22,6 +22,14 @@ var BitcoinTestNetParams = BitcoinNetParams{
 	CoinType: keychain.CoinTypeTestnet,
 }

+// BitcoinTestNet4Params contains parameters specific to the 4th version of the


We should also update lncli to mention that testnet4 is an option for the --network command.

yep

$ lncli --network=testnet4 getinfo [lncli] could not load global options: unknown network: testnet4

I did add that. Are you sure you re-compiled and installed lncli from the branch?

yes, tried again, now lncli works, but lnd does not create admin.macaroon

~ $ lnd 2025-03-24 21:46:49.302 [WRN] LTND: Config 'dust-threshold' is deprecated, please remove it 2025-03-24 21:46:49.302 [INF] LTND: Version Info rev=d757bb version=0.18.99-beta commit=tor/v1.1.6-109-gd757bb51e debuglevel=production logging=info 2025-03-24 21:46:49.302 [INF] LTND: Network Info rev=d757bb active_chain=Bitcoin network=testnet4 2025-03-24 21:46:49.303 [INF] RPCS: RPC server listening on 0.0.0.0:10009 2025-03-24 21:46:49.335 [INF] RPCS: gRPC proxy started at 127.0.0.1:8080 2025-03-24 21:46:49.336 [INF] LTND: Opening the main database, this might take a few minutes... 2025-03-24 21:46:49.336 [INF] LTND: Opening bbolt database, sync_freelist=false, auto_compact=false 2025-03-24 21:46:49.351 [INF] LTND: Creating local graph and channel state DB instances 2025-03-24 21:46:49.360 [INF] CHDB: Checking for schema update: latest_version=33, db_version=33 2025-03-24 21:46:49.360 [INF] CHDB: Checking for optional update: prune_revocation_log=false, db_version=empty 2025-03-24 21:46:49.360 [INF] LTND: Database(s) now open (time_to_open=24.300106ms)! 2025-03-24 21:46:49.360 [INF] LTND: We're not running within systemd or the service type is not 'notify' 2025-03-24 21:46:49.360 [INF] LTND: Waiting for wallet encryption password. Use `lncli create` to create a wallet, `lncli unlock` to unlock an existing wallet, or `lncli changepassword` to change the password of an existing wallet and unlock it. $ lncli --network=testnet4 getinfo [lncli] could not load global options: unable to read macaroon path (check the network setting!): open /home/vlad/.lnd/data/chain/bitcoin/testnet4/admin.macaroon: no such file or directory $ ls ~/.lnd/data/chain/bitcoin/testnet4 macaroons.db

You need to unlock/create a wallet first.

Confirmed I can interact using lncli on testent4 np.

Roasbeef

LGTM 🏮

tACK

We'll work on standing up DNS infrastructure in the background so nodes can boostrap.

twofaktor · 2025-03-24T23:10:01Z

We'll work on standing up DNS infrastructure in the background so nodes can boostrap.

Will a testnet4 external fee estimator URL, such as https://nodes.lightning.computer/fees/v1/btctestnet4-fee-estimates.json, also be provided ?

Impa10r · 2025-03-26T01:22:25Z

if anyone wants to open a testnet4 channel, do 50/50, or want me to open to them, ping t.me/MiddleWayNode

It will be up 24/7 at 03a17ec2c693c82d7b8d6616dcaf57cbfb0df506045612e08c9580b0c55dda2c1d@72elnf2w7ahgqkwhqfh3pjrxdtwdszpl3bqhly6ipx6agz4sc6kwkfid.onion:9735

Impa10r · 2025-03-26T13:26:50Z

Hi @guggero. lncli reports all errors as "wallet is encrypted":

% lncli openchannel --node_key 030f289f0f931cd33cc3435dc5f5fc2a6a65bb0297327d43e82562aded10df74a7 --fee_rate_ppm 1 --local_amt 5000000
[lncli] wallet is encrypted - please unlock using 'lncli unlock', or set password using 'lncli create' if this is the first time starting lnd

while in the log:

2025-03-26 13:24:03.150 [INF] CHFD: Performing funding tx coin selection using 8626 sat/kw as fee rate
2025-03-26 13:24:03.150 [ERR] RPCS: unable to open channel to NodeKey(030f289f0f931cd33cc3435dc5f5fc2a6a65bb0297327d43e82562aded10df74a7): not enough witness outputs to create funding transaction, need 0.15000000 BTC only have 0 BTC available
2025-03-26 13:24:03.151 [ERR] RPCS: [/lnrpc.Lightning/OpenChannel]: not enough witness outputs to create funding transaction, need 0.15000000 BTC only have 0 BTC available

guggero · 2025-03-26T13:49:29Z

Can you create a new issue please? Might be a bug introduced by #9605.

adambor · 2025-05-10T21:43:25Z

if anyone needs a channel peer on clearnet, feel free to connect and open a channel: 024c6e1edd12f0792d0c1ddda3abc6e2fde6bf89f2848e00cf8d6a58fabb6c3ab6@81.17.102.136:9735

twofaktor · 2025-05-16T17:23:04Z

LGTM 🏮

tACK

We'll work on standing up DNS infrastructure in the background so nodes can boostrap.

We're already on rc5, and the mentioned infrastructure hasn't been implemented yet. Is it planned to be operational by the final version of v0.19.0?

guggero mentioned this pull request Mar 20, 2025

[feature]: testnet4 support #8966

Closed

guggero force-pushed the testnet4 branch from ac05fa9 to d0f49bd Compare March 20, 2025 17:09

Roasbeef reviewed Mar 20, 2025

View reviewed changes

guggero added 3 commits March 24, 2025 11:53

mod: bump btcwallet and neutrino to latest version

e5b9d96

multi: add testnet4 support

0aea482

docs: add release notes

d757bb5

guggero force-pushed the testnet4 branch from d0f49bd to d757bb5 Compare March 24, 2025 16:53

Roasbeef approved these changes Mar 24, 2025

View reviewed changes

Roasbeef merged commit 67d2eac into lightningnetwork:master Mar 24, 2025
34 of 35 checks passed

guggero deleted the testnet4 branch March 25, 2025 13:13

This was referenced Mar 30, 2025

feat: add testnet4 network apotdevin/thunderhub#623

Open

feat: add testnet4 network LN-Zap/lndconnect#32

Open

Impa10r mentioned this pull request Apr 3, 2025

Add testnet4 support ElementsProject/peerswap#369

Merged

chain: add testnet4 support #9620

chain: add testnet4 support #9620

Uh oh!

Conversation

guggero commented Mar 20, 2025

Uh oh!

coderabbitai bot commented Mar 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Impa10r commented Mar 20, 2025

Uh oh!

Roasbeef commented Mar 20, 2025

Uh oh!

Roasbeef Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

Impa10r Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guggero Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Impa10r Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

guggero Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Roasbeef Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Roasbeef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

twofaktor commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Impa10r commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Impa10r commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guggero commented Mar 26, 2025

Uh oh!

adambor commented May 10, 2025

Uh oh!

twofaktor commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)

Impa10r Mar 20, 2025 •

edited

Loading

twofaktor commented Mar 24, 2025 •

edited

Loading

Impa10r commented Mar 26, 2025 •

edited

Loading

Impa10r commented Mar 26, 2025 •

edited

Loading

twofaktor commented May 16, 2025 •

edited

Loading