Skip to content

Add testnet4 support #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add testnet4 support #369

wants to merge 2 commits into from
+18 −6

Conversation

Impa10r
Copy link
Contributor

@Impa10r Impa10r commented Apr 3, 2025 •
edited
Loading

lnd and cln now support testnet4 lightningnetwork/lnd#9620, ps should too

@Impa10r Impa10r mentioned this pull request Apr 3, 2025
Closed
YusukeShimizu
YusukeShimizu reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@YusukeShimizu YusukeShimizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the same consideration is necessary for validateNetwork as well.
https://github.com/ElementsProject/peerswap/blob/master/swap/messages.go#L123

Could you please check if the swap is functioning properly?

Also, could you handle the corresponding change on the CLN side? It seems that support for testnet4 was recently added ElementsProject/lightning#8171.

@Impa10r
Copy link
Contributor Author

Impa10r commented Apr 4, 2025 •
edited
Loading

thanks. updated and confirm working with lnd. struggling to test with cln so far: #370

@Impa10r Impa10r mentioned this pull request Apr 5, 2025
Closed
@Impa10r
Copy link
Contributor Author

Impa10r commented Apr 9, 2025

tested swaps between LND and CLN, thanks to this PR: #371

@YusukeShimizu
Copy link
Contributor

Would you mind reverting that merge commit and rebasing instead?

@Impa10r
Copy link
Contributor Author

Impa10r commented Apr 14, 2025 •
edited
Loading

Would you mind reverting that merge commit and rebasing instead?

took a few tries with chatgpt, but I think I finally got what you asked. thanks for teaching me something new! the branch works fine with cln and lnd...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YusukeShimizu YusukeShimizu YusukeShimizu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Impa10r @YusukeShimizu