rpc: return raw peerswaprpc.PremiumRate pointers #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix returning proto definitions to ease unmarshal for PremiumRate. - We previously format peerswaprpc.PremiumRate for readability. - That makes unmarshal over RPC calls inconvenient. - cln does not distinguish API and CLI outputs, preventing separation. - Return raw proto definitions directly to fix RPC usage issues. - Some 0-value fields may be omitted due to proto generation limits. - Removing omit empty tags later may resolve those readability issues.
YusukeShimizu
changed the title
|
Merged into my testnet4 branch and it fixed the issue with CLN premiums. Thanks! |
Merged
|
tACK b242fae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix returning proto definitions to ease unmarshal for PremiumRate.
We previously format peerswaprpc.PremiumRate for readability. #264 (comment)
But, that makes unmarshal over RPC calls inconvenient.
To callable, return raw proto definitions directly to fix RPC usage issues.
Some 0-value fields may be omitted due to proto generation limits.
Removing omit empty tags later may resolve those readability issues.
In cln, CLI output and RPC calls are not separated.
Because of this, it is not possible to make the CLI output human-readable while returning raw proto for RPC.