Skip to content

Add testnet4 support #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Add testnet4 support #994

merged 2 commits into from
Mar 20, 2025

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Mar 12, 2025

Ready for review, since btcsuite/btcd#2339 got merged.

@guggero guggero marked this pull request as ready for review March 18, 2025 20:47
@guggero guggero requested a review from yyforyongyu March 18, 2025 20:47
Copy link
Collaborator

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

if err != nil {
return nil, err
}
sigBytes := ecdsa.SignCompact(privKey, messageHash, true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Was getting this error locally since I use go work.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎿

@Roasbeef Roasbeef merged commit aa41aba into master Mar 20, 2025
3 checks passed
@guggero guggero deleted the testnet4 branch March 23, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants