Skip to content

267 add unit test@main #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

267 add unit test@main #293

wants to merge 2 commits into from

Conversation

ayogasekaram
Copy link
Contributor

closes #267


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Unit Tests Summary

  1 files  182 suites   1m 15s ⏱️
180 tests 179 ✅ 0 💤 1 ❌
751 runs  750 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 52a96cf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_categorical.survey.design 💚 $15.65$ $-1.31$ ard_categorical.survey.design_works
ard_categorical_ci.data.frame 👶 $+0.00$ ard_categorical_ci_method_strat_wilson_NA_handling
ard_continuous.survey.design 💔 $9.89$ $+2.33$ unstratified_ard_continuous.survey.design_works

Results for commit 4478c13

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant