267 add unit test@main (#293)

closes #267 



--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [ ] If a bug was fixed, a unit test was added.
- [ ] If a new `ard_*()` function was added, it passes the ARD
structural checks from `cards::check_ard_structure()`.
- [ ] If a new `ard_*()` function was added, `set_cli_abort_call()` has
been set.
- [ ] If a new `ard_*()` function was added and it depends on another
package (such as, `broom`), `is_pkg_installed("broom")` has been set in
the function call and the following added to the roxygen comments:
`@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg =
"broom""))`
- [ ] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`

Reviewer Checklist (if item does not apply, mark is as complete)

- [ ] If a bug was fixed, a unit test was added.
- [ ] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [ ] Update `NEWS.md` with the changes from this pull request under the
heading "`# cardx (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] Approve Pull Request
- [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

---------

Signed-off-by: Daniel Sjoberg <[email protected]>
Co-authored-by: Daniel Sjoberg <[email protected]>

Author: ayogasekaram

R/ard_categorical_ci.R

@@ -78,6 +78,13 @@ ard_categorical_ci.data.frame <- function(data,
     cards::process_selectors(data, strata = {{ strata }})
     check_scalar(strata)
   }
+
+  # if the method is strat_wilson, `weights` and `strata` cannot contain NA values
+  if (method %in% c("strat_wilson")) {
+    if (any(is.na({{ weights }}))) {
+      cli::cli_warn("{.field weights} cannot contain {.val NA} values.")
+    }
+  }
   cards::process_formula_selectors(
     data[variables],
     value = value

tests/testthat/test-ard_categorical_ci.data.frame.R

@@ -231,7 +231,7 @@ test_that("ard_continuous_ci.data.frame(denominator='row')", {
       variables = am,
       denominator = "row"
     ) |>
-      dplyr::filter(group1_level %in% 4, group2_level %in% 3) |>
+      dplyr::filter(group1_level %in% 4, unlist(group2_level) == 3) |>
       cards::get_ard_statistics(),
     proportion_ci_wald(
       x = (mtcars$cyl == 4 & mtcars$gear == 3)[mtcars$am == 1],
@@ -316,7 +316,7 @@ test_that("ard_continuous_ci.data.frame(denominator='cell')", {
       variables = am,
       denominator = "cell"
     ) |>
-      dplyr::filter(group1_level %in% 4, group2_level %in% 3) |>
+      dplyr::filter(group1_level %in% 4, unlist(group2_level) %in% 3) |>
       cards::get_ard_statistics(),
     proportion_ci_wald(
       x = (mtcars$cyl == 4 & mtcars$gear == 3 & mtcars$am == 1),
@@ -428,3 +428,66 @@ test_that("ard_continuous_ci.data.frame() NA handling", {
     proportion_ci_wald((df$am == 0) + (df$cyl == 4) > 1)
   )
 })
+
+test_that("ard_categorical_ci(method = 'strat_wilson') NA handling", {
+  # no NAs
+  rsp <- c(
+    sample(c(TRUE, FALSE), size = 40, prob = c(3 / 4, 1 / 4), replace = TRUE),
+    sample(c(TRUE, FALSE), size = 40, prob = c(1 / 2, 1 / 2), replace = TRUE)
+  )
+  grp <- factor(rep(c("A", "B"), each = 40), levels = c("B", "A"))
+  strata_data <- data.frame(
+    "f1" = sample(c("a", "b"), 80, TRUE),
+    "f2" = sample(c("x", "y", "z"), 80, TRUE),
+    stringsAsFactors = TRUE
+  )
+
+  weights <- 1:6 / sum(1:6)
+
+  # data with NA values
+
+  strata_na <- rbind(strata_data, data.frame(f1 = c(NA, NA), f2 = c(NA, NA)))
+  rsp_na <- c(rsp, NA, NA)
+  weights_na <- c(weights, NA, NA)
+
+  # NA in the strata
+  expect_equal(
+    ard_categorical_ci(
+      data = data.frame(
+        rsp = rsp,
+        strata = interaction(strata_data)
+      ),
+      variables = rsp,
+      strata = strata,
+      weights = weights,
+      max.iterations = 10,
+      method = "strat_wilson"
+    ),
+    ard_categorical_ci(
+      data = data.frame(
+        rsp = rsp_na,
+        strata = interaction(strata_na)
+      ),
+      variables = rsp,
+      strata = strata,
+      weights = weights,
+      max.iterations = 10,
+      method = "strat_wilson"
+    )
+  )
+
+  # NA in weights should return a cli warning message
+  expect_warning(
+    ard_categorical_ci(
+      data = data.frame(
+        rsp = rsp_na,
+        strata = interaction(strata_na)
+      ),
+      variables = rsp,
+      strata = strata,
+      weights = weights_na,
+      max.iterations = 10,
+      method = "strat_wilson"
+    )
+  )
+})