Skip to content

Investigate whether there are issues with missing values in strata or weights arguments for ard_categorical_ci(method='strat_wilson') #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddsjoberg opened this issue Feb 15, 2025 · 4 comments · May be fixed by #293
Assignees
Labels
Milestone

Comments

@ddsjoberg
Copy link
Collaborator

No description provided.

@ddsjoberg ddsjoberg added this to the v0.3.0 milestone Feb 26, 2025
@ddsjoberg ddsjoberg added the sme label Feb 26, 2025
@ayogasekaram
Copy link
Contributor

Hey @ddsjoberg, I was able to test a few scenarios with missing values and there appears to be no errors in this function. Is this okay to close?

@ddsjoberg
Copy link
Collaborator Author

Thanks @ayogasekaram ! Can you add a unit test comparing the results when a data frame has NA values and when those values have first been removed from the data frame?

@ayogasekaram
Copy link
Contributor

@ddsjoberg so it looks like NAs in the strata performs fine but NA in the weights argument returns an error. I've pushed some tests to the '267_add_unit_test@main' branch if you'd like to take a look.

@ddsjoberg
Copy link
Collaborator Author

@ayogasekaram can you make a PR and assign me to review? thanks!

@ayogasekaram ayogasekaram linked a pull request Apr 29, 2025 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants