fix(server): clear activity when asset is removed from album #19019
+61
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahool
requested review from
alextran1502 and
mertalev
and removed request for
alextran1502
8 tasks
danieldietzler
requested changes
Jun 18, 2025
server/src/sql-tools/from-code/decorators/composite-foreign-key.decorator.ts
Outdated
Show resolved
Hide resolved
mertalev
approved these changes
Jun 19, 2025
|
I wonder, should I update the migration to be at the bottom? from my testing, the migration order seems to be important, and since there have been others added after I created the PR, I'm guessing it will fail to run on an existing system |
|
Yes, just change the name to be a bigger number |
jrasm91
reviewed
Jun 20, 2025
server/src/schema/migrations/1749235207144-AddActivityAssetFk.ts
Outdated
Show resolved
Hide resolved
jrasm91
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for #17475 as discussed in PR #18927
Schema checks will fail since I cannot update activity.table.ts since this change is not supported yet
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)