fix(server): do not list album activity for assets that are not in the album anymore

[dahool]

Description

This is a minor fix to prevent listing album activity from assets that are not available anymore.

Fixes #17475

How Has This Been Tested?

See #17475

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation if applicable
• I have no unrelated changes in the PR.
• I have confirmed that any new dependencies are strictly necessary.
• I have written tests for new code (if applicable)
• I have followed naming conventions/patterns in the surrounding code
• All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
• All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

[mertalev]

Actually, I wonder if this could instead be handled with DDL with something like FOREIGN KEY ("albumId", "assetId") REFERENCES albums_assets_assets ON DELETE CASCADE. My understanding is that assetId would be allowed to be null, but if both are non-null then the constraint would kick in.

Possibly better handled with DDL

[dahool]

well it depends, how the functionallity is supposed to work. I see 2 possibilities

• op 1: the activity is cleared when the assets is removed from the album (yes, this could be resolved with a simple constraint)
• op 2 (this): we recover the activity history if the asset is restored to the album.

[dahool]

option 1: d6626fa

[mertalev]

I think it makes sense for the activity to be reset when you remove the asset. You should update the table definition under src/schema/tables as well.

[dahool]

I think it makes sense for the activity to be reset when you remove the asset. You should update the table definition under src/schema/tables as well.

I'm not exactly sure what you guys are using here, I thought at first it was typeorm, but looks like some custom lib

[mertalev]

I think it makes sense for the activity to be reset when you remove the asset. You should update the table definition under src/schema/tables as well.

I'm not exactly sure what you guys are using here, I thought at first it was typeorm, but looks like some custom lib

Yes, it's an internal library to have TypeORM-like table definitions while using Kysely.

[alextran1502]

Hello, can you help add e2e or a medium test for this?

[dahool]

Hello, can you help add e2e or a medium test for this?

are we going to use this patch or the one in #19019 ?

[alextran1502]

Ah sorry, probably the other one is preferred

[dahool]

closing this PR as it has been superseded by #19019