Skip to content

Detph stream 38 0 2117 0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10,000 commits into from
Closed

Detph stream 38 0 2117 0 #4

wants to merge 10,000 commits into from

Conversation

qiansunn
Copy link

hi,ningxin
this version can run correctly

[email protected] and others added 30 commits August 6, 2014 00:18
Update .DEPS.git
796b273 
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287654 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
a54c560 
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287655 0039d316-1c4b-4281-b951-d872f2087c98
Revert 285416 "Make chrome app colored frames available on Chrom..."
3bd21fe 
This isn't right from a UI perspective. Needs to be reimplemented and put
through UI review.

> Make chrome app colored frames available on ChromeOS.
> 
> This feature has been available on Windows and Mac for some time, but
> was never made available on ChromeOS.
> 
> BUG=371642
> 
> Review URL: https://codereview.chromium.org/407073002

[email protected]

Review URL: https://codereview.chromium.org/442853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287661 0039d316-1c4b-4281-b951-d872f2087c98
Revert of Fix and reenable checkbox in Polymer page set. (https://cod…
ad6bcbc 
…ereview.chromium.org/437353002/)

Reason for revert:
Fails on N5 (at least).

Unhandled exception while running http://www.polymer-project.org/components/paper-elements/demo.html#paper-checkbox

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:533
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:232
    self._RunMethod(page, self._action_name_to_run, action_runner)
  _RunMethod at tools/telemetry/telemetry/page/page_test.py:241
    run_method(action_runner)
  RunSmoothness at tools/perf/page_sets/polymer.py:124
    self.TouchEverything(action_runner)
  TouchEverything at tools/perf/page_sets/polymer.py:154
    self.DoActionOnWidgetType(action_runner, tappable_type, self.TapWidget)
  DoActionOnWidgetType at tools/perf/page_sets/polymer.py:169
    element_query + '.offsetParent != null'):
  EvaluateJavaScript at tools/telemetry/telemetry/page/actions/action_runner.py:148
    return self._tab.EvaluateJavaScript(expression)
  EvaluateJavaScript at tools/telemetry/telemetry/core/web_contents.py:108
    expr, context_id=None, timeout=timeout)
  EvaluateJavaScriptInContext at tools/telemetry/telemetry/core/web_contents.py:124
    expr, context_id=context_id, timeout=timeout)
  EvaluateJavaScript at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:176
    return self._runtime.Evaluate(expr, context_id, timeout)
  Evaluate at tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:46
    raise exceptions.EvaluateException(res['result']['result']['description'])
EvaluateException: TypeError: Cannot read property 'offsetParent' of undefined

Locals:
  context_id : None
  expr       : 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'
  request    : {'params': {'returnByValue': True, 'expression': 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'}, 'method': 'Runtime.evaluate', 'id': 173}
  res        : {u'id': 173, u'result': {u'wasThrown': True, u'exceptionDetails': {u'url': u'', u'text': u"Uncaught TypeError: Cannot read property 'offsetParent' of undefined", u'line': 1, u'column': 68}, u'result': {u'className': u'TypeError', u'type': u'object', u'description': u"TypeError: Cannot read property 'offsetParent' of undefined", u'objectId': u'{"injectedScriptId":4,"id":1}'}}}
  timeout    : 90

http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1213/steps/smoothness.polymer/logs/stdio

Original issue's description:
> Fix and reenable checkbox in Polymer page set.
> 
> BUG=394756
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287596

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=394756

Review URL: https://codereview.chromium.org/443793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287667 0039d316-1c4b-4281-b951-d872f2087c98
Updating trunk VERSION from 2115.0 to 2116.0
299974b 
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287669 0039d316-1c4b-4281-b951-d872f2087c98
Makes a window that has been resized to maximized bounds, then maximi…
8301119 
…zed and then restored shrink. This allows it to be resized easier after this sequence.

BUG=392599
TEST=ash_unittests --gtest_filter="WindowStateTest.RestoredWindowBoundsShrink"
TEST=unit_tests --gtest_filter="WindowSizerAshTest.DefaultStateBecomesMaximized"
TEST=unit_tests --gtest_filter="WindowSizerAshTest*"

Review URL: https://codereview.chromium.org/424463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287675 0039d316-1c4b-4281-b951-d872f2087c98
Enable Android lint by default
9c1da58 
BUG=393235

Review URL: https://codereview.chromium.org/396293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287676 0039d316-1c4b-4281-b951-d872f2087c98
Introduce user customization of external HighDPI mode for 4K monitor.
7badf7f 
This CL adds the options of customizing external display's device
scale factor from the options page. There are two TODOs though:
- the configured device scale factor should be stored
- not possible to specify device scale factor and resolution at the
  same time; from 1600x900, it can't enter to 1920x1080(2x). Instead
  it enters to 3840x2160, then the user needs to select 2x again.

Actually the former would solve the latter; this CL sets the new
resolution and the DSF at the same time but resolution change is
asynchronous, so changed DSF will be overwritten by the resolution
change.

I will address these issues in further CL(s).

BUG=396704
[email protected], [email protected]
[email protected]
TEST=manually

Review URL: https://codereview.chromium.org/417113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287677 0039d316-1c4b-4281-b951-d872f2087c98
Add expected files for print preview end to end testing on windows.
37a3be0 
NOTRY=true

BUG=388517

Review URL: https://codereview.chromium.org/432133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287678 0039d316-1c4b-4281-b951-d872f2087c98
mojo: terminate apps if the shell goes away
e6d2ec8 
Each application <> shell connection is represented by a ShellImpl instance
on the shell side. This CL makes the Application watch its ShellPtr for pipe
errors so it can Quit() itself if the shell goes away (shell loop destroyed).

mojo_shell_tests starts using a new method to terminate all shell connections
in this CL, and waits afterward until KeepAlive quits the loop signifying that
all apps are gone. This is done prior to destroying the shell MessageLoop so
that the test ensures apps have all died before the next test. In the future
it would be a test failure if this wasn't a no-op, but we have things in the
shell that don't quit themselves right now.

The shell itself won't wait around for apps to die (as of this CL), but
~MessageLoop will still send the message to Application sides that will quit.

** NOTE ** This does not require an app build target to explicitly add magic
*.cc files to their sources.  It requires selecting an appropriate
mojo_application_{chromium, standalone} library akin to mojo_environment_*.
We can possibly combine these two in the future.

BUG=394477

Review URL: https://codereview.chromium.org/394903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287680 0039d316-1c4b-4281-b951-d872f2087c98
Update the contextual search API to include a parameter specifying wh…
52e02aa 
…ether the server shoudl return a resolved search term.

BUG=397734,397738

Review URL: https://codereview.chromium.org/424013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287681 0039d316-1c4b-4281-b951-d872f2087c98
Web Notifications should always reappear as popups when updated.
29ed80b 
The message center already does this for notifications with a higher
priority than the notification they replace, but this makes it explicit
for Web Notifications (which cannot indicate priority).

TBR=dewittj (reviewed in cl 301713002)
BUG=366102

Review URL: https://codereview.chromium.org/439073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287682 0039d316-1c4b-4281-b951-d872f2087c98
Update chromite dependency to 41548263.
18fe977 
Needed to fix libppGoogleNaClPluginChrome.so breakage.

BUG=394497
[email protected]
[email protected], [email protected]

Review URL: https://codereview.chromium.org/445833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287683 0039d316-1c4b-4281-b951-d872f2087c98
Move avatar_menu to disable-enable flag. A future CL will set the def…
9152a54 
…ault behavior to be new_avatar_menu=enabled.

BUG=391497
[email protected] (changes are very minor and are in unit tests)

Review URL: https://codereview.chromium.org/431083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287684 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
b6dc723 
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287685 0039d316-1c4b-4281-b951-d872f2087c98
Forward along the lost_resource to layer client
92d9392 
Forward the boolean flag indicating if the resource is lost and let
canvas handle how to handle the lost resource, not simply ignore to
call mailboxReleased.

BUG=390960

Review URL: https://codereview.chromium.org/369823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287686 0039d316-1c4b-4281-b951-d872f2087c98
Pipeline: Use WeakPtr for DemuxerHost Calls and Tasks.
61949f6 
There is a chance that the Demuxer calls host_->OnDemuxerError() right
before Stop() is called. The Pipeline always posts a ErrorChangedTask() for
OnDemuxerError() with base::Retained(this).

After the Demuxer fires the stop callback, the Pipeline could be destroyed
immediately. So If the media thread hasn't been destroyed we could end up with
running ErrorChangedTask() on null pipeline which causes a crash.

This CL uses a weak pointer for DemuxerHost calls so that no task will run
after the pipeline is destroyed.

BUG=397656, 399417, 365141
TEST=Updated unit tests to cover this case.
[email protected]

Review URL: https://codereview.chromium.org/423073012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287687 0039d316-1c4b-4281-b951-d872f2087c98
cc: Remove vectors from tiling eviction tile iterator.
e03dc01 
This patch removes vectors from the eviction tile
iterator at the layer level. It reworks the code
a bit to use the underlying layer's tilings
directly using indecies and ranges, instead of
constructing a separate vector to hold the
values.

As well, this ensures that the iterators
are only created when they are visited.


R=reveman

Review URL: https://codereview.chromium.org/428533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287688 0039d316-1c4b-4281-b951-d872f2087c98
Add integration browser tests for settings hardening.
589fdd6 
This CL introduces the PrefHashBrowserTestBase fixture which these tests are based on.

This fixture (in conjunction with the new PREF_HASH_BROWSER_TEST macro) provides an easy way to override 3 methods in order to:
 1) Setup Chrome as desired in a PRE_ test.
 2) Attack Preferences while Chrome isn't running.
 3) Relaunch Chrome and verify reaction to attacks.

The fixture+macro also parametrizes every test such that they are ran in every SettingsEnforcement trial group.

A few pieces were resurrected from the old PrefHashBrowserTest used to test unloaded profile seeding prior to http://crrev.com/277209

Review URL: https://codereview.chromium.org/431973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287689 0039d316-1c4b-4281-b951-d872f2087c98
Reenable trace_event_unittest for windows
dee9392 
BUG=396403

Review URL: https://codereview.chromium.org/432473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287690 0039d316-1c4b-4281-b951-d872f2087c98
Don't activate minimized/bottom home card
8b9c0cf 
Home Card will be minimized when an activity is activated, so don't re-activate home card. There is also no need to activate bottom home card, so activate the centered home card only.

BUG=400575

Review URL: https://codereview.chromium.org/435293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287691 0039d316-1c4b-4281-b951-d872f2087c98
Add a browser test for functions in notification provider API
9a9a669 
Add a basic browser test for functions in notification provider API.
This is mainly to test the connection and provide a skeleton for future
tests. The functions are not fully implemented yet, and more tests will
be added as the functions are implemented.

BUG=

Review URL: https://codereview.chromium.org/416423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287692 0039d316-1c4b-4281-b951-d872f2087c98
cc: Make sure mask and replica layers get DidBecomeActive signal.
db2e29c 
Since we create and rasterize mask and replica layer tiles as well,
we need to ensure that they get the DidBecomeActive signal in order
to ensure the tile priorities of the contained tiles are correct.
(DidBecomeActive switches active and pending priorities and clears
the pending priority). Without this, there are cases where the pending
priority can remain high without any mechanism clearing it.

BUG=400560
R=enne

Review URL: https://codereview.chromium.org/441863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287693 0039d316-1c4b-4281-b951-d872f2087c98
Fix inverted early return check in variations simulation code.
2940ea7 
BUG=394855

Review URL: https://codereview.chromium.org/438163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287694 0039d316-1c4b-4281-b951-d872f2087c98
Add function to register a synthetic trial with the trial hash.
bb5d189 
This will be used by Android Chrome to register external
experiments.

BUG=400357

Review URL: https://codereview.chromium.org/440693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287695 0039d316-1c4b-4281-b951-d872f2087c98
Roll tools/swarming_client/ to bbf1fcca7932d92cca9d7dab46ea271a7f6d61fb.
8406747 
$ git log 9755ed384..bbf1fcca7 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-08-05 maruel Improve the load test script.
2014-08-04 maruel Fix a secondary exception when an error occurs to delete a directory.
2014-08-01 maruel Save client json data on the fly as the load test is on-going.

[email protected]
BUG=

Review URL: https://codereview.chromium.org/442063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287696 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
5b0baa7 
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287697 0039d316-1c4b-4281-b951-d872f2087c98
Randomly select a single rappor sample when more than one is collected.
e179e7d 
BUG=400553

Review URL: https://codereview.chromium.org/419683014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287698 0039d316-1c4b-4281-b951-d872f2087c98
Stop setting AcceleratedCompositingForVideoEnabled in LayoutTests.
f9c5517 
This removes the setting entirely since it's always true in production.
Once we stop setting it, we can remove it from blink.

BUG=365857

Review URL: https://codereview.chromium.org/443573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287699 0039d316-1c4b-4281-b951-d872f2087c98
Move construction of flow_controller_ to QuicSession constructor to a…
3ea5a0d 
…void streams being initialized with a NULL ptr.

BUG=

Review URL: https://codereview.chromium.org/442943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287700 0039d316-1c4b-4281-b951-d872f2087c98
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@nico
Revert of Revert of Fix maximize on some window managers (patchset #1 …
8c59383 
…id:1 of https://codereview.chromium.org/554843002/)

Reason for revert:
I unchecked cq, not sure why this revert was landed. (I want to revert https://codereview.chromium.org/469993003/ instead)

Original issue's description:
> Revert of Fix maximize on some window managers (patchset #1 id:1 of https://codereview.chromium.org/543663003/)
>
> Reason for revert:
> Speculative, to see if it helps with
>
> ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value
>     #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164
>     #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259
>     #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420
>     #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358
>     #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231
>     crosswalk-project#5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672
>     crosswalk-project#6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46
>     crosswalk-project#7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14
>     crosswalk-project#8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281
>     crosswalk-project#9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296
>     crosswalk-project#10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452
>     crosswalk-project#11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392
>     crosswalk-project#12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309
>     crosswalk-project#13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342
>     crosswalk-project#14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526
>     crosswalk-project#15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894
>
> Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ (see http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ for symbols), and this looks tangentially related (it touched the file the uninitialized read is in.)
>
> Line 1164 is
>
>   if (params.visible_on_all_workspaces) {
>     state_atom_list.push_back(atom_cache_.GetAtom("_NET_WM_STATE_STICKY"));
>     ui::SetIntProperty(xwindow_, "_NET_WM_DESKTOP", "CARDINAL", kAllDesktops);
>   }
>
> https://chromium.googlesource.com/chromium/src/+blame/master/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
>
> Original issue's description:
> > Fix maximize on some window managers
> >
> > On some window managers the Maximize hints are not respected when they
> > are set on an unmapped window. There was an existing workaround for this
> > in the code, but the workaround failed whenever ShowWindowWithState
> > didn't happen to be called with the parameters needed to activate the
> > workaround. This meant that if a window was first made visible and later
> > activated, it would not get maximized at all.
> >
> > This fix saves whether the maximize hints need to be sent to the window,
> > and makes sure it gets done after mapping the window.
> >
> > BUG=
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/334fca491b7e798d75e76a56c57074d3187602be
>
> [email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/013b6d4051e8e2c8960faa12b92e273925aaee5b

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/551123002

Cr-Commit-Position: refs/heads/master@{#293790}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@nico
Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview…
7543ca1 
….chromium.org/469993003)

Speculative, to see if it helps with

==12563== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164
    #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259
    #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420
    #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358
    #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231
    crosswalk-project#5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672
    crosswalk-project#6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46
    crosswalk-project#7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14
    crosswalk-project#8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281
    crosswalk-project#9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 crosswalk-project#10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452
    crosswalk-project#11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392
    crosswalk-project#12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309
    crosswalk-project#13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342
    crosswalk-project#14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526
    crosswalk-project#15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894

Started happening here
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/98
(see stdio for symbols), and this looks like the only change in that
build.

This reverts commit c76ef73.

BUG=384644
[email protected]

Review URL: https://codereview.chromium.org/550413002

Cr-Commit-Position: refs/heads/master@{#293792}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Fix test for master device. (patchset #4 id:80001 of https:…
3623520 
…//codereview.chromium.org/538143002/)

Reason for revert:
Breaks key repeat (issue 412655).

Original issue's description:
> Fix test for master device.
>
> BUG=406014
> [email protected]
>
> Committed: https://crrev.com/817ca9b5c2145d843f6ff154926db79535974778
> Cr-Commit-Position: refs/heads/master@{#293781}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=406014

Review URL: https://codereview.chromium.org/560853003

Cr-Commit-Position: refs/heads/master@{#294174}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@erikchen
Revert of Mac: Fix rounded corners on browser windows on retina displ…
4e8a292 
…ay. (patchset #4 id:80001 of https://codereview.chromium.org/463263002/)

Reason for revert:
When the download bar is present, the rounded corners are on the wrong view.

https://code.google.com/p/chromium/issues/detail?id=412580

Original issue's description:
> Mac: Fix rounded corners on browser windows on retina display.
>
> When a window's bottom corner is covered by a layer on a retina display, the
> corner is incorrectly rounded. I added a layer mask to do the corner rounding
> ourselves.
>
> BUG=396264
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289811

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=396264

Review URL: https://codereview.chromium.org/560913004

Cr-Commit-Position: refs/heads/master@{#294265}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Force calling PostDisplayConfigurationChange() even if eary…
7f7b757 
…ling out in UpdateDisplays (patchset #4 id:60001 of https://codereview.chromium.org/559213002/)

Reason for revert:
I am reverting this as it resulted in test VirtualKeyboardUsabilityExperimentTest.VirtualKeyboardWindowTest consistently crashing on Linux ChromiumOS Tests, see:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31731
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/2914

Stack trace:

Objects involved in the operation:
sequence "this" @ 0x0x3e568fbdcc90 {
}
Received signal 6
#0 0x7fcb9c8936fe base::debug::StackTrace::StackTrace()
#1 0x7fcb9c893230 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fcb8c474cb0 \u003Cunknown>
#3 0x7fcb8bbc4425 gsignal
#4 0x7fcb8bbc7b8b abort
crosswalk-project#5 0x7fcb8c1c75ad __gnu_debug::_Error_formatter::_M_error()
crosswalk-project#6 0x7fcb9a306513 std::__debug::vector\u003C>::operator[]()
crosswalk-project#7 0x7fcb9a2fbba9 ash::DisplayManager::GetCurrentDisplayIdPair()
crosswalk-project#8 0x7fcb9a2d96cf ash::DisplayController::PostDisplayConfigurationChange()
crosswalk-project#9 0x7fcb9a2d98bc ash::DisplayController::PostDisplayConfigurationChange()
crosswalk-project#10 0x7fcb9a2fd22a ash::DisplayManager::UpdateDisplays()
crosswalk-project#11 0x7fcb9a2fdbe8 ash::DisplayManager::SetDisplayRotation()
crosswalk-project#12 0x7fcb9a33425b ash::VirtualKeyboardWindowController::FlipDisplay()
crosswalk-project#13 0x7fcb9a3340d7 ash::VirtualKeyboardWindowController::UpdateWindow()
crosswalk-project#14 0x7fcb9a2d92df ash::DisplayController::CreateOrUpdateNonDesktopDisplay()
crosswalk-project#15 0x7fcb9a2d937f ash::DisplayController::CreateOrUpdateNonDesktopDisplay()
crosswalk-project#16 0x7fcb9a300ea9 ash::(anonymous namespace)::NonDesktopDisplayUpdater::~NonDesktopDisplayUpdater()
crosswalk-project#17 0x7fcb9a300df1 ash::DisplayManager::CreateMirrorWindowIfAny()

Original issue's description:
> Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays
>
> When changing from software mirroring mode to sinlge display mode, it
> is possible there is no need to update |displays_| and we early out
> UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange()
> cause there are some clients need to act on this, e.g.
> TouchTransformerController needs to adjust the TouchTransformer when
> switching from dual displays to single display.
>
> BUG=chrome-os-partner:31868
> TEST=tested on Big, after existing software mirroring mode, the touch location
>      transformation is still correct.
>
> Committed: https://crrev.com/4802a8552a40e1f80606ca7171dc2f79930e7fb3
> Cr-Commit-Position: refs/heads/master@{#294481}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:31868

Review URL: https://codereview.chromium.org/569553002

Cr-Commit-Position: refs/heads/master@{#294553}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@naskooskov
Revert of Non-plafrom-specific part of an OwnerSettingsService is mov…
1d9925f 
…ed to components/ownership/*. (patchset #4 id:60001 of https://codereview.chromium.org/548323003/)

Reason for revert:
Breaks compile on multiple bots:

http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/3134
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/73424
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Win%20Builder%20%28dbg%29/builds/13365

Original issue's description:
> Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*.
>
> BUG=398856
> TEST=existing browser_tests and unit_tests
> [email protected], [email protected], [email protected], [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=398856

Review URL: https://codereview.chromium.org/565293003

Cr-Commit-Position: refs/heads/master@{#294618}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Convert device::UsbConfigDescriptor and friends to structs.…
f499548 
… (patchset #2 id:60001 of https://codereview.chromium.org/562763002/)

Reason for revert:
This broken the Linux ASan LSan Tests:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7506
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5717

Sample callstacks:

Direct leak of 400 byte(s) in 10 object(s) allocated from:
    #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x55c6eb)
    #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45
    #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7
    #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9
    #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42
    crosswalk-project#5 0xb38aebf in Run base/bind_internal.h:288:12
    crosswalk-project#6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927
    crosswalk-project#7 0x2d58bff in Run base/callback.h:401:12
    crosswalk-project#8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
    crosswalk-project#9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
    crosswalk-project#10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
    crosswalk-project#11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
    crosswalk-project#12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
    crosswalk-project#13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3
    crosswalk-project#14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
    crosswalk-project#15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3
    crosswalk-project#16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14
    crosswalk-project#17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
    crosswalk-project#18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
    crosswalk-project#19 0x7f4d560a3e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Direct leak of 400 byte(s) in 10 object(s) allocated from:
    #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/browser_tests+0x55c6eb)
    #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45
    #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7
    #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9
    #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42
    crosswalk-project#5 0xb38aebf in Run base/bind_internal.h:288:12
    crosswalk-project#6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927
    crosswalk-project#7 0x2d58bff in Run base/callback.h:401:12
    crosswalk-project#8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
    crosswalk-project#9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
    crosswalk-project#10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
    crosswalk-project#11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
    crosswalk-project#12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
    crosswalk-project#13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3
    crosswalk-project#14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
    crosswalk-project#15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3
    crosswalk-project#16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14
    crosswalk-project#17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
    crosswalk-project#18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
    crosswalk-project#19 0x7f4aef980e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Original issue's description:
> Convert device::UsbConfigDescriptor and friends to structs.
>
> These classes do not need to be classes and expecially don't need to be
> abstract classes as this leads to a complicated implementation and
> complicated tests. All USB devices no matter the platform will have the
> same descriptor data.
>
> This change follows the model of device::HidDeviceInfo.
>
> BUG=
>
> Committed: https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5
> Cr-Commit-Position: refs/heads/master@{#294594}

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/567003002

Cr-Commit-Position: refs/heads/master@{#294640}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@nhiroki
Revert of Clean up GestureEventDetails constructors (patchset #4 id:1…
bedd695 
…00001 of https://codereview.chromium.org/565583005/)

Reason for revert:
This seems to fail the following tests in "athena_unittests" on "Linux ChromiumOS Tests (dbg)(3)"

- HomeCardGestureManagerTest.Basic
- HomeCardGestureManagerTest.StartCentered

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36778

Original issue's description:
> Clean up GestureEventDetails' constructors.
>
> In one of the GestureEventDetails' constructors, the arguments
> delta_x, delta_y sometime are not used, so we should make a new
> constructor which only takes one argument EventType.
>
> BUG=350942
>
> Committed: https://crrev.com/b5e408e7bffd3d1e6b60612f65c0538a90329c59
> Cr-Commit-Position: refs/heads/master@{#294760}

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=350942

Review URL: https://codereview.chromium.org/572593002

Cr-Commit-Position: refs/heads/master@{#294776}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@dj2
Revert of Telemetry: Fix exact_matches in telemetry.test_runner. (pat…
0994ab5 
…chset #4 id:60001 of https://codereview.chromium.org/560153004/)

Reason for revert:
Can't find the webrtc tests.

http://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf%20%281%29/builds/2649

Original issue's description:
> Telemetry: Fix exact_matches in telemetry.test_runner.
>
> Previously, if exact_matches was True but there were no exact matches,
> it would return fuzzy matches instead. This is not what the caller asked
> for.
>
> GPU test names are changed to match the buildbot config, since they were
> previously relying on fuzzy matching.
>
> SHERIFFS: May cause errors like:
>
>   No test named "some_test_name".
>
>   Available tests are:
>     ...
>
> If so, this CL can be safely reverted.
>
> BUG=413334,413442
>
> Committed: https://crrev.com/566ed9f6e71cea313c88e8f259eca76581b72d67
> Cr-Commit-Position: refs/heads/master@{#294757}

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=413334,413442

Review URL: https://codereview.chromium.org/555703005

Cr-Commit-Position: refs/heads/master@{#294812}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of [Android] Mark posted UI thread tasks as asynchronous (patc…
1dcbab8 
…hset #4 id:60001 of https://codereview.chromium.org/512333002/)

Reason for revert:
This patch was purely experimental, and the experiment has expired.

Original issue's description:
> [Android] Mark posted UI thread tasks as asynchronous
>
> Chromium shares a message loop with Android on the browser UI thread.
> This can cause problems when the associated Looper has a sync barrier,
> preventing posted Chromium tasks from being dispatched until the
> barrier is removed. Make this sharing more fair by marking all Chromium
> Message tasks as asynchronous, avoiding stalls when there is a sync
> barrier.
>
> Note: This change is for gathering data about the perf impact and we'll
> revert it before cutting a release branch.
>
> BUG=407149,380781,407133
>
> Committed: https://crrev.com/feabeebb3ac5810f896ac8303a77ee695acaf9d4
> Cr-Commit-Position: refs/heads/master@{#292551}

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=407149,380781,407133

Review URL: https://codereview.chromium.org/564373005

Cr-Commit-Position: refs/heads/master@{#294875}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@yoshikig
Revert of Files.app: Split background.js (patchset #4 id:60001 of htt…
326fdba 
…ps://codereview.chromium.org/562103002/)

Reason for revert:
This patch breaks the test.

Original issue's description:
> Files.app: Split background.js
>
> This patch splits the background.js into the 3 files (background_base.js, app_window_wrapper.js, background.js), extracting the common classes.
>
> This patch itself doesn't change any functionality, but the extracted files will be used in the separated audio player app in near future.
>
> BUG=375039
> TEST=browser_test passes
>
> Committed: https://crrev.com/479878c12c436c0bec667483df29fe1f23b710a2
> Cr-Commit-Position: refs/heads/master@{#294998}

[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=375039

Review URL: https://codereview.chromium.org/563743004

Cr-Commit-Position: refs/heads/master@{#295019}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@danbeam
Revert of Clean up GestureEventDetails constructors and fix unit test…
8c2ece8 
…s (patchset #3 id:60001 of https://codereview.chromium.org/573963005/)

Reason for revert:
this may have broken wm_unittests on XP Tests (3):
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(3)/builds/28989

WindowAnimationsTest.HideAnimationDetachLayers (run #1):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B9D8 vs 0017B9D8
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (141 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #2):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slaveWindowAnimationsTest.HideAnimationDetachLayers (run #1):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B9D8 vs 0017B9D8
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (141 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #2):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (94 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #3):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #4):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms)\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (94 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #3):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #4):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms)

Original issue's description:
> Clean up GestureEventDetails constructors and fix unit tests.
>
> A new version of Issue 565583005: Clean up GestureEventDetails
> constructors
> https://codereview.chromium.org/565583005/
>
> BUG=350942
>
> [email protected], [email protected], [email protected]
>
> Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5
> Cr-Commit-Position: refs/heads/master@{#295144}
>
> Committed: https://crrev.com/66e0c057b87824c6e6928f359fa56a8ee45ae6e2
> Cr-Commit-Position: refs/heads/master@{#295296}
>
> Committed: https://crrev.com/9ec877c2d256a538b1c9af2fbed736aad8406e66
> Cr-Commit-Position: refs/heads/master@{#295329}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=350942

Review URL: https://codereview.chromium.org/580973002

Cr-Commit-Position: refs/heads/master@{#295353}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@danbeam
Revert of Add GCMChannelStatusSyncer to schedule requests and enable/…
c5fd179 
…disable GCM (patchset crosswalk-project#8 id:150001 of https://codereview.chromium.org/561943002/)

Reason for revert:
this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup.  here's an example:

[15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by:
[15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace()
#1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker()
#2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter()
#3 0x000000df57f1 IOThread::InitSystemRequestContext()
#4 0x000000df570b IOThread::system_url_request_context_getter()
crosswalk-project#5 0x000001443d9e BrowserProcessImpl::system_request_context()
crosswalk-project#6 0x000001028a8e SafeBrowsingService::Initialize()
crosswalk-project#7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService()
crosswalk-project#8 0x000001446196 BrowserProcessImpl::safe_browsing_service()
crosswalk-project#9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate()
crosswalk-project#10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated()
crosswalk-project#11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated()
crosswalk-project#12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl()
crosswalk-project#13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted()
crosswalk-project#14 0x7f44be068302 base::internal::RunnableAdapter<>::Run()
crosswalk-project#15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo()
crosswalk-project#16 0x7f44be06821a base::internal::Invoker<>::Run()
crosswalk-project#17 0x7f44be54e46e base::Callback<>::Run()
crosswalk-project#18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow()
crosswalk-project#19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks()
crosswalk-project#20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize()
crosswalk-project#21 0x7f44be05c7df content::BrowserMain()
crosswalk-project#22 0x7f44bdee5f6f content::RunNamedProcessTypeMain()
crosswalk-project#23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run()
crosswalk-project#24 0x7f44bdee5505 content::ContentMain()
crosswalk-project#25 0x0000041aa8cb content::BrowserTestBase::SetUp()
crosswalk-project#26 0x00000173e117 InProcessBrowserTest::SetUp()
crosswalk-project#27 0x000000671180 ExtensionBrowserTest::SetUp()
crosswalk-project#28 0x0000006711b2 ExtensionBrowserTest::SetUp()
crosswalk-project#29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
crosswalk-project#30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>()
crosswalk-project#31 0x0000017dd1e3 testing::Test::Run()
crosswalk-project#32 0x0000017dd92b testing::TestInfo::Run()
crosswalk-project#33 0x0000017ddf1a testing::TestCase::Run()
crosswalk-project#34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests()
crosswalk-project#35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
crosswalk-project#36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>()
crosswalk-project#37 0x0000017e30b1 testing::UnitTest::Run()
crosswalk-project#38 0x000004187e41 RUN_ALL_TESTS()
crosswalk-project#39 0x000004186e67 base::TestSuite::Run()
crosswalk-project#40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite()
crosswalk-project#41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite()
crosswalk-project#42 0x0000041bc2fb content::LaunchTests()
crosswalk-project#43 0x00000173c6e9 LaunchChromeTests()
crosswalk-project#44 0x0000007fccbf main
crosswalk-project#45 0x7f44ad8ed76d __libc_start_main
crosswalk-project#46 0x000000601389 <unknown>

[15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1)
#0 0x7f44b584025e base::debug::StackTrace::StackTrace()
#1 0x7f44b58d7a62 logging::LogMessage::~LogMessage()
#2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks()
#3 0x000000df8e13 IOThread::CleanUp()
#4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp()
crosswalk-project#5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp()
crosswalk-project#6 0x7f44b59d0601 base::Thread::ThreadMain()
crosswalk-project#7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc()
crosswalk-project#8 0x7f44b1aa9e9a start_thread
crosswalk-project#9 0x7f44ad9c03fd clone

Original issue's description:
> Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM
>
> BUG=384041
> TEST=new tests added
>
> Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63
> Cr-Commit-Position: refs/heads/master@{#295524}

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=384041

Review URL: https://codereview.chromium.org/582913003

Cr-Commit-Position: refs/heads/master@{#295549}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@leizleiz
Revert of Cleanup: Remove remaining generated extensions APIs on Andr…
b2454bd 
…oid. (patchset #4 id:60001 of https://codereview.chromium.org/573933002/)

Reason for revert:
Android bot fails with error: gen/extensions/common/api/generated_schemas.cc: No such file or directory

Original issue's description:
> Cleanup: Remove remaining generated extensions APIs on Android.
>
> BUG=305852
>
> Committed: https://crrev.com/379f0be47f454cce5c912f25d1b3302ba679b472
> Cr-Commit-Position: refs/heads/master@{#295669}

[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=305852

Review URL: https://codereview.chromium.org/582933003

Cr-Commit-Position: refs/heads/master@{#295670}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Remove void** from disk_cache interface. (patchset crosswal…
a3b7558 
…k-project#30 id:650001 of https://codereview.chromium.org/542733002/)

Reason for revert:
Introduced memory leaks on linux asan
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892:
Direct leak of 80 byte(s) in 2 object(s) allocated from:
#0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
#1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5
#2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
#3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
#4 0x2e3b0bf in Run base/callback.h:401:12
crosswalk-project#5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
crosswalk-project#6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
crosswalk-project#7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
crosswalk-project#8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
crosswalk-project#9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
crosswalk-project#10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
crosswalk-project#11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
crosswalk-project#12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
crosswalk-project#13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
crosswalk-project#14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Indirect leak of 64 byte(s) in 2 object(s) allocated from:
#0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
#1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5
#2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36
#3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11
#4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
crosswalk-project#5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
crosswalk-project#6 0x2e3b0bf in Run base/callback.h:401:12
crosswalk-project#7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
crosswalk-project#8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
crosswalk-project#9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
crosswalk-project#10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
crosswalk-project#11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
crosswalk-project#12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
crosswalk-project#13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
crosswalk-project#14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
crosswalk-project#15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
crosswalk-project#16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Indirect leak of 36 byte(s) in 1 object(s) allocated from:
#0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
#1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5
#2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121
#3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8
#4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8
crosswalk-project#5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36
crosswalk-project#6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11
crosswalk-project#7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
crosswalk-project#8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
crosswalk-project#9 0x2e3b0bf in Run base/callback.h:401:12
crosswalk-project#10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
crosswalk-project#11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
crosswalk-project#12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
crosswalk-project#13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
crosswalk-project#14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
crosswalk-project#15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
crosswalk-project#16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
crosswalk-project#17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
crosswalk-project#18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
crosswalk-project#19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Original issue's description:
> Remove void** from disk_cache interface.
>
> Enumeration and iteration were passing around void**. With this CL, we
> instead use an Iterator object.
>
> [email protected],[email protected],[email protected]
> BUG=413644
>
> Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342
> Cr-Commit-Position: refs/heads/master@{#295659}

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=413644

Review URL: https://codereview.chromium.org/585833002

Cr-Commit-Position: refs/heads/master@{#295677}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Roll src/third_party/WebKit 0f6e289:a63b92e (svn 182407:182…
7dcc80f 
…410) (patchset #1 id:1 of https://codereview.chromium.org/590143002/)

Reason for revert:
Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)"
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio

==30366==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 34 byte(s) in 1 object(s) allocated from:
#0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b)
#1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20
#2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554
#3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299
#4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418
crosswalk-project#5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16
crosswalk-project#6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67
crosswalk-project#7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91
crosswalk-project#8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16
crosswalk-project#9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36
crosswalk-project#10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1
crosswalk-project#11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486
crosswalk-project#12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12
crosswalk-project#13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601
crosswalk-project#14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
crosswalk-project#15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
crosswalk-project#16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
crosswalk-project#17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
crosswalk-project#18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
crosswalk-project#19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226
crosswalk-project#20 0x2ea717b in Run base/callback.h:401:12
crosswalk-project#21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498
crosswalk-project#22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10
crosswalk-project#23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10
crosswalk-project#24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

Original issue's description:
> Roll src/third_party/WebKit 0f6e289:a63b92e (svn 182407:182410)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/0f6e289..a63b92e
>
> [email protected],[email protected],[email protected]
>
> Committed: https://crrev.com/09e1192db2fc7c5295eb373626b77945ca10aee3
> Cr-Commit-Position: refs/heads/master@{#295959}

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/593693004

Cr-Commit-Position: refs/heads/master@{#295961}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182…
7cad352 
…407) (patchset #1 id:1 of https://codereview.chromium.org/588163003/)

Reason for revert:
Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)"
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio

==30366==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 34 byte(s) in 1 object(s) allocated from:
#0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b)
#1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20
#2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554
#3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299
#4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418
crosswalk-project#5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16
crosswalk-project#6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67
crosswalk-project#7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91
crosswalk-project#8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16
crosswalk-project#9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36
crosswalk-project#10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1
crosswalk-project#11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486
crosswalk-project#12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12
crosswalk-project#13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601
crosswalk-project#14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
crosswalk-project#15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
crosswalk-project#16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
crosswalk-project#17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
crosswalk-project#18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
crosswalk-project#19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226
crosswalk-project#20 0x2ea717b in Run base/callback.h:401:12
crosswalk-project#21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498
crosswalk-project#22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10
crosswalk-project#23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10
crosswalk-project#24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

Original issue's description:
> Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289
>
> [email protected],[email protected],[email protected]
>
> Committed: https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede
> Cr-Commit-Position: refs/heads/master@{#295950}

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/592783002

Cr-Commit-Position: refs/heads/master@{#295962}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Swarming configuration files for chromoting integration tes…
b2c1542 
…ts (patchset #4 id:60001 of https://codereview.chromium.org/498373003/)

Reason for revert:
This is slowing down the trybots because it's uploading these files even though they're not used on trybots. look at how gpu isolates that are only used on the GPU builders are handled (there's a gyp variable which is only set by the builders which run these tests)

Original issue's description:
> Swarming configuration files for chromoting integration tests.
>
> BUG=
>
> Committed: https://crrev.com/d90ba4c4e4ddf5c4cbb6cf812c9571d628e30567
> Cr-Commit-Position: refs/heads/master@{#292785}

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/591163002

Cr-Commit-Position: refs/heads/master@{#295980}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of Enable ASan default options on Mac. (patchset #4 id:60001 of …
5ed6fe0 
…https://codereview.chromium.org/581983003/)

Reason for revert:
This CL broke ui_unittests on both Mac ASan and Mac ASan 64 bots:

/Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests --brave-new-test-launcher --test-launcher-bot-mode --verbose --test-launcher-print-test-stdio=always --gtest_print_time --test-launcher-summary-output=/tmp/tmpnPVxX8
dyld: Library not loaded: @executable_path/../Versions/1.0.0.0/ui_unittests Framework.framework/ui_unittests Framework
  Referenced from: /Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests
  Reason: image not found

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%282%29/builds/5393/steps/ui_unittests/logs/stdio

Original issue's description:
> Enable ASan default options on Mac.
>
> This CL links libsanitizer_options into every executable built with ASan on OSX.
> The existing implementation of __asan_default_options for Chromium.app is merged with that in sanitizer_options.cc
>
> Also now use_sanitizer_options is only set when building with sanitizers so that there isn't an unconditional dependency on an empty object file in every executable in non-sanitizer builds.
>
> BUG=302040
> [email protected]
>
> Committed: https://crrev.com/0640a5d19ef72aec62787423e8a7c78c4f62b955
> Cr-Commit-Position: refs/heads/master@{#295958}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=302040

Review URL: https://codereview.chromium.org/593683004

Cr-Commit-Position: refs/heads/master@{#295987}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@vitalybuka
Revert of Temporary allocation of 20Mb before and after call to Servi…
5e272f8 
…ceProcessControl::GetHistograms. (patchset #4 id:60001 of https://codereview.chromium.org/510563004/)

Reason for revert:
We have gathered enough evidence.

Original issue's description:
> Temporary allocation of 20Mb before and after call to ServiceProcessControl::GetHistograms.
>
> BUG=406227
>
> Committed: https://crrev.com/f89ce26c97949d224441ed45644a7d41b89bcf69
> Cr-Commit-Position: refs/heads/master@{#292325}

[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=406227

Review URL: https://codereview.chromium.org/595673003

Cr-Commit-Position: refs/heads/master@{#296095}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
@madsager
Revert of EventSender: Added checks for missing arguments (patchset #4 …
f70f5fb 
…id:60001 of https://codereview.chromium.org/584203003/)

Reason for revert:
This makes the fast/events/hit-test-counts.html layout test fail. Reverting for now.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fhit-test-counts.html&testType=layout-tests

Original issue's description:
> Added checks for missing arguments in event_sender.cc. Also simplified the uses of x & y in EventSender::GestureEvent.
>
> BUG=415970
>
> Committed: https://crrev.com/302907463636d2ddfe25c5381bd1f2b64016d1c6
> Cr-Commit-Position: refs/heads/master@{#296256}

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=415970

Review URL: https://codereview.chromium.org/600733002

Cr-Commit-Position: refs/heads/master@{#296357}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Revert of PPAPI: Never re-enter JavaScript for PostMessage. (patchset #4
50c6f1a 
 id:60001 of https://codereview.chromium.org/589213003/)

Reason for revert:
May be crashing Chrome:
https://code.google.com/p/chromium/issues/detail?id=417511

Original issue's description:
> PPAPI: Never re-enter JavaScript for PostMessage.
>
> Blocking renderer->plugin messages can be interrupted by any message
> from the plugin->renderer (even async ones). So while handline a blocking
> message, such as HandleInputEvent or HandleBlockingMessage, it's currently
> possible to re-enter JavaScript. This patch makes that impossible by
> queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
> while any renderer->plugin sync message is on the stack.
>
> BUG=384528
>
> Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
> Cr-Commit-Position: refs/heads/master@{#296311}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=384528

Review URL: https://codereview.chromium.org/601923003

Cr-Commit-Position: refs/heads/master@{#296571}
huningxin pushed a commit that referenced this pull request Nov 28, 2014
Disable the scoped handle verifier (and close hook) for M-39
c8d8751 
To be merged on 2171.

BUG=418816
[email protected]
[email protected]

Review URL: https://codereview.chromium.org/616713002

Cr-Commit-Position: refs/heads/master@{#297319}
(cherry picked from commit 20d9928)

Review URL: https://codereview.chromium.org/618543002

Cr-Commit-Position: refs/branch-heads/2171@{#4}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
huningxin pushed a commit that referenced this pull request Jan 27, 2015
Revert "Merge 663413002 to M39:"
e5e683b 
This reverts commit 255ee24.

[email protected]

 Revert of  Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #4 id:60001 of https://codereview.chromium.org/663413002/)

Reason for revert:
This CL broke the configuration of AudioProcessing, we have to revert it to fix the echo issues it introduces.

Original issue's description:
> Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> The original review thread is in https://codereview.chromium.org/588523002/
>
> Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> [email protected],[email protected]
>
> BUG=415935
> TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.

Review URL: https://codereview.chromium.org/730563002

(cherry picked from commit e78feb7)

Cr-Original-Commit-Position: refs/branch-heads/2171@{#419}
Cr-Original-Branched-From: 267aeeb-refs/heads/master@{#297060}
Cr-Commit-Position: refs/branch-heads/2171_62@{#2}
Cr-Branched-From: 6ac5b3b-refs/branch-heads/2171@{#415}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
huningxin pushed a commit that referenced this pull request Jan 27, 2015
Incrementing VERSION to 39.0.2171.65
df9a677 
Cr-Commit-Position: refs/branch-heads/2171_62@{#4}
Cr-Branched-From: 6ac5b3b-refs/branch-heads/2171@{#415}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
huningxin pushed a commit that referenced this pull request Dec 10, 2015
Incrementing VERSION to 44.0.2403.3
ad8960e 
Cr-Commit-Position: refs/branch-heads/2403@{#4}
Cr-Branched-From: f54b809-refs/heads/master@{#330231}
huningxin pushed a commit that referenced this pull request Dec 10, 2015
Fix the System Profile to not load extensions. It could otherwise be …
a515307 
…forced to by GPO.

A few releases ago I introduced a System Profile to back the User Manager (https://codereview.chromium.org/847733005). This profile, however, is causing some problems. I'm trying to reduce those by making clearer the contract of what it's for: A profile that doesn't take a browser window, has no extensions, writes little to disk, etc.

This certainly addresses issue #4 raised within the bug, and address the other issues as well (I can't repro them). This CL generally hardens Chrome for the System Profile in a lot of the same ways we do the Guest Profile.

BUG=482176
[email protected]

Review URL: https://codereview.chromium.org/1129293002

Cr-Commit-Position: refs/heads/master@{#331276}
(cherry picked from commit 7831f57)

Review URL: https://codereview.chromium.org/1157273006

Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#116}
Cr-Branched-From: f54b809-refs/heads/master@{#330231}
huningxin pushed a commit that referenced this pull request May 17, 2016
Check if asyncparams is null for document mode UI initialization
6eff6f8 
The if statement checks for the tabtobereparented to be null
without checking the params itself.

BUG=590637

Review URL: https://codereview.chromium.org/1746933002

(cherry picked from commit 12b7f87)

Cr-Original-Commit-Position: refs/heads/master@{#378249}
Cr-Commit-Position: refs/branch-heads/2661@{#4}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit that referenced this pull request May 17, 2016
@mikewest
Revert of Evict non-secure cookies less agressively. (patchset #4 id:…
4da5cad 
…60001 of https://codereview.chromium.org/1705753002/ )

Reason for revert:
Let's see if the automagical reversion thingie will work on a ~2 week old patch.

```
I updated the eviction algorithm with our initial pass at a merger between leave-secure-cookies-along and cookie-priorities, and neglected to ensure that that new algorithm was safely locked up behind the "strict secure cookies" experiment. That patch is in M50.

I think the right thing to do is to revert https://codereview.chromium.org/1705753002 on the M50 branch so that we retain the status quo behavior for beta. That means that we're going to have to wait a bit longer to start ratcheting down on cookies, which is unfortunate, but the safe choice this late in the game.
```

BUG=591720

Original issue's description:
> Evict non-secure cookies less agressively.
>
> The current implementation of strict-secure cookies wipes all non-secure
> cookies when an origin exceeds ~180. This is a bit agressive, and has
> real impact on users.
>
> This patch softens that to remove only the number of non-secure cookies
> necessary to get under the ~150 cap. If a user has 150 secure cookies,
> we'll still wipe all non-secure cookies, but that seems less likely to
> impact users than the current behavior.
>
> The patch is a bit more complicated than I expected due to interactions
> with the Chrome-only "priority" feature we shipped back in 2013. In
> short, we execute priority-driven removal of non-secure cookies first,
> and only touch secure cookies if necessary.
>
> BUG=581588
> [email protected], [email protected]
>
> Committed: https://crrev.com/162d27135f2ee44ae01341de055d1b827a930767
> Cr-Commit-Position: refs/heads/master@{#376204}

[email protected],[email protected]
BUG=581588

Review URL: https://codereview.chromium.org/1762693002

Cr-Commit-Position: refs/heads/master@{#379030}
(cherry picked from commit 8773435)

Review URL: https://codereview.chromium.org/1770183003 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#122}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit that referenced this pull request Oct 9, 2016
SimpleCache: open with fewer seeks.
3b72254 
There's usually no reason to read the file header before reading the
stream 0 (headers) data when opening a simple cache entry. By not doing
so, seeks in the critical path of the loading headers are reduced, which
should speed up http caching performance.

To be careful, the headers are still checked when the first read of data
(if any) is performed. This delays detecting hash collisions in the
cache, because the header data is required to compare keys (instead of
just hashes).

To compensate for the later key comparison, a SHA256 of the key is
stored as an optional prefix to the end of file record. This is used to
validate the key is correct before returning headers to the client.

Because the key checking logic is now totally migrated back into the
SimpleSynchronousEntry, we can return to reporting on key matching in
the SyncOpenResult histograms.

[email protected],[email protected],[email protected]
BUG=611732

Review-Url: https://codereview.chromium.org/1977863003
Cr-Commit-Position: refs/heads/master@{#395083}
(cherry picked from commit 9f15f22)

Review URL: https://codereview.chromium.org/2004913002 .

Cr-Commit-Position: refs/branch-heads/2743@{#4}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiansunn @huningxin