Depth stream 37 0 2055 0 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Layout the rendering areas in grid. 2. Shrink the video to match the screen size. BUG=None TEST=Run the test on peach-pit Review URL: https://codereview.chromium.org/298123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277364 0039d316-1c4b-4281-b951-d872f2087c98
…sts. BUG=None TEST=None [email protected] Review URL: https://codereview.chromium.org/338733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277365 0039d316-1c4b-4281-b951-d872f2087c98
BUG=383427 [email protected] Review URL: https://codereview.chromium.org/329373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277366 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277367 0039d316-1c4b-4281-b951-d872f2087c98
BUG=378621 TEST=successful build Review URL: https://codereview.chromium.org/327323006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277368 0039d316-1c4b-4281-b951-d872f2087c98
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176166:176166&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/337973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277369 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277370 0039d316-1c4b-4281-b951-d872f2087c98
The managed bookmarks folder can have a different name depending on the signed-in status of the user. This change makes the context menu that hides this folder follow the folder's name. Also fixed a glitch where the folder name would not update if configured both via cloud policy and platform policy. BUG=49598 Review URL: https://codereview.chromium.org/332443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277371 0039d316-1c4b-4281-b951-d872f2087c98
This CL seems to cause perf bot failure. The log said nacl_helper-data size gained exceeds expectation. http://build.chromium.org/p/chromium/builders/Linux/builds/50560 https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-data&rev=277212&checked=core > [PPAPI] Compositor API implementation. > > Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture. > > API Proposal http://goo.gl/V7xcu3 > > BUG=374383 > > Review URL: https://codereview.chromium.org/298023004 [email protected] Review URL: https://codereview.chromium.org/331123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277372 0039d316-1c4b-4281-b951-d872f2087c98
This adds a check to PepperPluginInstanceImpl::DidDataFromWebURLResponse to avoid calling the instances HandleDocumentLoad function if the plugin instance is deleted before the function gets called. It also adds a check to PepperURLLoaderHost::Close to avoid trying to access an instance that has already been destroyed. A TODO is also added because the behavior of PepperURLLoaderHost::Close is incorrect. BUG=384197,372548 Review URL: https://codereview.chromium.org/335463006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277373 0039d316-1c4b-4281-b951-d872f2087c98
Previously V8VarConverter::FromV8Value would always complete asynchronously (we would always post a task to the message loop to run the callback). However, this adds latency to the transmission of postMessage'd messages. It also has the unfortunate consequence that posted messages can arrive out of order with other messages (such as view changes). We should attempt to convert synchronously if possible and only resort to asynchronous conversion if needed. BUG=367896 Review URL: https://codereview.chromium.org/331593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277374 0039d316-1c4b-4281-b951-d872f2087c98
https://skia.googlesource.com/skia/+log/09b187c9bdc0bb35f455d2df2f0b6a8303f8114a..851eabe56424147069b9018ec91f6b528d4c09db [email protected] BUG= Review URL: https://codereview.chromium.org/338003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277375 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277376 0039d316-1c4b-4281-b951-d872f2087c98
…odereview.chromium.org/336653002/) Reason for revert: THis CL breaks several WebRTC bots. See e.g. http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester. [32/32] WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1 (TIMED OUT) 2 tests timed out: WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/0 WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1 Original issue's description: > Revert: Per navigation sticky media permissions. > This CL re-enables the same behavior for getUserMedia prompts as it was in M35. > The reason for this is because there was a change of hearts at the standards level about this. > More information in the issue. > > BUG=269719 > COLLABORATOR=xians > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276974 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=269719 Review URL: https://codereview.chromium.org/338753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277377 0039d316-1c4b-4281-b951-d872f2087c98
Temporarily disabling the test AppListControllerAppInfoDialogBrowserTest.DoShowAppInfoFlow as it is suspected to be flaky. Will investigate as part of bug. BUG=378251 Review URL: https://codereview.chromium.org/338003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277378 0039d316-1c4b-4281-b951-d872f2087c98
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176166:176170&mode=html [email protected] BUG= Review URL: https://codereview.chromium.org/339503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277379 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277380 0039d316-1c4b-4281-b951-d872f2087c98
BUG=384219 TEST=run the test Review URL: https://codereview.chromium.org/332873008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277381 0039d316-1c4b-4281-b951-d872f2087c98
BUG=383234 TEST=manually tested Review URL: https://codereview.chromium.org/333203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277384 0039d316-1c4b-4281-b951-d872f2087c98
…eForCreateFolder BUG=344769 Review URL: https://codereview.chromium.org/336713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277385 0039d316-1c4b-4281-b951-d872f2087c98
A table is added for MP4 mime types and their corresponding containers H.264 codecs vary according to the profile version. These are represented by hexadecimal numbers (RFC6381). These vary across platforms, hence a definite "probably" cannot be given for canPlayType query. The best we can say is a "maybe" if the codec is RFC compliant. New behaviour of the browser will be audio/mp4 -> avc1/ avc1./ avc1.4D4001 = "" audio/mp4 -> mp4a/ mp4a.40/ mp4a.40.2 = "maybe" audio/mp4 -> mp4a./ mp4a.50/ mp4a.40. = "" video/mp4 -> avc1/avc1.4D4001/ = "maybe" video/mp4 -> avc1./ avc1.NonHexDigits = "" (similar for mp4a and avc3) BUG=53193 TEST=out/Release/content_browsertests --gtest_filter=MediaCanPlayType* Review URL: https://codereview.chromium.org/254983006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277386 0039d316-1c4b-4281-b951-d872f2087c98
This fixes the calculation for the threshhold we use to calculate whether the graphics context needs to be resized. There isn't a correctness issue here, as the context will always be large enough but it results in resizing more than necessary. This example demonstrates the issue: -If the plugin size was 100 x 100, we would set the context size to 100+kBufferSize x 100+kBufferSize. -If the plugin was then resized to 90x90 we would check to see if the plugin size is smaller than (100+kBufferSize)-kBufferSize x (100+kBufferSize)-kBufferSize which is equal to 100 x 100. -But we really intend to check whether it is smaller than 100-kBufferSize x 100-kBufferSize Thus we should check whether the plugin is smaller than the (current context size) - 2*kBufferSize which is kBufferSize less than the plugin size when the context size was last computed. BUG=303491 Review URL: https://codereview.chromium.org/337443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277387 0039d316-1c4b-4281-b951-d872f2087c98
We have the separated video player, and we don't need to play videos in the gallery. BUG=251702 TEST=None Review URL: https://codereview.chromium.org/337893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277388 0039d316-1c4b-4281-b951-d872f2087c98
SwipeAction. SwipeAction now also able to perform swipe on element with selector and text (not just element_function). SwipeAction no longer accepts attributes and instead accept normal parameters. Added unit tests. BUG=361809 Review URL: https://codereview.chromium.org/337643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277389 0039d316-1c4b-4281-b951-d872f2087c98
Fixes ASAN component build after r277201. [email protected] Review URL: https://codereview.chromium.org/339543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277390 0039d316-1c4b-4281-b951-d872f2087c98
Add a EVENT_TRACE to initialization and finalization of SyncTaskToken to measure the time elapsed for SyncFS. BUG=344769 Review URL: https://codereview.chromium.org/337073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277391 0039d316-1c4b-4281-b951-d872f2087c98
BUG=383738 TEST=run the test Review URL: https://codereview.chromium.org/330003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277392 0039d316-1c4b-4281-b951-d872f2087c98
…etection, when database row has non-empty realm, assume autofill::PasswordForm::SCHEME_BASIC. BUG=375158 Review URL: https://codereview.chromium.org/306123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277393 0039d316-1c4b-4281-b951-d872f2087c98
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176171:176183&mode=html [email protected],[email protected] BUG= Review URL: https://codereview.chromium.org/334193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277394 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277395 0039d316-1c4b-4281-b951-d872f2087c98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs: