Touch #11

junmin-zhu · 2013-06-21T09:42:31Z

W3c Touch support on Linux.

Because GTK doesn't support multi touch yet, which chromium is based on for Linux.
So directly listen the touch event from Xinput server.
And translate to W3C touch event in RenderWidgetHostView.

BUG=crosswalk-project/crosswalk#98
TEST=manually test on http://www.sitepen.com/labs/code/iphone/events.html

Cameo uses Chromium resource framework (grit/grd). To make sure Cameo resource IDs are unique cross Chromium components, it is required to add new starting resource IDs. Since Cameo is a project built on Chromium, allocate starting IDs from 31000.

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199309 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199323 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Removed visual jank during kiosk app launch caused by default wallpaper loading. > > BUG=239156 > TEST=visual inspection during machine start > > Review URL: https://chromiumcodereview.appspot.com/14756016 [email protected] Review URL: https://codereview.chromium.org/14637019 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199332 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

Marging on behalf of [email protected]. > Files.app: Fixed the icon of image open item in default action dialog > > Originally, if a task item has both 'iconType' and 'iconUrl' properties, > 'iconType' is used in the tasks menu and > 'iconUrl' is used in the default action dialog. > > This CL fixed the priority for default action dialog so that both > priorities are same. > > BUG=237153 > TEST=Open 'default action dialog' and check the icon. > > Review URL: https://chromiumcodereview.appspot.com/14589007 [email protected] Review URL: https://codereview.chromium.org/14619028 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199354 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Pass caret bound to SchedulePaintInRect in local coordinate > so that the caret can be blinking correctly. This change should > have been included in r197858. > > BUG=238136 > TEST=Manually done on Windows 7. > > Review URL: https://chromiumcodereview.appspot.com/14846029 [email protected] Review URL: https://codereview.chromium.org/14686009 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199367 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Fixed the crash when the WebRtcAudioCapturer::|buffer_| is NULL, this can happen when the capturer is not correctly initialized. > > BUG=238388 > TEST=http://simpl.info/webaudio > [email protected] > > Review URL: https://codereview.chromium.org/15031003 [email protected] Review URL: https://codereview.chromium.org/15014019 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199431 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Make AppListController::InitView() act on the right profile. > > It is currently using whatever profile is around at startup, which may be an > incognito window (and so get deleted at any time). This change initializes the > view with the app list's previous profile, and cancels itself if there's > a profile in the process of being shown already. > > This also separates the sending of UMA stats into its own deferred task. > > BUG=236487 > [email protected] > > Review URL: https://codereview.chromium.org/14587005 [email protected] Review URL: https://codereview.chromium.org/14783011 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199486 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Randomize proxy timeout on Android over a range. > > BUG=237876 > > Review URL: https://chromiumcodereview.appspot.com/14864016 [email protected] Review URL: https://codereview.chromium.org/14623026 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199504 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199508 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Bluetooth: Parse the bluez.Error.Failed on pairing error. > > The method org.bluez.Device1.Pair can return with different errors. > Among those, an org.bluez.Error.Failed: "Device or resource busy" is > a possible option. > > This patch parses that D-Bus error as an ERROR_FAILED. > > BUG=238479 > TEST=BluetoothExperimentalChromeOSTest.PairUnpairableDevice on device_unittests passed with the fix, and fails without it. > > Review URL: https://chromiumcodereview.appspot.com/15016004 [email protected],[email protected] Review URL: https://codereview.chromium.org/14651022 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199512 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Record first run startup metrics. > > Also fixing first run code to only call startup_metric_utils::SetNonBrowserUIDisplayed() if the dialog is actually displayed (which it isn't in many situations). > > NOTRY=True (patchset 6 already passed all the try bots, simply updating a string in patchset 7) > BUG=237933, 219419 > > Review URL: https://chromiumcodereview.appspot.com/14946003 [email protected] Review URL: https://codereview.chromium.org/14683012 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199533 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199579 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Magnifier: Prevent the cursor jumping on HiDPI display. > > Magnifier have to use RootWindow::GetRootTransform() instead of getting the transform matrix from the layer because the transform from the layer isn't DPI-unaware. > > BUG=235928 > TEST=manual > [email protected], [email protected] > > Review URL: https://codereview.chromium.org/14466005 [email protected] Review URL: https://codereview.chromium.org/15102004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199611 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Fix mismatched parameter expectations between chrome.omnibox setDefaultSuggestion and SuggestResult > Adds new DefaultSuggestResult type to the omnibox json schema > > BUG=237817 > > Review URL: https://chromiumcodereview.appspot.com/14960004 [email protected] Review URL: https://codereview.chromium.org/14592004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199614 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199629 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> CrOS Files.app: Prevent the middle panel from disappearing. > > r198571 causes the regression described in crbug/239152. This patch reverts a part of the patch to fix the issue. > > BUG=239152 > TEST=manual > NOTRY=True > > Review URL: https://chromiumcodereview.appspot.com/14726003 [email protected] Review URL: https://codereview.chromium.org/15112002 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199636 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> CrOS Files.app: Support format command on new UI. > > BUG=239120 > TEST=manual > [email protected] > > Review URL: https://codereview.chromium.org/14858017 [email protected] Review URL: https://codereview.chromium.org/14771021 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199637 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199640 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Fix security errors when accessing files and volumes in Files.app V2 due to using unregistered handlers. > > The security errors were caused by revoking permissions to a file, directory or a root directory of a volume caused by launching Files.app using a handler not declared in the manifest. This patch fixes this issue by declaring all used handlers in the manifests and disallowing of calling undeclared handlers. > > TEST=Check these bugs' repro steps. > BUG=233641, 237134, 236743, 238239, 234056 > > Review URL: https://chromiumcodereview.appspot.com/14864004 [email protected] Review URL: https://codereview.chromium.org/14807009 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199670 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Remove internal handlers from the Files.app's UI. > > Recently, internal handlers have been added to the manifest to work in Files.app V2, which caused a regression - these internal handlers appeared in the UI, which is unexpected. This patch fixes this issue by hiding theses tasks. > > TEST=Enter Files.app, click on a picture, there should not be __MSG_OPEN_ACTION__ entries next to the Delete button. > BUG=239044 > [email protected] > > Review URL: https://codereview.chromium.org/14631019 [email protected] Review URL: https://codereview.chromium.org/14982007 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199672 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Fix overlapping labels in Files.app's gallery new UI. > > The styles showing the labels when the page width is > 1000px was not overriding the original styles because the style had lower priority. This patch fixes this issue by adding a body prefix to the style declaration. > > [email protected] > TEST=Launch Files.app, open a picture, try to edit. Be sure that the window is large enough to show the labels. > BUG=235789 > > Review URL: https://chromiumcodereview.appspot.com/14972004 [email protected] Review URL: https://codereview.chromium.org/15119002 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199673 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Add window buttons (close and maximize) to the Files.app's new UI. > > In the new UI decoration buttons have been removed, and were replaced by html ones. However, in gallery they were still missing. This patch fixes this issue by adding these two buttons. > > TEST=Run Files.app, open a picture, try to maximize and close. Check if the back button also works. Check the legacy ui. Check the legacy Files.app. > BUG=236311 > > Review URL: https://chromiumcodereview.appspot.com/14759019 [email protected] Review URL: https://codereview.chromium.org/15121002 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Fix wrapping window decoration buttons in the Files.app's new UI. > > Previously, the window decoration buttons (gear, maximize, close) were getting wrapped when the window is small. This patch fixes this issue by making the search box take not more than available space. > > [email protected] > TEST=Resize the window, click on the search box. > BUG=239415 > > Review URL: https://codereview.chromium.org/14865017 [email protected] Review URL: https://codereview.chromium.org/14599004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199676 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

> Return caret bounds in local coordinates from GetCaretBoundsInWidget > > This is another regression caused by r197858. > There remains another call site of TextInputClient::GetCaretBounds, > which now returns the caret rect as screen coordinate as > documented in the header. > > BUG=239737 > TEST=Manually done on Windows 7 with built-in Chinese IME. > > Review URL: https://chromiumcodereview.appspot.com/14731011 [email protected] Review URL: https://codereview.chromium.org/14668011 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199682 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

On behalf of [email protected]. > Changed the item click behavior of auto complete list. > > Originally, when the item of auto complete list is clicked, the default task of > selected item is executed. This CL handles the cases of other dialog types > except FULL_PAGE. In this cases, when the item of auto complete list is clicked, > the file manager should be closed like that its OK button is clicked. > > BUG=237549 > TEST=Open file manager as a modal dialog (by Ctrl+O, Ctrl + S), search drive items by using auto complete list and click a result item > > Review URL: https://chromiumcodereview.appspot.com/14797006 [email protected] Review URL: https://codereview.chromium.org/14702006 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199683 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

Committing on befalf of [email protected]. > Files.app: Changed the text color of selected item in the default action dialog. > > BUG=237159 > > Review URL: https://chromiumcodereview.appspot.com/14628010 [email protected] Review URL: https://codereview.chromium.org/14800013 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199684 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

…r_tests compiling on MacViews (patchset #7 of https://codereview.chromium.org/486063002/) Reason for revert: browser_test fails in Linux ASAN/LSAN test. WebDialogBrowserTest.SizeWindow (run #1): [ RUN ] WebDialogBrowserTest.SizeWindow [30383:30383:0820/232516:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [30383:30383:0820/232516:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [30473:30473:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox [30496:30496:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==30383==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7feeddc6676c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232518:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #2): [ RUN ] WebDialogBrowserTest.SizeWindow [16767:16767:0820/232720:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [16767:16767:0820/232720:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [16871:16871:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox [16911:16911:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==16767==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7fb13f28476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232722:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #3): [ RUN ] WebDialogBrowserTest.SizeWindow [16994:16994:0820/232723:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [16994:16994:0820/232724:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [17026:17026:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox [17038:17038:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==16994==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7f0688ff376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232725:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #4): [ RUN ] WebDialogBrowserTest.SizeWindow [17073:17073:0820/232726:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [17073:17073:0820/232726:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [17105:17105:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox [17116:17116:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==17073==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7f5f8410c76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232728:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly Original issue's description: > MacViews: Fix WebDialogBrowserTest.SizeWindow to get browser_tests compiling on MacViews > > gyp changes are made to filter out toolkit-views browser_tests that > aren't yet compiled in to a toolkit-views Chrome binary on Mac. > > One, WebDialogBrowserTest.SizeWindow, was a disabled test (disabled for > 4 years :o). It was preventing browser_tests compiling on MacViews > because it was passing a gfx::NativeWindow to CreateWindowWithParent, > which takes a view. > > The parent isn't important for the test - it's just adding widget > context. This CL changes the parent to be web_contents->GetNativeView() > instead so the test compiles. > > To ensure nothing breaks, the test needs to be enabled. According to the > comment, the reasons for it being disabled on Windows still seem > relevant. However, on Linux the test was just timing out due to a quirk > of the test. So the quirk is fixed, and WebDialogBrowserTest.SizeWindow > is enabled on Linux Aura. > > The test is also enabled on Mac, but currently fails because > NativeViewHost isn't implemented yet. That's coming, and leaving the > test enabled will ensure we check it. > > With this change browser_tests compiles and links on toolkit-views Mac. > > BUG=404979, 399191, 52602 > TEST=browser_tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290998 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=404979, 399191, 52602 Review URL: https://codereview.chromium.org/490123002 Cr-Commit-Position: refs/heads/master@{#291014} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291014 0039d316-1c4b-4281-b951-d872f2087c98

… with gin (patchset #3 of https://codereview.chromium.org/472693002/) Reason for revert: Caused failures in DrMemory: UNADDRESSABLE ACCESS of freed memory: writing 0x031c0278-0x031c0279 1 byte(s) # 0 ppapi_tests.dll!`anonymous namespace'::InstanceSO::~InstanceSO [ppapi\tests\test_instance_deprecated.cc:48] # 1 ppapi_tests.dll!`anonymous namespace'::InstanceSO::`scalar deleting destructor' # 2 ppapi_tests.dll!pp::deprecated::`anonymous namespace'::Deallocate [ppapi\cpp\dev\scriptable_object_deprecated.cc:126] # 3 ppapi_proxy.dll!ppapi::CallWhileUnlocked<> [ppapi\shared_impl\proxy_lock.h:123] # 4 ppapi_proxy.dll!ppapi::proxy::PluginVarTracker::DidDeleteInstance [ppapi\proxy\plugin_var_tracker.cc:281] # 5 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnPluginMsgDidDestroy [ppapi\proxy\ppp_instance_proxy.cc:194] # 6 ppapi_proxy.dll!PpapiMsg_PPPInstance_DidDestroy::Dispatch<> [ppapi\proxy\ppapi_messages.h:670] # 7 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnMessageReceived [ppapi\proxy\ppp_instance_proxy.cc:143] # 8 ppapi_proxy.dll!ppapi::proxy::Dispatcher::OnMessageReceived [ppapi\proxy\dispatcher.cc:69] # 9 ppapi_proxy.dll!ppapi::proxy::PluginDispatcher::OnMessageReceived [ppapi\proxy\plugin_dispatcher.cc:238] #10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage [ipc\ipc_channel_proxy.cc:273] #11 ipc.dll!base::internal::Invoker<>::Run [base\bind_internal.h:1253] #12 base.dll!base::debug::TaskAnnotator::RunTask [base\debug\task_annotator.cc:62] #13 base.dll!base::MessageLoop::RunTask [base\message_loop\message_loop.cc:436] #14 base.dll!base::MessageLoop::DeferOrRunPendingTask [base\message_loop\message_loop.cc:445] #15 base.dll!base::MessageLoop::DoWork [base\message_loop\message_loop.cc:552] #16 base.dll!base::MessagePumpDefault::Run [base\message_loop\message_pump_default.cc:32] #17 base.dll!base::MessageLoop::RunHandler [base\message_loop\message_loop.cc:408] #18 content.dll!content::PpapiPluginMain [content\ppapi_plugin\ppapi_plugin_main.cc:141] #19 content.dll!content::RunNamedProcessTypeMain [content\app\content_main_runner.cc:415] #20 content.dll!content::ContentMainRunnerImpl::Run [content\app\content_main_runner.cc:764] #21 content.dll!content::ContentMain [content\app\content_main.cc:19] #22 content::LaunchTests [content\public\test\test_launcher.cc:475] #23 main [content\test\content_test_launcher.cc:123] First appeared in http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%29/builds/631/steps/memory%20test%3A%20content_browsertests/logs/stdio. Original issue's description: > Minor changes to allow Pepper InstancePrivate tests to pass with gin > > This includes some minor changes which allow tests to when NPObject is replaced > by gin in pepper: > -Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in > tests. > -Add gin as a dependency to content_unittests for use in host_var_tracker_unittest > -Change TestInstanceDeprecated so that it doesn't execute a script from the > ScriptableObject upon destruction. The reason for this is that the garbage > collector is manually run from the destructor of the plugin Instance object. > This results in destruction of the ScriptableObject and then javascript is > re-entered via ExecuteScript. This should never happen outside tests because > the garbage collector won't be run synchronously. Instead of running > ExecuteScript, which just set a variable in the Instance object to verify > that the ScriptableObject was correctly destroyed. > > BUG=351636 > > Committed: https://chromium.googlesource.com/chromium/src/+/92c3074f4b4417924115f880657f1ec15da0e0ba [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=351636,407372 Review URL: https://codereview.chromium.org/502143003 Cr-Commit-Position: refs/heads/master@{#291780}

#10 of https://codereview.chromium.org/479403004/) Reason for revert: This is causing unaddressable memory errors on the DrMemory full bot. Build where the error was introduced: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/945 (error hash: 25DFC5E3C30FC6B7) Sample log output: UNADDRESSABLE ACCESS of freed memory: reading 0x034348e0-0x034348e4 4 byte(s) # 0 blink_web.dll!blink::toCoreFrame [third_party\webkit\source\web\webframe.cpp:24] # 1 blink_web.dll!blink::RemoteFrameClient::firstChild [third_party\webkit\source\web\remoteframeclient.cpp:49] # 2 blink_web.dll!blink::WebRemoteFrameImpl::~WebRemoteFrameImpl [third_party\webkit\source\web\webremoteframeimpl.cpp:106] # 3 blink_web.dll!blink::WebRemoteFrameImpl::close [third_party\webkit\source\web\webremoteframeimpl.cpp:131] # 4 content.dll!content::RenderFrameProxy::~RenderFrameProxy [content\renderer\render_frame_proxy.cc:120] # 5 content.dll!content::RenderFrameProxy::`vector deleting destructor' # 6 content.dll!content::RenderFrameProxy::OnDeleteProxy [content\renderer\render_frame_proxy.cc:180] # 7 content.dll!content::MessageRouter::RouteMessage [content\common\message_router.cc:54] # 8 content.dll!content::MessageRouter::OnMessageReceived [content\common\message_router.cc:46] # 9 content.dll!content::ChildThread::OnMessageReceived [content\child\child_thread.cc:494] #10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage [ipc\ipc_channel_proxy.cc:273] #11 ipc.dll!base::internal::Invoker<>::Run [base\bind_internal.h:1253] #12 base.dll!base::debug::TaskAnnotator::RunTask [base\debug\task_annotator.cc:62] #13 base.dll!base::MessageLoop::RunTask [base\message_loop\message_loop.cc:436] #14 base.dll!base::MessageLoop::DeferOrRunPendingTask [base\message_loop\message_loop.cc:445] #15 base.dll!base::MessageLoop::DoWork [base\message_loop\message_loop.cc:552] #16 base.dll!base::MessagePumpDefault::Run [base\message_loop\message_pump_default.cc:32] #17 base.dll!base::MessageLoop::RunHandler [base\message_loop\message_loop.cc:408] #18 content.dll!content::RendererMain [content\renderer\renderer_main.cc:227] #19 content.dll!content::RunNamedProcessTypeMain [content\app\content_main_runner.cc:415] #20 content.dll!content::ContentMainRunnerImpl::Run [content\app\content_main_runner.cc:764] #21 content.dll!content::ContentMain [content\app\content_main.cc:19] #22 content::LaunchTests [content\public\test\test_launcher.cc:475] #23 main [content\test\content_test_launcher.cc:123] BTW IMHO the CL summary for this change could be better, this change did way more than re-enalbe a test. Ideally the summary would capture the entirety of the change. Original issue's description: > Re-enable SitePerProcessBrowserTest.CrossSiteIframe > > This CL fixes a few issues in the cross-process subframe navigation and re-enables the CrossSiteIframe test on most platforms. There are still some issues on ChromeOS and Android, which will be investigated and fixed in follow-up CL. > > BUG=399775, 357747 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291437 [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=399775, 357747 Review URL: https://codereview.chromium.org/515073002 Cr-Commit-Position: refs/heads/master@{#292336}

…hset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Log and stack trace: [16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend. [16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated. [16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fe3122e555e base::debug::StackTrace::StackTrace() #1 0x7fe31237c462 logging::LogMessage::~LogMessage() #2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed() #3 0x7fe3123630a1 base::PathExists() #4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs() #5 0x7fe321cfad22 extensions::Extension::InitFromValue() #6 0x7fe321cfa490 extensions::Extension::Create() #7 0x7fe321cfa114 extensions::Extension::Create() #8 0x7fe3233ebe1b extensions::ComponentLoader::Load() #9 0x7fe3233ec3cf extensions::ComponentLoader::Add() #10 0x7fe3233ec32a extensions::ComponentLoader::Add() #11 0x7fe3233ec2b0 extensions::ComponentLoader::Add() #12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension() #13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded() #14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension() #15 0x7fe322f68bb2 chromeos::WebUILoginView::Init() #16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView() #17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL() #18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard() #19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe() #21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe() #22 0x7fe31b222377 content::NotificationServiceImpl::Notify() #23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished() #25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted() #27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive() #28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating() #30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController() #31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage() #34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper() #35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run() #37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo() #38 0x7fe322fbaba5 base::internal::Invoker<>::Run() #39 0x7fe3122cc9ce base::Callback<>::Run() #40 0x7fe312488f86 base::Timer::RunScheduledTask() #41 0x7fe3124890bc base::BaseTimerTaskInternal::Run() #42 0x7fe312489382 base::internal::RunnableAdapter<>::Run() #43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo() #44 0x7fe312489295 base::internal::Invoker<>::Run() #45 0x7fe3122cc9ce base::Callback<>::Run() #46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask() #47 0x7fe3123a1c57 base::MessageLoop::RunTask() #48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask() #49 0x7fe3123a228d base::MessageLoop::DoDelayedWork() #50 0x7fe3122a1f25 base::MessagePumpGlib::Run() #51 0x7fe3123a17f0 base::MessageLoop::RunHandler() #52 0x7fe3124093b2 base::RunLoop::Run() #53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun() #54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts() #55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run() #56 0x7fe31ad251b1 content::BrowserMain() #57 0x7fe31abb997f content::RunNamedProcessTypeMain() #58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run() #59 0x7fe31abb8ee5 content::ContentMain() #60 0x7fe3206d3505 ChromeMain #61 0x7fe3206d34b2 main Cannot upload crash dump: cannot exec /sbin/crash_reporter Crash_reporter failed to process crash report Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=409948 Review URL: https://codereview.chromium.org/532183003 Cr-Commit-Position: refs/heads/master@{#293128}

…11 id:190001 of https://codereview.chromium.org/521583003/) Reason for revert: This is breaking on Android Tests (dbg) Original issue's description: > Adding Text Selection Action Bar Unit Test cases. > > Currently there is not enough unit test cases available to cover > the functionality of Text Selection Action Bar. In this patch covering > essentail unit test cases for the same. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/7da8be70e45d91995fb4476713d7920ce77cb90f [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/549433004 Cr-Commit-Position: refs/heads/master@{#293730}

…::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(3) http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace() #1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f3bc709f4a0 <unknown> #3 0x7f3bc7151a43 __poll #4 0x7f3bc7b8dff6 <unknown> #5 0x7f3bc7b8e124 g_main_context_iteration #6 0x7f3bcf366f35 base::MessagePumpGlib::Run() #7 0x7f3bcf468180 base::MessageLoop::RunHandler() #8 0x7f3bcf4cfcc2 base::RunLoop::Run() #9 0x0000041e0729 content::RunThisRunLoop() #10 0x0000041e06ba content::RunMessageLoop() #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult() #12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run() #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo() #18 0x0000041c9c25 base::internal::Invoker<>::Run() #19 0x00000063f0de base::Callback<>::Run() #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run() #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo() #26 0x7f3bd7bd960a base::internal::Invoker<>::Run() #27 0x7f3bd80a852e base::Callback<>::Run() #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow() #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks() #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize() #31 0x7f3bd7bcda55 content::BrowserMain() #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain() #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run() #34 0x7f3bd7a617b5 content::ContentMain() #35 0x0000041c82cb content::BrowserTestBase::SetUp() #36 0x00000176afc3 InProcessBrowserTest::SetUp() #37 0x000000674823 ExtensionBrowserTest::SetUp() #38 0x000000674852 ExtensionBrowserTest::SetUp() #39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>() #41 0x00000180ad73 testing::Test::Run() #42 0x00000180b4cb testing::TestInfo::Run() #43 0x00000180baca testing::TestCase::Run() #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests() #45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>() #47 0x000001810c97 testing::UnitTest::Run() #48 0x0000041a5531 RUN_ALL_TESTS() #49 0x0000041a4547 base::TestSuite::Run() #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite() #51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #52 0x0000041d9efb content::LaunchTests() #53 0x00000176954b LaunchChromeTests() #54 0x00000080262f main #55 0x7f3bc708a76d __libc_start_main #56 0x0000005ffda9 <unknown> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT) Original issue's description: > Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. > > ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string. > > Previously, only the latter case was handled when trying to continue propagating keys. > > BUG=407163 > TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*). > > Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=407163 Review URL: https://codereview.chromium.org/552533003 Cr-Commit-Position: refs/heads/master@{#293780}

…ttps://codereview.chromium.org/543663003/) Reason for revert: Speculative, to see if it helps with ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164 #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259 #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420 #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358 #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231 #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672 #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46 #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14 #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281 #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452 #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392 #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309 #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342 #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526 #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894 Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ (see http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ for symbols), and this looks tangentially related (it touched the file the uninitialized read is in.) Line 1164 is if (params.visible_on_all_workspaces) { state_atom_list.push_back(atom_cache_.GetAtom("_NET_WM_STATE_STICKY")); ui::SetIntProperty(xwindow_, "_NET_WM_DESKTOP", "CARDINAL", kAllDesktops); } https://chromium.googlesource.com/chromium/src/+blame/master/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc Original issue's description: > Fix maximize on some window managers > > On some window managers the Maximize hints are not respected when they > are set on an unmapped window. There was an existing workaround for this > in the code, but the workaround failed whenever ShowWindowWithState > didn't happen to be called with the parameters needed to activate the > workaround. This meant that if a window was first made visible and later > activated, it would not get maximized at all. > > This fix saves whether the maximize hints need to be sent to the window, > and makes sure it gets done after mapping the window. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/334fca491b7e798d75e76a56c57074d3187602be [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/554843002 Cr-Commit-Position: refs/heads/master@{#293786}

…id:1 of https://codereview.chromium.org/554843002/) Reason for revert: I unchecked cq, not sure why this revert was landed. (I want to revert https://codereview.chromium.org/469993003/ instead) Original issue's description: > Revert of Fix maximize on some window managers (patchset #1 id:1 of https://codereview.chromium.org/543663003/) > > Reason for revert: > Speculative, to see if it helps with > > ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164 > #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259 > #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420 > #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358 > #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231 > #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672 > #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46 > #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14 > #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281 > #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 > #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452 > #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392 > #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309 > #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342 > #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526 > #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894 > > Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ (see http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ for symbols), and this looks tangentially related (it touched the file the uninitialized read is in.) > > Line 1164 is > > if (params.visible_on_all_workspaces) { > state_atom_list.push_back(atom_cache_.GetAtom("_NET_WM_STATE_STICKY")); > ui::SetIntProperty(xwindow_, "_NET_WM_DESKTOP", "CARDINAL", kAllDesktops); > } > > https://chromium.googlesource.com/chromium/src/+blame/master/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc > > Original issue's description: > > Fix maximize on some window managers > > > > On some window managers the Maximize hints are not respected when they > > are set on an unmapped window. There was an existing workaround for this > > in the code, but the workaround failed whenever ShowWindowWithState > > didn't happen to be called with the parameters needed to activate the > > workaround. This meant that if a window was first made visible and later > > activated, it would not get maximized at all. > > > > This fix saves whether the maximize hints need to be sent to the window, > > and makes sure it gets done after mapping the window. > > > > BUG= > > > > Committed: https://chromium.googlesource.com/chromium/src/+/334fca491b7e798d75e76a56c57074d3187602be > > [email protected],[email protected] > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/013b6d4051e8e2c8960faa12b92e273925aaee5b [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/551123002 Cr-Commit-Position: refs/heads/master@{#293790}

….chromium.org/469993003) Speculative, to see if it helps with ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164 #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259 #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420 #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358 #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231 #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672 #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46 #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14 #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281 #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452 #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392 #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309 #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342 #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526 #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894 Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/98 (see stdio for symbols), and this looks like the only change in that build. This reverts commit c76ef73. BUG=384644 [email protected] Review URL: https://codereview.chromium.org/550413002 Cr-Commit-Position: refs/heads/master@{#293792}

@nasko

…e. (patchset #11 id:200001 of https://codereview.chromium.org/536143002/) Reason for revert: SitePerProcessBrowserTest.ProxyCreationSkipsSubtree repeatedly fails on Mac with ASAN reporting use-after-free, see: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/2174 http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.8%20Buildrunner/builds/19009 @nasko, as there are some simultaneous breakages right now, so I could not investigate this further and opted to revert the whole thing to get the tree green ASAP. Snippets from test log: ASSERTION FAILED: !localFrame || (localFrame->isLocalFrame()) ../../third_party/WebKit/Source/core/frame/LocalFrame.h(253) : blink::LocalFrame *blink::toLocalFrame(blink::Frame *) ../../content/browser/site_per_process_browsertest.cc:690: Failure Value of: child->child_count() Actual: 2 Expected: 0U Which is: 0 Original issue's description: > Do not create proxy hosts in the subtree of navigating frame. > > When a frame is navigating cross-process, its existing document will be completely destroyed and all child frames will be gone. This means that we don't need to create proxy objects for the new SiteInstance in the subtree of the navigating frame. > > BUG=357747 > > Committed: https://crrev.com/faab4288197b20b73610aad3e5579751b0c3a97b > Cr-Commit-Position: refs/heads/master@{#294520} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=357747 Review URL: https://codereview.chromium.org/565103002 Cr-Commit-Position: refs/heads/master@{#294552}

…ling out in UpdateDisplays (patchset #4 id:60001 of https://codereview.chromium.org/559213002/) Reason for revert: I am reverting this as it resulted in test VirtualKeyboardUsabilityExperimentTest.VirtualKeyboardWindowTest consistently crashing on Linux ChromiumOS Tests, see: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31731 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/2914 Stack trace: Objects involved in the operation: sequence "this" @ 0x0x3e568fbdcc90 { } Received signal 6 #0 0x7fcb9c8936fe base::debug::StackTrace::StackTrace() #1 0x7fcb9c893230 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fcb8c474cb0 \u003Cunknown> #3 0x7fcb8bbc4425 gsignal #4 0x7fcb8bbc7b8b abort #5 0x7fcb8c1c75ad __gnu_debug::_Error_formatter::_M_error() #6 0x7fcb9a306513 std::__debug::vector\u003C>::operator[]() #7 0x7fcb9a2fbba9 ash::DisplayManager::GetCurrentDisplayIdPair() #8 0x7fcb9a2d96cf ash::DisplayController::PostDisplayConfigurationChange() #9 0x7fcb9a2d98bc ash::DisplayController::PostDisplayConfigurationChange() #10 0x7fcb9a2fd22a ash::DisplayManager::UpdateDisplays() #11 0x7fcb9a2fdbe8 ash::DisplayManager::SetDisplayRotation() #12 0x7fcb9a33425b ash::VirtualKeyboardWindowController::FlipDisplay() #13 0x7fcb9a3340d7 ash::VirtualKeyboardWindowController::UpdateWindow() #14 0x7fcb9a2d92df ash::DisplayController::CreateOrUpdateNonDesktopDisplay() #15 0x7fcb9a2d937f ash::DisplayController::CreateOrUpdateNonDesktopDisplay() #16 0x7fcb9a300ea9 ash::(anonymous namespace)::NonDesktopDisplayUpdater::~NonDesktopDisplayUpdater() #17 0x7fcb9a300df1 ash::DisplayManager::CreateMirrorWindowIfAny() Original issue's description: > Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays > > When changing from software mirroring mode to sinlge display mode, it > is possible there is no need to update |displays_| and we early out > UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange() > cause there are some clients need to act on this, e.g. > TouchTransformerController needs to adjust the TouchTransformer when > switching from dual displays to single display. > > BUG=chrome-os-partner:31868 > TEST=tested on Big, after existing software mirroring mode, the touch location > transformation is still correct. > > Committed: https://crrev.com/4802a8552a40e1f80606ca7171dc2f79930e7fb3 > Cr-Commit-Position: refs/heads/master@{#294481} [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:31868 Review URL: https://codereview.chromium.org/569553002 Cr-Commit-Position: refs/heads/master@{#294553}

… (patchset #2 id:60001 of https://codereview.chromium.org/562763002/) Reason for revert: This broken the Linux ASan LSan Tests: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7506 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5717 Sample callstacks: Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4d560a3e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4aef980e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Convert device::UsbConfigDescriptor and friends to structs. > > These classes do not need to be classes and expecially don't need to be > abstract classes as this leads to a complicated implementation and > complicated tests. All USB devices no matter the platform will have the > same descriptor data. > > This change follows the model of device::HidDeviceInfo. > > BUG= > > Committed: https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5 > Cr-Commit-Position: refs/heads/master@{#294594} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/567003002 Cr-Commit-Position: refs/heads/master@{#294640}

…er (patchset #11 id:220001 of https://codereview.chromium.org/543243003/) Reason for revert: This patch appears to cause a Chrome OS bot to break. http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71945 Original issue's description: > Remote Assistance on Chrome OS - Aura Desktop Capturer > > This CL implements a WebRTC Desktop Capturer that captures from > the Aura Shell root window. > > The capturer is used by the It2MeHost on Chrome OS. > |DesktopCaptureDeviceAura| cannot be re-used in our scenario > because is timer-driven as opposed to caller driven, which is > required by WebRTC. > > The current implementation uses the layer API > > desktop_window_->layer()->RequestCopyOfOutput(request.Pass()) > > to request the layer and its subtree to be rendered to a > |SkiaBitmap|. It then copies the pixels to a WebRTC |DesktopFrame|. > > BUG=411530 > > Committed: https://crrev.com/278b065b519617b1e9231bd53e6502706d20787c > Cr-Commit-Position: refs/heads/master@{#295187} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=411530 Review URL: https://codereview.chromium.org/579583003 Cr-Commit-Position: refs/heads/master@{#295196}

…disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/) Reason for revert: this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup. here's an example: [15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by: [15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker() #2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter() #3 0x000000df57f1 IOThread::InitSystemRequestContext() #4 0x000000df570b IOThread::system_url_request_context_getter() #5 0x000001443d9e BrowserProcessImpl::system_request_context() #6 0x000001028a8e SafeBrowsingService::Initialize() #7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x000001446196 BrowserProcessImpl::safe_browsing_service() #9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate() #10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated() #11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated() #12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl() #13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted() #14 0x7f44be068302 base::internal::RunnableAdapter<>::Run() #15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo() #16 0x7f44be06821a base::internal::Invoker<>::Run() #17 0x7f44be54e46e base::Callback<>::Run() #18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow() #19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks() #20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize() #21 0x7f44be05c7df content::BrowserMain() #22 0x7f44bdee5f6f content::RunNamedProcessTypeMain() #23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run() #24 0x7f44bdee5505 content::ContentMain() #25 0x0000041aa8cb content::BrowserTestBase::SetUp() #26 0x00000173e117 InProcessBrowserTest::SetUp() #27 0x000000671180 ExtensionBrowserTest::SetUp() #28 0x0000006711b2 ExtensionBrowserTest::SetUp() #29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>() #31 0x0000017dd1e3 testing::Test::Run() #32 0x0000017dd92b testing::TestInfo::Run() #33 0x0000017ddf1a testing::TestCase::Run() #34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests() #35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000017e30b1 testing::UnitTest::Run() #38 0x000004187e41 RUN_ALL_TESTS() #39 0x000004186e67 base::TestSuite::Run() #40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite() #41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #42 0x0000041bc2fb content::LaunchTests() #43 0x00000173c6e9 LaunchChromeTests() #44 0x0000007fccbf main #45 0x7f44ad8ed76d __libc_start_main #46 0x000000601389 <unknown> [15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1) #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x7f44b58d7a62 logging::LogMessage::~LogMessage() #2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks() #3 0x000000df8e13 IOThread::CleanUp() #4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp() #5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp() #6 0x7f44b59d0601 base::Thread::ThreadMain() #7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc() #8 0x7f44b1aa9e9a start_thread #9 0x7f44ad9c03fd clone Original issue's description: > Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM > > BUG=384041 > TEST=new tests added > > Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63 > Cr-Commit-Position: refs/heads/master@{#295524} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=384041 Review URL: https://codereview.chromium.org/582913003 Cr-Commit-Position: refs/heads/master@{#295549}

…50001 of https://codereview.chromium.org/542733002/) Reason for revert: Introduced memory leaks on linux asan http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892: Direct leak of 80 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5 #2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #4 0x2e3b0bf in Run base/callback.h:401:12 #5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 64 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5 #2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #6 0x2e3b0bf in Run base/callback.h:401:12 #7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 36 byte(s) in 1 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5 #2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121 #3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8 #4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8 #5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #9 0x2e3b0bf in Run base/callback.h:401:12 #10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Remove void** from disk_cache interface. > > Enumeration and iteration were passing around void**. With this CL, we > instead use an Iterator object. > > [email protected],[email protected],[email protected] > BUG=413644 > > Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342 > Cr-Commit-Position: refs/heads/master@{#295659} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=413644 Review URL: https://codereview.chromium.org/585833002 Cr-Commit-Position: refs/heads/master@{#295677}

…410) (patchset #1 id:1 of https://codereview.chromium.org/590143002/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 0f6e289:a63b92e (svn 182407:182410) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/0f6e289..a63b92e > > [email protected],[email protected],[email protected] > > Committed: https://crrev.com/09e1192db2fc7c5295eb373626b77945ca10aee3 > Cr-Commit-Position: refs/heads/master@{#295959} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/593693004 Cr-Commit-Position: refs/heads/master@{#295961}

…407) (patchset #1 id:1 of https://codereview.chromium.org/588163003/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289 > > [email protected],[email protected],[email protected] > > Committed: https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede > Cr-Commit-Position: refs/heads/master@{#295950} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/592783002 Cr-Commit-Position: refs/heads/master@{#295962}

…codereview.chromium.org/517233002/) Reason for revert: Fails to compile on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20(dbg)/builds/2163 devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/SocketTunnelServerTest.java:291: cannot find symbol symbol: method sleep() sleep(); ^ Original issue's description: > Implementation of DevTools socket tunneling service for remote debugging. > > Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests. > > This CL doesn't care of a few known issues: > 1. Data channel buffer overflow. Data channel automatically closed in this case. > 2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging. > 3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling). > > To keep this CL reasonably simple this issues will be addressed later. > > TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing. > BUG=383418 > > Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1 > Cr-Commit-Position: refs/heads/master@{#296360} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=383418 Review URL: https://codereview.chromium.org/597063002 Cr-Commit-Position: refs/heads/master@{#296361}

Cr-Commit-Position: refs/branch-heads/2171@{#11} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

BUG=chrome-os-partner:33558 Review URL: https://codereview.chromium.org/838863005 Cr-Commit-Position: refs/heads/master@{#311158} (cherry picked from commit b6535b1) Review URL: https://codereview.chromium.org/853773002 Cr-Commit-Position: refs/branch-heads/2272@{#11} Cr-Branched-From: 827a380-refs/heads/master@{#310958}

Catch the error raised by 'check_call' rather than the error emitted by the called process. BUG=chromium:460693,chromium:459681 TEST=local - Ran without fix, setting CHROME_HEADLESS=1. Script failed with the exception in the bug. - Ran with fix, 'gsutil' failed with AccessDeniedException output and the calling script successfully emitted a warning message. [email protected], [email protected] Review URL: https://codereview.chromium.org/949813002 Cr-Commit-Position: refs/heads/master@{#317608} (cherry picked from commit 63ab4fe) Review URL: https://codereview.chromium.org/953803002 Cr-Commit-Position: refs/branch-heads/2311@{#11} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}

…lti}Plane. (patchset #11 id:630001 of https://codereview.chromium.org/967793002/) Reason for revert: Seems to breaks bots that use real cameras: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/136 WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetrics WebRtcPerfBrowserTest.MANUAL_RunsOneWayCall60SecsAndLogsInternalMetrics Original issue's description: > Linux Video Capture: Add V4L2VideoCaptureDelegate{Single,Multi}Plane. > > This CL adds support for V4L2 MPLANE Capture Api. > Only supported format is YUV420M triplanar. > > A new method is added to VideoCaptureDeviceClient, > namely OnIncomingCapturedYuvData(...), which forces > adding MOCKing here and there, and its own > implementation. > > V4L2 MMAP API works via user mmap()ing a number of > buffer allocated by V4L2 capture device. If those > buffers are not correctly munmap()ed, bad things (c) > happen. In light of this, the manual buffer lifetime > management is changed to automatic one. Construction > (mmap()ing) of those called BufferTracker is > planarity specific (i.e. there's one such ctor in > each of BufferTracker{S,M}Plane), while the dtor > is generic and the same. > > ToT class diagram: > +------------------------------------+ > | VideoCaptureDeviceLinux | > | +----------------------+| > | <<ref>> -->| V4L2CaptureDelegate || > | cnt | (struct Buffer) || > | +----------------------+| > +------------------------------------+ > > This CL class scheme: > > +--------------------------+ > | VideoCaptureDeviceLinux | > | | > | <<ref_cnt>> ---+ | > +----------------|---------+ > +----------------v-----------+ v4l2_capture_delegate.{cc,h} > | +-----------------------+ | > | |V4L2CaptureDelegate | | > | | (class BufferTracker)| | > | +-----------------------+ | > +-------^------------------^-+ > | | > +----|-------+ +--------|--+ v4l2_capture_delegate_multi_plane.{cc,h} > | SPlane | | MPlane | > | (BTSplane) | | (BTMPlane)| > | | +-----------+ > +------------+ v4l2_capture_delegate_single_plane.{cc,h} > > - VCDevice works on the premise that its calls into > VCDevice::Client::OnIncomingWhatever() are synchronous. > That assumption is respected here. > > - A bit of cleanup is done in OnIncomingCaptureData(), > in what regards rotation/crop/odd sizes. A unit test > is subsequently added. > > - VideoCaptureDeviceFactory labels the devices as > Single or Multi Planar. That labeling capture_api_type() > needs to ripple through a bunch of files, causing some > otherwise uninteresting changes in the patchsets. > > BUG=441836 > > TEST= Compile and insmod vivid.ko into a kernel, > with options for supporting MPLANE api (multiplanar=2) > then capture using patched Chromium. Current vivid > does _not_ support any common Mplane format, needs > a patch: > > https://github.com/miguelao/linux/tree/adding_yu12_yv12_nv12_nv21___mplane_formats___with_mods_for_kernel_3_13 > > that needs to be compiled against ubuntu sources 3.13 etc. > > For even better coverage, use a normal WebCam and > navigate to http://goo.gl/fUcIiP, then open both > the MPlane camera mentioned in the previous paragraph > and the "normal" webcam (this is,partially, how I > try it). > > Committed: https://crrev.com/d3d37d0f3493dd28cd687fe9285b0aac81a61dae > Cr-Commit-Position: refs/heads/master@{#321612} [email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=441836 Review URL: https://codereview.chromium.org/1031583002 Cr-Commit-Position: refs/heads/master@{#321746}

The dialog was broken because of race condition between https://codereview.chromium.org/1115993002 and https://codereview.chromium.org/1129063003 BUG=488629 TEST=manually Review URL: https://codereview.chromium.org/1124213004 Cr-Commit-Position: refs/heads/master@{#330237} (cherry picked from commit d1b5d55) Review URL: https://codereview.chromium.org/1128213006 Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#11} Cr-Branched-From: f54b809-refs/heads/master@{#330231}

Cr-Commit-Position: refs/branch-heads/2623@{crosswalk-project#11} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

…<Request>* rather than a RequestHandle* (patchset crosswalk-project#11 id:200001 of https://codereview.chromium.org/1439053002/ ) Reason for revert: Top crasher on Canary has PAC script cancellation on callstack. Very likely a bug or interaction with this CL. Reverting until I have a chance to fully investigate. Original issue's description: > Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle* > > * ProxyResolver::GetProxyForURL() fills a |scoped_pointer<Request>*| > rather than a |void*| > * ProxyResolver::CancelRequest(void*) has been removed. Requests > are instead cancelled by resetting the scoped_ptr<Request>. > > This makes for less error prone code as cancellation of > requests is automatic when the > scoped_ptr<Request> goes out of scope. > ProxyResolver::GetLoadState() is removed and replaced > by Request::GetLoadState(). > > Also made some renaming, as there were similar class > named Job or Request. Now they are all Job and this new thing > is Request. > > Referencing by address to object in vector was not wise in net/proxy/mojo_proxy_resolver_impl_unittest.cc which is now fixed by using scoped_ptrs in that vector. > > BUG=478934 > > Committed: https://crrev.com/a750e126346aa42df1b0cbc2ae6a58abbe7a5069 > Cr-Commit-Position: refs/heads/master@{#377856} [email protected],[email protected] BUG=478934 Review URL: https://codereview.chromium.org/1745133002 Cr-Commit-Position: refs/heads/master@{#378274} (cherry picked from commit 9c8f424) Review URL: https://codereview.chromium.org/1747013002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#8} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

Method which check is settings are synced should check PRIORITY_PREFERENCE instead of PREFERENCE, because only they are synced on mobile devices. BUG=590756 Review URL: https://codereview.chromium.org/1750603002 Cr-Commit-Position: refs/heads/master@{#378238} (cherry picked from commit d2329b1) Review URL: https://codereview.chromium.org/1747003003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#11} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

The pnacl-strip tool does not grok the --strip-unneeded flag that gcc_toolchain.gni uses. Disable stripping for this toolchain for now. It can be reenabled soon after the tool has been updated. BUG= 555741 [email protected], [email protected] Review URL: https://codereview.chromium.org/1451783002 Cr-Commit-Position: refs/heads/master@{#359865} (cherry picked from commit c3dcc79) Review URL: https://codereview.chromium.org/1452723002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#11} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

This CL enables the main frame before activation on the waterfall so that we have adequate coverage while we launch this via Finch. [email protected] BUG=612596 Review-Url: https://codereview.chromium.org/1988413003 Cr-Commit-Position: refs/heads/master@{#395206} (cherry picked from commit 36a7448) Review URL: https://codereview.chromium.org/2000293002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#11} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

Pre-emptively adding more strings for alternate UI. [email protected] (cherry picked from commit d2c811d) Bug: 755524 Change-Id: I680810a9e82bd537b2438fa32867c6aae541846f Reviewed-on: https://chromium-review.googlesource.com/647788 Reviewed-by: Justin Cohen <[email protected]> Commit-Queue: Peter Lee <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499216} Reviewed-on: https://chromium-review.googlesource.com/648465 Reviewed-by: Peter Lee <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#11} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

huningxin and others added 30 commits June 6, 2013 15:35

Add cameo path to git ignore list

64b32e6

Update new path for cameo_resources.grd.

3bb677c

Add "messages" to generate resource id for string.

d8d1dc3

Incrementing VERSION to 28.0.1500.7

6d5d19a

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199309 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

Incrementing VERSION to 28.0.1500.8

aa4af5f

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199323 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

DOCS ONLY: bump server2 to 2-1-0.

9aa9dcb

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199508 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

Incrementing VERSION to 28.0.1500.9

cd9774f

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199579 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

Incrementing VERSION to 28.0.1500.10

197f94f

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199629 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

Incrementing VERSION to 28.0.1500.11

a64a3e7

git-svn-id: http://src.chromium.org/svn/branches/1500/src@199640 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

darktears pushed a commit that referenced this pull request Oct 6, 2014

Incrementing VERSION to 39.0.2171.5

be4b616

Cr-Commit-Position: refs/branch-heads/2171@{#11} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

pozdnyakov mentioned this pull request Jan 14, 2015

[Extensions] Build glib message pump on Ozone by default #225

Merged

smishenk pushed a commit to smishenk/chromium-crosswalk that referenced this pull request Apr 29, 2016

Incrementing VERSION to 49.0.2623.7

4bc72be

Cr-Commit-Position: refs/branch-heads/2623@{crosswalk-project#11} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Touch #11

Touch #11

Uh oh!

junmin-zhu commented Jun 21, 2013

Uh oh!

Uh oh!

Touch #11

Touch #11

Uh oh!

Conversation

junmin-zhu commented Jun 21, 2013

Uh oh!

Uh oh!