Skip to content
This repository was archived by the owner on Apr 3, 2020. It is now read-only.

Commit 7cad352

Browse files
vasiliiCommit bot
vasilii
authored and
Commit bot
committed
Revert of Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) (patchset #1 id:1 of https://codereview.chromium.org/588163003/)
Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289 > > [email protected],[email protected],[email protected] > > Committed: https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede > Cr-Commit-Position: refs/heads/master@{#295950} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/592783002 Cr-Commit-Position: refs/heads/master@{#295962}
1 parent 7dcc80f commit 7cad352

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ vars = {
2727
'libcxx_revision': '48198f9110397fff47fe7c37cbfa296be7d44d3d',
2828
'libcxxabi_revision': '4ad1009ab3a59fa7a6896d74d5e4de5885697f95',
2929
'webkit_trunk': 'http://src.chromium.org/blink/trunk',
30-
'webkit_revision': '0f6e289f3e164d033838c7d4e095b48b996e6797', # from svn revision 182407
30+
'webkit_revision': '08e97a966be8ae4b3442e1171b7cfa425cc09bfb', # from svn revision 182386
3131
'chromium_git': 'https://chromium.googlesource.com',
3232
'chromiumos_git': 'https://chromium.googlesource.com/chromiumos',
3333
'pdfium_git': 'https://pdfium.googlesource.com',

0 commit comments

Comments
 (0)