-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Handle crop_shape=None
in Diffusion Policy
#219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexander-soare
merged 14 commits into
huggingface:main
from
alexander-soare:handle_crop_shape_is_none
May 28, 2024
Merged
Handle crop_shape=None
in Diffusion Policy
#219
alexander-soare
merged 14 commits into
huggingface:main
from
alexander-soare:handle_crop_shape_is_none
May 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliberts
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: Some CI tests are either incomplete or have failed!, all files reviewed, all discussions resolved (waiting on @alexander-soare)
4 tasks
menhguin
pushed a commit
to menhguin/lerobot
that referenced
this pull request
Feb 9, 2025
Kalcy-U
referenced
this pull request
in Kalcy-U/lerobot
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
crop_shape=None
is allowed and it indicates that no cropping should be done, but various places in the code don't handle it. This PR addresses that.How it was tested
I tried to train diffusion policy with default settings but
crop_shape=None
and no exceptions were raised.How to checkout & try? (for the reviewer)
This change is