Do not fetch disconnected Home Connect appliances #142200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: home_connect
small-pr
|
Hey there @DavidMStraub, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
davet2001
approved these changes
Apr 3, 2025
MartinHjelmare
requested changes
Apr 4, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Martin Hjelmare <[email protected]>
frenck
pushed a commit
that referenced
this pull request
Apr 4, 2025
* Do not fetch disconnected Home Connect appliances * Apply suggestions Co-authored-by: Martin Hjelmare <[email protected]> * Update docstring --------- Co-authored-by: Martin Hjelmare <[email protected]>
Merged
frenck
added a commit
that referenced
this pull request
Apr 4, 2025
* Fix blocking event loop - daikin (#141442) * fix blocking event loop * create ssl_context directly * update manifest * update manifest.json * Made Google Search enable dependent on Assist availability (#141712) * Made Google Search enable dependent on Assist availability * Show error instead of rendering again * Cleanup test code * Fix humidifier platform for Comelit (#141854) * Fix humidifier platform for Comelit * apply review comment * Bump evohome-async to 1.0.5 (#141871) bump client to 1.0.5 * Replace "to log into" with "to log in to" in `incomfort` (#142060) * Replace "to log into" with "to log in to" in `incomfort` Also fix one missing sentence-casing of "gateway". * Replace duplicate "data_description" strings with references * Avoid unnecessary reload in apple_tv reauth flow (#142079) * Add translation for hassio update entity name (#142090) * Bump pyenphase to 1.25.5 (#142107) * Hide broken ZBT-1 config entries on the hardware page (#142110) * Hide bad ZBT-1 config entries on the hardware page * Set up the bad config entry in the unit test * Roll into a list comprehension * Remove constant changes * Fix condition in unit test * Bump pysmhi to 1.0.1 (#142111) * Avoid logging a warning when replacing an ignored config entry (#142114) Replacing an ignored config entry with one from the user flow should not generate a warning. We should only warn if we are replacing a usable config entry. Followup to adjust the warning added in #130567 cc @epenet * Slow down polling in Tesla Fleet (#142130) * Slow down polling * Fix tests * Bump tesla-fleet-api to v1.0.17 (#142131) bump * Tado bump to 0.18.11 (#142175) * Bump to version 0.18.11 * Adding hassfest files * Add preset mode to SmartThings climate (#142180) * Add preset mode to SmartThings climate * Add preset mode to SmartThings climate * Do not create a HA mediaplayer for the builtin Music Assistant player (#142192) Do not create a HA mediaplayer for the builtin Music player * Do not fetch disconnected Home Connect appliances (#142200) * Do not fetch disconnected Home Connect appliances * Apply suggestions Co-authored-by: Martin Hjelmare <[email protected]> * Update docstring --------- Co-authored-by: Martin Hjelmare <[email protected]> * Fix fibaro setup (#142201) * Fix circular mean by always storing and using the weighted one (#142208) * Fix circular mean by always storing and using the weighted one * fix * Fix test * Bump pySmartThings to 3.0.2 (#142257) Co-authored-by: Robert Resch <[email protected]> * Update frontend to 20250404.0 (#142274) * Bump forecast-solar lib to v4.1.0 (#142280) Co-authored-by: Jan-Philipp Benecke <[email protected]> * Bump version to 2025.4.1 * Fix skyconnect tests (#142262) fix tests * Fix empty actions (#142292) * Apply fix * Add tests for alarm button cover lock * update light * add number tests * test select * add switch tests * test vacuum * update lock test --------- Co-authored-by: Fredrik Erlandsson <[email protected]> Co-authored-by: Ivan Lopez Hernandez <[email protected]> Co-authored-by: Simone Chemelli <[email protected]> Co-authored-by: David Bonnes <[email protected]> Co-authored-by: Norbert Rittel <[email protected]> Co-authored-by: Erik Montnemery <[email protected]> Co-authored-by: Paul Bottein <[email protected]> Co-authored-by: Arie Catsman <[email protected]> Co-authored-by: puddly <[email protected]> Co-authored-by: G Johansson <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Brett Adams <[email protected]> Co-authored-by: Erwin Douna <[email protected]> Co-authored-by: Joost Lekkerkerker <[email protected]> Co-authored-by: Marcel van der Veldt <[email protected]> Co-authored-by: J. Diego Rodríguez Royo <[email protected]> Co-authored-by: Martin Hjelmare <[email protected]> Co-authored-by: rappenze <[email protected]> Co-authored-by: Robert Resch <[email protected]> Co-authored-by: Bram Kragten <[email protected]> Co-authored-by: Klaas Schoute <[email protected]> Co-authored-by: Jan-Philipp Benecke <[email protected]> Co-authored-by: Josef Zweck <[email protected]> Co-authored-by: Petro31 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The Home Connect integration attempted to fetch appliance settings, status, commands, etc., while the appliance was not connected. This caused the API rate limit error to be triggered if many appliances were disconnected (which can be common as some are disconnected while turned off).
This PR makes the necessary changes to prevent the integration from fetching data for disconnected appliances.
See the following logs for more context (ty @ConradReichel!)
home-assistant_home_connect_2025-04-01T13-36-07.420Z_REDACTED.log
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: