Skip to content

Slow down polling in Tesla Fleet #142130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

Slow down polling in Tesla Fleet #142130

merged 2 commits into from
Apr 4, 2025

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Apr 3, 2025 •
edited
Loading

Proposed change

A previous breakfix change has dramatically increase the polling rate for some users, which is exceeding their $10 in free credits. This PR simply changes the default polling rate to be a more conservative value so less users are impacted by default.

Since users can change the polling rate using automations, the test has been updated to reflect a 2 minute polling interval for the legacy vehicle sleeping edge-case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Tesla Fleet is polling too often #141462
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Bre77 Bre77 marked this pull request as ready for review April 3, 2025 23:13
@frenck frenck added this to the 2025.4.1 milestone Apr 4, 2025
frenck
frenck approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Bre77 👍

../Frenck

@frenck frenck merged commit 8845570 into home-assistant:dev Apr 4, 2025
34 checks passed
frenck pushed a commit that referenced this pull request Apr 4, 2025
@Bre77 @frenck
Slow down polling in Tesla Fleet (#142130)
e5c00ec 
* Slow down polling

* Fix tests
@frenck frenck mentioned this pull request Apr 4, 2025
Merged
frenck added a commit that referenced this pull request Apr 4, 2025
@frenck @fredrike
@IvanLH @chemelli74 @zxdavb @NoRi2909 @emontnemery @piitaya @catsmanac @puddly @gjohansson-ST @bdraco @Bre77 @erwindouna @joostlek @marcelveldt @Diegorro98 @MartinHjelmare @rappenze @edenhaus @bramkragten @klaasnicolaas @jpbede @zweckj @Petro31
2025.4.1 (#142299)
7af6a4f 
* Fix blocking event loop - daikin (#141442)

* fix blocking event loop

* create ssl_context directly

* update manifest

* update manifest.json

* Made Google Search enable dependent on Assist availability (#141712)

* Made Google Search enable dependent on Assist availability

* Show error instead of rendering again

* Cleanup test code

* Fix humidifier platform for Comelit (#141854)

* Fix humidifier platform for Comelit

* apply review comment

* Bump evohome-async to 1.0.5 (#141871)

bump client to 1.0.5

* Replace "to log into" with "to log in to" in `incomfort` (#142060)

* Replace "to log into" with "to log in to" in `incomfort`

Also fix one missing sentence-casing of "gateway".

* Replace duplicate "data_description" strings with references

* Avoid unnecessary reload in apple_tv reauth flow (#142079)

* Add translation for hassio update entity name (#142090)

* Bump pyenphase to 1.25.5 (#142107)

* Hide broken ZBT-1 config entries on the hardware page (#142110)

* Hide bad ZBT-1 config entries on the hardware page

* Set up the bad config entry in the unit test

* Roll into a list comprehension

* Remove constant changes

* Fix condition in unit test

* Bump pysmhi to 1.0.1 (#142111)

* Avoid logging a warning when replacing an ignored config entry (#142114)

Replacing an ignored config entry with one from the user
flow should not generate a warning. We should only warn
if we are replacing a usable config entry.

Followup to adjust the warning added in #130567
cc @epenet

* Slow down polling in Tesla Fleet (#142130)

* Slow down polling

* Fix tests

* Bump tesla-fleet-api to v1.0.17 (#142131)

bump

* Tado bump to 0.18.11 (#142175)

* Bump to version 0.18.11

* Adding hassfest files

* Add preset mode to SmartThings climate (#142180)

* Add preset mode to SmartThings climate

* Add preset mode to SmartThings climate

* Do not create a HA mediaplayer for the builtin Music Assistant player (#142192)

Do not create a HA mediaplayer for the builtin Music player

* Do not fetch disconnected Home Connect appliances (#142200)

* Do not fetch disconnected Home Connect appliances

* Apply suggestions

Co-authored-by: Martin Hjelmare <[email protected]>

* Update docstring

---------

Co-authored-by: Martin Hjelmare <[email protected]>

* Fix fibaro setup (#142201)

* Fix circular mean by always storing and using the weighted one (#142208)

* Fix circular mean by always storing and using the weighted one

* fix

* Fix test

* Bump pySmartThings to 3.0.2 (#142257)

Co-authored-by: Robert Resch <[email protected]>

* Update frontend to 20250404.0 (#142274)

* Bump forecast-solar lib to v4.1.0 (#142280)

Co-authored-by: Jan-Philipp Benecke <[email protected]>

* Bump version to 2025.4.1

* Fix skyconnect tests (#142262)

fix tests

* Fix empty actions (#142292)

* Apply fix

* Add tests for alarm button cover lock

* update light

* add number tests

* test select

* add switch tests

* test vacuum

* update lock test

---------

Co-authored-by: Fredrik Erlandsson <[email protected]>
Co-authored-by: Ivan Lopez Hernandez <[email protected]>
Co-authored-by: Simone Chemelli <[email protected]>
Co-authored-by: David Bonnes <[email protected]>
Co-authored-by: Norbert Rittel <[email protected]>
Co-authored-by: Erik Montnemery <[email protected]>
Co-authored-by: Paul Bottein <[email protected]>
Co-authored-by: Arie Catsman <[email protected]>
Co-authored-by: puddly <[email protected]>
Co-authored-by: G Johansson <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: Brett Adams <[email protected]>
Co-authored-by: Erwin Douna <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: J. Diego Rodríguez Royo <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: rappenze <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Bram Kragten <[email protected]>
Co-authored-by: Klaas Schoute <[email protected]>
Co-authored-by: Jan-Philipp Benecke <[email protected]>
Co-authored-by: Josef Zweck <[email protected]>
Co-authored-by: Petro31 <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: tesla_fleet Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.4.1
Development

Successfully merging this pull request may close these issues.

Tesla Fleet is polling too often
2 participants
@Bre77 @frenck