Skip to content

fix: tokenAssociate throws IndexOutOfBoundsException #12552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JivkoKelchev
Copy link
Contributor

Description:

Addition to #12453

Related issue(s):

Fixes #12440

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@JivkoKelchev JivkoKelchev requested a review from a team April 4, 2024 10:30
@JivkoKelchev JivkoKelchev requested a review from a team as a code owner April 4, 2024 10:30
@JivkoKelchev JivkoKelchev requested review from rbair23 and iwsimon April 4, 2024 10:30
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 36s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 7c61d78.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  18s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit 7c61d78.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Token) Results

207 tests   207 ✅  21m 43s ⏱️
 16 suites    0 💤
 16 files      0 ❌

Results for commit 7c61d78.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Misc) Results

433 tests   422 ✅  39m 8s ⏱️
 75 suites   10 💤
 75 files      1 ❌

For more details on these failures, see this check.

Results for commit 7c61d78.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Crypto) Results

311 tests   311 ✅  39m 32s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 7c61d78.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 27s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 7c61d78.

Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JivkoKelchev

Copy link

github-actions bot commented Apr 4, 2024

Node: Unit Test Results

  2 272 files  ±0    2 272 suites  ±0   3h 31m 7s ⏱️ - 14m 34s
112 215 tests ±0  112 119 ✅ ±0  96 💤 ±0  0 ❌ ±0 
120 697 runs  ±0  120 600 ✅ ±0  97 💤 ±0  0 ❌ ±0 

Results for commit 7c61d78. ± Comparison against base commit 58dfd23.

This pull request removes 3994 and adds 3764 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=31097,hostnameExternal=153.102.166.32,portExternalIpv4=26132,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@1d6ab1f7,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@5c9db50d,memo=cFGaYB6K9B],
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@7c48f41
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@c26f0995
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@4d32d334
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@2441b20e
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@ee3c46c
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@ab65a2b4
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6191a100
…

@JivkoKelchev JivkoKelchev merged commit f500423 into develop Apr 4, 2024
43 of 46 checks passed
@JivkoKelchev JivkoKelchev deleted the 12440-tokenAssociate-throws-IndexOutOfBoundsException branch April 4, 2024 11:49
JivkoKelchev added a commit that referenced this pull request Apr 4, 2024
Signed-off-by: Zhivko Kelchev <[email protected]>
Co-authored-by: Valentin Tronkov <[email protected]>
netopyr added a commit that referenced this pull request Apr 4, 2024
* develop:
  feat: Introduce software update admin (#12489)
  feat: Remove getOtherId (#12465)
  fix: tokenAssociate throws IndexOutOfBoundsException (#12552)
  fix: enable HelloWorldEthereumSuite hapi tests (#11602)
  fix: tokenAssociate throws IndexOutOfBoundsException (#12453)
  fix: treat an out-of-range allowance amount as an invalid op (#12445)
  feat: restrict qualified delegates to appropriate transfer functions only (#12358)
  feat: move the JVM anchor into the wiring model (#12534)
  feat: Automate scheduler construction for the event deduplicator (#12527)
  feat: cleaner wiring for complete state nexus (#12502)
  fix: finalize stake metadata only once per transaction (#12537)
  feat: platform component builder (#12499)
  feat: address book serializes text hostnames (#12515)
  feat: improve bottom half of the wiring diagram (#12511)
  refactor: Migrate some tests to use event test util (#12471)
  test: security v2 model - add test for token associate with callcode (#12168)
  chore: Added extra-checks to prevent unchecked submits (#12436)
  chore: Change owner of DEV configuration (#12523)
  feat: construct schedulers automatically (#12504)
  feat: Cherry-pick: Pass Metrics to created VirtualMaps (#12495)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokenAssociate throws IndexOutOfBoundsException
3 participants