Skip to content

fix: treat an out-of-range allowance amount as an invalid op #12445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2024
Merged

fix: treat an out-of-range allowance amount as an invalid op #12445

merged 3 commits into from
Apr 4, 2024

Conversation

tinker-michaelj
Copy link
Contributor

@tinker-michaelj tinker-michaelj commented Mar 29, 2024 •
edited
Loading

@tinker-michaelj tinker-michaelj requested a review from a team as a code owner March 29, 2024 19:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 51s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 893c0b6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  21s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit 893c0b6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

207 tests   207 ✅  18m 50s ⏱️
 16 suites    0 💤
 16 files      0 ❌

Results for commit 893c0b6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

445 tests   435 ✅  44m 24s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 893c0b6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

310 tests   310 ✅  44m 36s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 893c0b6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 28s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 893c0b6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: Unit Test Results

  2 271 files  ±0    2 271 suites  ±0   2h 11m 24s ⏱️ - 1h 28m 59s
112 208 tests ±0  112 112 ✅ +1  96 💤 ±0  0 ❌  - 1 
120 690 runs  ±0  120 593 ✅ +1  97 💤 ±0  0 ❌  - 1 

Results for commit 893c0b6. ± Comparison against base commit 42e87a9.

This pull request removes 3962 and adds 3732 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@bfce6b9d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8cbd78a5
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@7e68325
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@7e4f6f7a
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@3d343bc7
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@c202a0f6
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@497238e2
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

509 tests   509 ✅  1h 0m 0s ⏱️
 55 suites    0 💤
 55 files      0 ❌

Results for commit 893c0b6.

♻️ This comment has been updated with latest results.

Neeharika-Sompalli
Neeharika-Sompalli approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @tinker-michaelj

lukelee-sl
lukelee-sl approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinker-michaelj tinker-michaelj merged commit e585287 into develop Apr 4, 2024
@tinker-michaelj tinker-michaelj deleted the cherry-pick-12444 branch April 4, 2024 02:05
netopyr added a commit that referenced this pull request Apr 4, 2024
@netopyr
Merge branch 'develop' into 11556-entity-utilization-metrics-cherry-pick
fe902ef 
* develop:
  feat: Introduce software update admin (#12489)
  feat: Remove getOtherId (#12465)
  fix: tokenAssociate throws IndexOutOfBoundsException (#12552)
  fix: enable HelloWorldEthereumSuite hapi tests (#11602)
  fix: tokenAssociate throws IndexOutOfBoundsException (#12453)
  fix: treat an out-of-range allowance amount as an invalid op (#12445)
  feat: restrict qualified delegates to appropriate transfer functions only (#12358)
  feat: move the JVM anchor into the wiring model (#12534)
  feat: Automate scheduler construction for the event deduplicator (#12527)
  feat: cleaner wiring for complete state nexus (#12502)
  fix: finalize stake metadata only once per transaction (#12537)
  feat: platform component builder (#12499)
  feat: address book serializes text hostnames (#12515)
  feat: improve bottom half of the wiring diagram (#12511)
  refactor: Migrate some tests to use event test util (#12471)
  test: security v2 model - add test for token associate with callcode (#12168)
  chore: Added extra-checks to prevent unchecked submits (#12436)
  chore: Change owner of DEV configuration (#12523)
  feat: construct schedulers automatically (#12504)
  feat: Cherry-pick: Pass Metrics to created VirtualMaps (#12495)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@lukelee-sl lukelee-sl lukelee-sl approved these changes

@acuarica acuarica Awaiting requested review from acuarica acuarica was automatically assigned from hashgraph/hedera-smart-contracts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional modular record found at 2024-03-12T08:16:01 (round 165031201)
4 participants
@tinker-michaelj @Neeharika-Sompalli @lukelee-sl @netopyr