Skip to content

fix: tokenAssociate throws IndexOutOfBoundsException #12552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2024
Merged

fix: tokenAssociate throws IndexOutOfBoundsException #12552

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
049b63e
Add check for empty token list
JivkoKelchev Apr 1, 2024
c744e88
Add check for empty token list
JivkoKelchev Apr 1, 2024
198822a
Merge branch 'develop' into 12440-tokenAssociate-throws-IndexOutOfBou…
vtronkov Apr 2, 2024
53d0c3b
match mono behaviour
JivkoKelchev Apr 2, 2024
aa971eb
Spotless
JivkoKelchev Apr 2, 2024
c8be3b6
Merge branch 'develop' into 12440-tokenAssociate-throws-IndexOutOfBou…
JivkoKelchev Apr 4, 2024
7c61d78
Skip linkTokenRels() call if token list is empty
JivkoKelchev Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/BaseTokenHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,12 @@ protected void createAndLinkTokenRels(
@NonNull final WritableTokenRelationStore tokenRelStore) {
// create list of token relations to be added
final var newTokenRels = createTokenRelsToAccount(account, tokens);
// Link the new token relations to the account
linkTokenRels(account, newTokenRels, tokenRelStore);

// FUTURE - We may need to return a proper error status when tokens are empty
if (!newTokenRels.isEmpty()) {
// Link the new token relations to the account
linkTokenRels(account, newTokenRels, tokenRelStore);

// Now replace the account's old head token number with the new head token number. This is
// how we link the new tokenRels to the account
final var firstOfNewTokenRels = newTokenRels.get(0);
Expand Down
Loading