Skip to content

Add InvenioRDM file source template #19619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 17, 2025
Merged

Add InvenioRDM file source template #19619

merged 4 commits into from
Feb 17, 2025

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Feb 14, 2025 •
edited
Loading

Requires #19621 and #19622, extracted on their own PRs to simplify the review

A new file source template for allowing users to integrate their own InvenioRDM instances to import and export data.

user_file_source_form_full_invenio

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez force-pushed the invenio_file_source_template branch from 404babc to 9474938 Compare February 14, 2025 16:48
This was referenced Feb 14, 2025
Merged
Merged
@davelopez davelopez force-pushed the invenio_file_source_template branch from 9474938 to 02c8640 Compare February 17, 2025 08:39
@davelopez davelopez marked this pull request as ready for review February 17, 2025 08:39
@github-actions github-actions bot added this to the 25.0 milestone Feb 17, 2025
kysrpex
kysrpex reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@kysrpex kysrpex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully :)

@kysrpex kysrpex mentioned this pull request Feb 17, 2025
Merged
4 tasks
@davelopez davelopez force-pushed the invenio_file_source_template branch from 31141a2 to c896a28 Compare February 17, 2025 12:44
@davelopez davelopez mentioned this pull request Feb 17, 2025
Merged
4 tasks
@bgruening bgruening merged commit c593be1 into galaxyproject:dev Feb 17, 2025
52 of 56 checks passed
@bgruening
Copy link
Member

Nice, thanks a lot!

@davelopez davelopez deleted the invenio_file_source_template branch February 17, 2025 16:57
@davelopez davelopez mentioned this pull request Mar 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

@kysrpex kysrpex kysrpex approved these changes

Assignees
No one assigned
Labels
area/backend area/UI-UX kind/enhancement
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@davelopez @bgruening @jmchilton @kysrpex