Skip to content

Update eLabFTW file source template docs #19632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Feb 17, 2025

Include the template itself and a screenshot of the form generated by the template in the docs, just like it is done for the other templates.

Follow up of #19493, these docs were missing in the original PR.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Run make docs-develop.
    2. Navigate to file:///home/you/Documents/Repositories/galaxy/doc/build/html/admin/data.html#allow-users-to-define-elabftw-instances-as-file-sources

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Include the template itself and a screenshot of the form generated by the template in the docs, just like it is done for the other templates.
@kysrpex
Copy link
Contributor Author

kysrpex commented Feb 17, 2025

@davelopez I realized this section was missing when reviewing #19619.

@kysrpex kysrpex requested a review from davelopez February 17, 2025 12:15
@kysrpex kysrpex self-assigned this Feb 17, 2025
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davelopez davelopez merged commit 4d10328 into galaxyproject:dev Feb 17, 2025
9 checks passed
@kysrpex kysrpex deleted the elabftw_file_source_template_docs branch February 17, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants