Skip to content

Use correct plugin_kind in user file sources #19622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Feb 14, 2025

Extracted from #19619 to simplify the review

Forcing every user file source to rfs was ok until #19619
Using the correct plugin_kind enables other kinds of file sources like rdm to work as they are supposed and not limited to regular file source logic.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member

Makes good sense to me - thanks for this!

@jmchilton jmchilton merged commit 1a0eb23 into galaxyproject:dev Feb 16, 2025
53 of 58 checks passed
@davelopez davelopez deleted the fix_user_file_sources_plugin_kind branch February 17, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants