Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet in your calendar feature branch #17584

Merged
merged 30 commits into from
Mar 26, 2024
Merged

Fleet in your calendar feature branch #17584

merged 30 commits into from
Mar 26, 2024

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Mar 13, 2024

Checklist for submitter

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 50.81241% with 999 lines in your changes are missing coverage. Please review.

Project coverage is 65.33%. Comparing base (0752993) to head (9861f6e).

Files Patch % Lines
cmd/fleet/calendar_cron.go 45.90% 244 Missing and 20 partials ⚠️
ee/server/calendar/google_calendar.go 64.09% 119 Missing and 16 partials ⚠️
...server/calendar/load_test/calendar_http_handler.go 50.92% 99 Missing and 33 partials ⚠️
server/datastore/mysql/calendar_events.go 38.70% 107 Missing and 7 partials ⚠️
ee/server/calendar/google_calendar_load.go 43.45% 77 Missing and 31 partials ⚠️
...min/IntegrationsPage/cards/Calendars/Calendars.tsx 12.00% 66 Missing ⚠️
server/service/osquery.go 5.79% 64 Missing and 1 partial ⚠️
server/mock/datastore_mock.go 45.45% 30 Missing ⚠️
ee/server/calendar/google_calendar_mock.go 72.54% 13 Missing and 1 partial ⚠️
server/fleet/calendar.go 0.00% 14 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17584      +/-   ##
==========================================
- Coverage   65.67%   65.33%   -0.35%     
==========================================
  Files        1193     1204      +11     
  Lines      108027   110022    +1995     
  Branches     2569     2585      +16     
==========================================
+ Hits        70949    71880     +931     
- Misses      31707    32640     +933     
- Partials     5371     5502     +131     
Flag Coverage Δ
backend 66.33% <52.28%> (-0.35%) ⬇️
frontend 51.46% <15.85%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor force-pushed the 17230-calendar-feature branch from 332c27b to 5da6d50 Compare March 15, 2024 00:15
@getvictor getvictor force-pushed the 17230-calendar-feature branch from dd6c424 to a3118c7 Compare March 19, 2024 17:28
@getvictor getvictor force-pushed the 17230-calendar-feature branch from f5f73da to 16c0fb5 Compare March 25, 2024 12:57
getvictor and others added 18 commits March 26, 2024 13:39
Addresses #17445 

Follow-up iteration:
- Finalize styling of dropdown tooltips
- All `//TODO`s

<img width="1393" alt="Screenshot 2024-03-20 at 1 43 54 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/9b792cf0-058a-4ae6-8f5f-a49eb936ebef">
<img width="1393" alt="Screenshot 2024-03-20 at 1 44 01 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/86195dcf-ec28-4cf0-ab8b-d785d12372ed">
<img width="1393" alt="Screenshot 2024-03-20 at 1 44 21 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/01effdec-ca20-49ec-a442-5fe754a5e12b">
<img width="1393" alt="Screenshot 2024-03-20 at 1 44 26 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/b6de6891-6eae-426e-bbff-b01184094ac9">
<img width="1393" alt="Screenshot 2024-03-20 at 1 44 33 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/96e167dd-752c-4b49-a1a7-69fe9b4f42ac">
<img width="1393" alt="Screenshot 2024-03-20 at 1 44 43 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/feedbda5-e915-4e5e-84ee-2316db49434a">
<img width="1393" alt="Screenshot 2024-03-20 at 1 44 47 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/c4b5ac47-3357-43ef-95ca-dd0953994f6f">
<img width="1393" alt="Screenshot 2024-03-20 at 1 45 02 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/17838415-5bf4-46f0-9bde-522deb0f0886">
<img width="1393" alt="Screenshot 2024-03-20 at 1 45 10 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/b7228484-bb9f-4119-9fbf-a60ce990ba0e">

---------

Co-authored-by: Jacob Shandling <[email protected]>
- Added a calendar server that can be used for load testing at
/tools/calendar
- Fixed minor calendar bugs

# Checklist for submitter
- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
Fix to always create events for next 3rd Tuesday #17441
## Follow-up work to #17717 

**Finalize disabled options and tooltips:**
<img width="697" alt="Screenshot 2024-03-21 at 5 14 40 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/ea5d880f-75f6-48ef-85cc-b807812c9a50">
<img width="697" alt="Screenshot 2024-03-21 at 5 15 13 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/bdd33118-933e-4676-9e1e-680ebcddbc7a">

**Only update policies and settings when there's a diff:**

![1(1)](https://github.com/fleetdm/fleet/assets/61553566/183d1834-3c54-4fef-a208-dfbb0354e507)

**Reorganize onChange handlers, types**

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
Added TestEventForDifferentHost for calendar_cron.
Calendar helper scripts for testing
Adding retry logic when rate limited by Google Calendar API.
@getvictor getvictor marked this pull request as ready for review March 26, 2024 18:48
@getvictor getvictor requested review from a team as code owners March 26, 2024 18:48
@getvictor getvictor merged commit 9bb1610 into main Mar 26, 2024
25 checks passed
@getvictor getvictor deleted the 17230-calendar-feature branch March 26, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants