Fleet UI: Calendar settings iterations #17779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17230-calendar-feature #17779 +/- ##
==========================================================
- Coverage 65.24% 65.23% -0.01%
==========================================================
Files 1202 1202
Lines 109371 109380 +9
Branches 2587 2590 +3
==========================================================
+ Hits 71358 71359 +1
- Misses 32598 32606 +8
Partials 5415 5415
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
commented
Mar 22, 2024
jacobshandling
previously requested changes
Mar 22, 2024
RachelElysia
commented
Mar 22, 2024
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
jacobshandling
approved these changes
Mar 22, 2024
| @@ -58,6 +58,16 @@ interface ICalendarsFormData { | |||
| apiKeyJson?: string; | |||
| } | |||
|
|
|||
| // Used to surface error.message in UI of unknown error type | |||
| type ErrorWithMessage = { | |||
There was a problem hiding this comment.
Nice. This is probably something we can have as a utility type/typeguard for use across the UI.
getvictor
pushed a commit
that referenced
this pull request
Mar 25, 2024
getvictor
pushed a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Iteration of #17444
Description
Screenrecording
https://www.loom.com/share/e22095de4a7a44e69a155f11f08c1878?sid=1d1e0285-d96c-4281-9586-2ae742b10c65
Checklist for submitter
If some of the following don't apply, delete the relevant line.