Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar helper scripts for testing #17798

Merged

Conversation

getvictor
Copy link
Member

Calendar helper scripts for testing

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.16%. Comparing base (794a322) to head (b49a049).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           17230-calendar-feature   #17798      +/-   ##
==========================================================
- Coverage                   65.16%   65.16%   -0.01%     
==========================================================
  Files                        1204     1204              
  Lines                      109907   109902       -5     
  Branches                     2587     2587              
==========================================================
- Hits                        71626    71620       -6     
- Misses                      32801    32802       +1     
  Partials                     5480     5480              
Flag Coverage Δ
backend 66.15% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor marked this pull request as ready for review March 22, 2024 17:16
@getvictor getvictor requested a review from a team as a code owner March 22, 2024 17:16

numberMoved := 0
for {
list, err := service.Events.List("primary").EventTypes("default").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this only list future events? It could be lengthy is a user has a long calendar history.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is filtered by eventTitle: Q(eventTitle) and returns a max of 1000 results MaxResults(1000)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on second thought, a non-issue for loadtesting

@getvictor getvictor merged commit e62a039 into 17230-calendar-feature Mar 22, 2024
14 checks passed
@getvictor getvictor deleted the victor/17230-calendar-helper-scripts branch March 22, 2024 19:29
getvictor added a commit that referenced this pull request Mar 25, 2024
Calendar helper scripts for testing
getvictor added a commit that referenced this pull request Mar 26, 2024
Calendar helper scripts for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants