[22604] Filter interested readers on PDP writer #5604

MiguelCompany · 2025-01-28T11:50:44Z

Description

This fixes a high CPU and network usage situation with PDP simple discovery when a new participant is created in a network where there is a high number of existing participants.

@Mergifyio backport 3.1.x 3.0.x
An ABI compatible backport would be manually done to 2.14.x, and we will backport to other 2.x supported branches from there.

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

test/blackbox/common/BlackboxTestsDiscovery.cpp

Signed-off-by: Miguel Company <[email protected]>

…d of an `std::set` Signed-off-by: Miguel Company <[email protected]>

MiguelCompany · 2025-02-18T14:26:13Z

BlackboxTests_DDS_PIM.DDSMonitorServiceTest.monitor_service_advanced_multiple_late_joiners failed twice in a row on Windows. Will investigate.

Reducing announcement period to improve discovery timing. Signed-off-by: Miguel Company <[email protected]>

MiguelCompany · 2025-02-21T09:14:45Z

@Mergifyio backport 3.1.x

mergify · 2025-02-21T09:15:03Z

backport 3.1.x

✅ Backports have been created

#5657 [22604] Filter interested readers on PDP writer (backport #5604) has been created for branch 3.1.x

* Refs #22506. Regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Add `PDPStatelessWriter` extending `StatelessWriter` Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Use `PDPStatelessWriter` in `SimplePDPEndpoints` Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Move specific API to `PDPStatelessWriter`. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Initial work on management of interested writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Take advantage of single sample history. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Reset state after sending datagram. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Filter interested readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Do not reset unsent changes upon participant discovery. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Fix AsymmeticIgnoreParticipantFlags test. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Create sender resources for matched readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22708. Rename methods. Signed-off-by: Miguel Company <[email protected]> * Refs #22708. Avoid allocations using a `ResourceLimitedVector` instead of an `std::set` Signed-off-by: Miguel Company <[email protected]> * Refs #22604. Improve monitor service blackbox tests. Reducing announcement period to improve discovery timing. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 8eb1072)

* Refs #22506. Regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Add `PDPStatelessWriter` extending `StatelessWriter` Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Use `PDPStatelessWriter` in `SimplePDPEndpoints` Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Move specific API to `PDPStatelessWriter`. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Initial work on management of interested writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Take advantage of single sample history. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Reset state after sending datagram. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Filter interested readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Do not reset unsent changes upon participant discovery. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Fix AsymmeticIgnoreParticipantFlags test. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Create sender resources for matched readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22708. Rename methods. Signed-off-by: Miguel Company <[email protected]> * Refs #22708. Avoid allocations using a `ResourceLimitedVector` instead of an `std::set` Signed-off-by: Miguel Company <[email protected]> * Refs #22604. Improve monitor service blackbox tests. Reducing announcement period to improve discovery timing. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 8eb1072) Co-authored-by: Miguel Company <[email protected]>

* Refs #22506. Regression test. Signed-off-by: Eugenio Collado <[email protected]> * Refs #22506. Filter interested readers on PDP writer Signed-off-by: Eugenio Collado <[email protected]> * Fix IncompatibleQosGetters Signed-off-by: Eugenio Collado <[email protected]> * Fix PubSubParticipant rtps deprecated Signed-off-by: Eugenio Collado <[email protected]> --------- Signed-off-by: Eugenio Collado <[email protected]>

* Refs #22506. Regression test. Signed-off-by: Eugenio Collado <[email protected]> * Refs #22506. Filter interested readers on PDP writer Signed-off-by: Eugenio Collado <[email protected]> * Fix IncompatibleQosGetters Signed-off-by: Eugenio Collado <[email protected]> * Fix PubSubParticipant rtps deprecated Signed-off-by: Eugenio Collado <[email protected]> --------- Signed-off-by: Eugenio Collado <[email protected]> (cherry picked from commit b56b56a) # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # test/blackbox/api/fastrtps_deprecated/PubSubParticipant.hpp # test/blackbox/common/DDSBlackboxTestsMonitorService.cpp # test/unittest/statistics/dds/CMakeLists.txt

* Refs #22506. Regression test. Signed-off-by: Eugenio Collado <[email protected]> * Refs #22506. Filter interested readers on PDP writer Signed-off-by: Eugenio Collado <[email protected]> * Fix IncompatibleQosGetters Signed-off-by: Eugenio Collado <[email protected]> * Fix PubSubParticipant rtps deprecated Signed-off-by: Eugenio Collado <[email protected]> --------- Manual conflicts resolution from commit b56b56a Signed-off-by: Eugenio Collado <[email protected]>

* Refs #22506. Regression test. * Refs #22506. Filter interested readers on PDP writer * Fix IncompatibleQosGetters * Fix PubSubParticipant rtps deprecated --------- Manual conflicts resolution from commit b56b56a Signed-off-by: Eugenio Collado <[email protected]> Co-authored-by: Eugenio Collado <[email protected]>

MiguelCompany requested a review from richiware January 28, 2025 11:50

github-actions bot added the ci-pending PR which CI is running label Jan 28, 2025

MiguelCompany force-pushed the bugfix/22708 branch from 51ae465 to c92ada1 Compare January 28, 2025 12:09

MiguelCompany requested review from richiware and removed request for richiware January 28, 2025 12:09

MiguelCompany force-pushed the bugfix/22708 branch 2 times, most recently from 490687a to 633530a Compare January 28, 2025 15:44

MiguelCompany added this to the v3.2.0 milestone Jan 28, 2025

MiguelCompany requested review from richiware and removed request for richiware January 28, 2025 19:08

richiware requested changes Jan 29, 2025

View reviewed changes

test/blackbox/common/BlackboxTestsDiscovery.cpp Show resolved Hide resolved

MiguelCompany added 13 commits February 14, 2025 13:17

Refs #22506. Regression test.

88bc430

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Add PDPStatelessWriter extending StatelessWriter

b9090eb

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Use PDPStatelessWriter in SimplePDPEndpoints

dcd9b7f

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Move specific API to PDPStatelessWriter.

70df4f6

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Initial work on management of interested writers.

24e24ca

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Take advantage of single sample history.

af6ee75

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Reset state after sending datagram.

ff4ec6d

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Filter interested readers.

0d48e68

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Do not reset unsent changes upon participant discovery.

e9ce4d8

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Fix AsymmeticIgnoreParticipantFlags test.

21cf4f9

Signed-off-by: Miguel Company <[email protected]>

Refs #22506. Create sender resources for matched readers.

c94975d

Signed-off-by: Miguel Company <[email protected]>

Refs #22708. Rename methods.

8c7fc72

Signed-off-by: Miguel Company <[email protected]>

Refs #22708. Avoid allocations using a ResourceLimitedVector instea…

44f0324

…d of an `std::set` Signed-off-by: Miguel Company <[email protected]>

MiguelCompany force-pushed the bugfix/22708 branch from 372df3c to 44f0324 Compare February 14, 2025 12:17

MiguelCompany requested a review from richiware February 14, 2025 12:17

richiware previously approved these changes Feb 18, 2025

View reviewed changes

MiguelCompany dismissed richiware’s stale review via b2cd803 February 19, 2025 10:45

MiguelCompany requested a review from richiware February 19, 2025 10:45

Refs #22604. Improve monitor service blackbox tests.

92413c5

Reducing announcement period to improve discovery timing. Signed-off-by: Miguel Company <[email protected]>

MiguelCompany force-pushed the bugfix/22708 branch from b2cd803 to 92413c5 Compare February 20, 2025 06:51

MiguelCompany requested review from richiprosima and removed request for richiprosima February 20, 2025 07:03

richiware approved these changes Feb 20, 2025

View reviewed changes

MiguelCompany merged commit 8eb1072 into master Feb 21, 2025
17 checks passed

MiguelCompany deleted the bugfix/22708 branch February 21, 2025 09:14

mergify bot mentioned this pull request Feb 21, 2025

[22604] Filter interested readers on PDP writer (backport #5604) #5657

Merged

13 tasks

EugenioCollado mentioned this pull request Feb 28, 2025

[22710] Filter interested readers on PDP writer (backport #5604) #5672

Merged

13 tasks

MiguelCompany mentioned this pull request Mar 7, 2025

CPU overloads during the PDP phase with multiple Domain Participants using Simple Discovery #5519

Open

1 task

mergify bot mentioned this pull request Mar 17, 2025

[22710] Filter interested readers on PDP writer (backport #5604) (backport #5672) #5709

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22604] Filter interested readers on PDP writer #5604

[22604] Filter interested readers on PDP writer #5604

MiguelCompany commented Jan 28, 2025 •

edited

Loading

MiguelCompany commented Feb 18, 2025

MiguelCompany commented Feb 21, 2025

mergify bot commented Feb 21, 2025 •

edited

Loading

[22604] Filter interested readers on PDP writer #5604

[22604] Filter interested readers on PDP writer #5604

Conversation

MiguelCompany commented Jan 28, 2025 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

MiguelCompany commented Feb 18, 2025

MiguelCompany commented Feb 21, 2025

mergify bot commented Feb 21, 2025 • edited Loading

✅ Backports have been created

MiguelCompany commented Jan 28, 2025 •

edited

Loading

mergify bot commented Feb 21, 2025 •

edited

Loading