Skip to content

[22710] Filter interested readers on PDP writer (backport #5604) #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

[22710] Filter interested readers on PDP writer (backport #5604) #5672

merged 4 commits into from
Mar 17, 2025

Conversation

EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Feb 28, 2025 •
edited by MiguelCompany
Loading

Description

Manual backport ABI compatible from: #5604

This fixes a high CPU and network usage situation with PDP simple discovery when a new participant is created in a network where there is a high number of existing participants.

@Mergifyio backport 2.10x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • NA New feature has been added to the versions.md file (if applicable).
  • NA New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado EugenioCollado added this to the v2.14.5 milestone Feb 28, 2025
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Feb 28, 2025
@EugenioCollado EugenioCollado changed the base branch from master to 2.14.x February 28, 2025 12:49
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima March 5, 2025 10:13
@MiguelCompany
Copy link
Member

@richiprosima Please check style

MiguelCompany
MiguelCompany requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix uncrustify

@MiguelCompany MiguelCompany changed the title [22604] Filter interested readers on PDP writer (backport #5604) [22710] Filter interested readers on PDP writer (backport #5604) Mar 5, 2025
@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Mar 13, 2025
@EugenioCollado EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from 3d3b64c to c740c5d Compare March 13, 2025 09:37
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 13, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 13, 2025 09:38
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 13, 2025
@EugenioCollado
Fix IncompatibleQosGetters
3a48940 
Signed-off-by: Eugenio Collado <[email protected]>
@EugenioCollado EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch 3 times, most recently from 1eb5249 to d8dca0f Compare March 13, 2025 14:54
@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Mar 13, 2025
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima March 13, 2025 14:57
@EugenioCollado EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from d8dca0f to 967b37b Compare March 13, 2025 15:54
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 13, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 13, 2025 15:56
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 13, 2025
@EugenioCollado EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from 967b37b to 825b55b Compare March 14, 2025 07:05
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 14, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 14, 2025 07:12
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 14, 2025
@EugenioCollado EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from 825b55b to adc3c05 Compare March 14, 2025 08:35
@EugenioCollado EugenioCollado force-pushed the manual-bp/2.14.x/pr-5604 branch from adc3c05 to 607006d Compare March 14, 2025 08:38
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 14, 2025
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima March 14, 2025 08:42
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 14, 2025
MiguelCompany
MiguelCompany approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit b56b56a into 2.14.x Mar 17, 2025
17 of 18 checks passed
@MiguelCompany MiguelCompany deleted the manual-bp/2.14.x/pr-5604 branch March 17, 2025 09:01
@MiguelCompany
Copy link
Member

MiguelCompany commented Mar 17, 2025 •
edited
Loading

@Mergifyio backport 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 17, 2025 •
edited
Loading

backport 2.10.x

✅ Backports have been created

@eProsima eProsima deleted a comment from mergify bot Mar 17, 2025
mergify bot pushed a commit that referenced this pull request Mar 17, 2025
@EugenioCollado @mergify
Filter interested readers on PDP writer (#5604) (#5672)
b1407e9 
* Refs #22506. Regression test.

Signed-off-by: Eugenio Collado <[email protected]>

* Refs #22506. Filter interested readers on PDP writer

Signed-off-by: Eugenio Collado <[email protected]>

* Fix IncompatibleQosGetters

Signed-off-by: Eugenio Collado <[email protected]>

* Fix PubSubParticipant rtps deprecated

Signed-off-by: Eugenio Collado <[email protected]>

---------

Signed-off-by: Eugenio Collado <[email protected]>
(cherry picked from commit b56b56a)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.cpp
#	test/blackbox/api/fastrtps_deprecated/PubSubParticipant.hpp
#	test/blackbox/common/DDSBlackboxTestsMonitorService.cpp
#	test/unittest/statistics/dds/CMakeLists.txt
@mergify mergify bot mentioned this pull request Mar 17, 2025
Merged
13 tasks
EugenioCollado added a commit that referenced this pull request Mar 17, 2025
@EugenioCollado
Filter interested readers on PDP writer (#5604) (#5672)
99b8eb0 
* Refs #22506. Regression test.

Signed-off-by: Eugenio Collado <[email protected]>

* Refs #22506. Filter interested readers on PDP writer

Signed-off-by: Eugenio Collado <[email protected]>

* Fix IncompatibleQosGetters

Signed-off-by: Eugenio Collado <[email protected]>

* Fix PubSubParticipant rtps deprecated

Signed-off-by: Eugenio Collado <[email protected]>

---------

Manual conflicts resolution from  commit b56b56a

Signed-off-by: Eugenio Collado <[email protected]>
MiguelCompany pushed a commit that referenced this pull request May 14, 2025
@EugenioCollado @MiguelCompany
Filter interested readers on PDP writer (#5604) (#5672)
e4d02be 
* Refs #22506. Regression test.

Signed-off-by: Eugenio Collado <[email protected]>

* Refs #22506. Filter interested readers on PDP writer

Signed-off-by: Eugenio Collado <[email protected]>

* Fix IncompatibleQosGetters

Signed-off-by: Eugenio Collado <[email protected]>

* Fix PubSubParticipant rtps deprecated

Signed-off-by: Eugenio Collado <[email protected]>

---------

Manual conflicts resolution from  commit b56b56a

Signed-off-by: Eugenio Collado <[email protected]>
MiguelCompany pushed a commit that referenced this pull request May 16, 2025
@EugenioCollado @MiguelCompany
Filter interested readers on PDP writer (#5604) (#5672)
dc0b7b0 
* Refs #22506. Regression test.

Signed-off-by: Eugenio Collado <[email protected]>

* Refs #22506. Filter interested readers on PDP writer

Signed-off-by: Eugenio Collado <[email protected]>

* Fix IncompatibleQosGetters

Signed-off-by: Eugenio Collado <[email protected]>

* Fix PubSubParticipant rtps deprecated

Signed-off-by: Eugenio Collado <[email protected]>

---------

Manual conflicts resolution from  commit b56b56a

Signed-off-by: Eugenio Collado <[email protected]>
MiguelCompany pushed a commit that referenced this pull request May 16, 2025
@EugenioCollado @MiguelCompany
Filter interested readers on PDP writer (#5604) (#5672)
3ce0e77 
* Refs #22506. Regression test.

Signed-off-by: Eugenio Collado <[email protected]>

* Refs #22506. Filter interested readers on PDP writer

Signed-off-by: Eugenio Collado <[email protected]>

* Fix IncompatibleQosGetters

Signed-off-by: Eugenio Collado <[email protected]>

* Fix PubSubParticipant rtps deprecated

Signed-off-by: Eugenio Collado <[email protected]>

---------

Manual conflicts resolution from  commit b56b56a

Signed-off-by: Eugenio Collado <[email protected]>
MiguelCompany pushed a commit that referenced this pull request May 16, 2025
@mergify @EugenioCollado
Filter interested readers on PDP writer (#5604) (#5672) (#5709)
6085dbb 
* Refs #22506. Regression test.



* Refs #22506. Filter interested readers on PDP writer



* Fix IncompatibleQosGetters



* Fix PubSubParticipant rtps deprecated



---------

Manual conflicts resolution from  commit b56b56a

Signed-off-by: Eugenio Collado <[email protected]>
Co-authored-by: Eugenio Collado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.14.5
Development

Successfully merging this pull request may close these issues.
2 participants
@EugenioCollado @MiguelCompany