Skip to content

[21745] Add QoS getters from raw XML #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2024
Merged

[21745] Add QoS getters from raw XML #928

merged 3 commits into from
Oct 9, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

Description

Update documentation covering new API: eProsima/Fast-DDS#5256

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@juanlofer-eprosima juanlofer-eprosima mentioned this pull request Oct 8, 2024
Merged
15 tasks
@juanlofer-eprosima
Refs #21745. Update documentation
d844768 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@juanlofer-eprosima
Refs #21745. Remove collapse option
573e504 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@rsanchez15 rsanchez15 self-requested a review October 9, 2024 09:10
@juanlofer-eprosima juanlofer-eprosima requested review from rsanchez15 and removed request for rsanchez15 October 9, 2024 09:30
@rsanchez15 rsanchez15 added this to the v3.1.0 milestone Oct 9, 2024
@juanlofer-eprosima juanlofer-eprosima merged commit fab21b5 into master Oct 9, 2024
4 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/get-qos-from-xml branch October 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany left review comments

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juanlofer-eprosima @rsanchez15 @MiguelCompany