Removed PROTOTYPE comments in features/UserDefinedCompoundAssignment #78389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
AlekseyTs
reviewed
Apr 30, 2025
| @@ -2399,7 +2399,7 @@ internal enum ErrorCode | |||
| ERR_ExtensionTypeNameDisallowed = 9306, | |||
| ERR_ExpressionTreeContainsNamedArgumentOutOfPosition = 9307, | |||
|
|
|||
| ERR_OperatorsMustBePublic = 9501, // PROTOTYPE: Pack numbers | |||
AlekseyTs
reviewed
Apr 30, 2025
| @@ -304,7 +304,7 @@ internal enum MessageID | |||
| IDS_FeatureExpressionOptionalAndNamedArguments = MessageBase + 12855, | |||
| IDS_CollectionExpression = MessageBase + 12856, | |||
|
|
|||
| IDS_FeatureUserDefinedCompoundAssignmentOperators = MessageBase + 12901, // PROTOTYPE: Pack numbers | |||
akhera99
commented
Apr 30, 2025
| @@ -154,7 +154,7 @@ class A | |||
| Await TestAPIAndFeature(input, kind, host) | |||
| End Function | |||
|
|
|||
| <WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work | |||
There was a problem hiding this comment.
should the tests be unskipped @AlekseyTs ?
There was a problem hiding this comment.
should the tests be unskipped
If they don't fail, that would be the right thing to do. Otherwise, these are IDE tests, so consider utilizing whatever system you use to tracked skipped tests. Compiler team usually opens an issue and places the link as Skip:= value, plus WorkItem attribute.
There was a problem hiding this comment.
I'll add tracking items in a follow-up
akhera99
merged commit 2c7fea2
into
dotnet:features/UserDefinedCompoundAssignment
21 of 25 checks passed
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.