Skip to content

Commit 2c7fea2

Browse files
akhera99akhera99
authored
Removed PROTOTYPE comments in features/UserDefinedCompoundAssignment (#78389)
* removed PROTOTYPE * revert
1 parent 1843ac5 commit 2c7fea2

File tree

3 files changed

+22
-30
lines changed

3 files changed

+22
-30
lines changed

‎src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.CSharp.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,6 @@ public class C
745745
public void operator [|{{op}}|]();
746746
}
747747
""",
748-
// PROTOTYPE: Not sure whether 'CompilerFeatureRequired' attribute is expected
749748
false => $$"""
750749
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
751750
// {{CodeAnalysisResources.InMemoryAssembly}}
@@ -796,7 +795,6 @@ public class C
796795
public void operator {{op}}();
797796
}
798797
""",
799-
// PROTOTYPE: Not sure whether 'CompilerFeatureRequired' attribute is expected
800798
false => $$"""
801799
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
802800
// {{CodeAnalysisResources.InMemoryAssembly}}
@@ -851,7 +849,6 @@ public class C
851849
public void operator [|{{op}}|](int x);
852850
}
853851
""",
854-
// PROTOTYPE: Expected an operator declaration syntax
855852
false => $$"""
856853
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
857854
// {{CodeAnalysisResources.InMemoryAssembly}}
@@ -915,7 +912,6 @@ public class C
915912
public void operator {{op}}(int x);
916913
}
917914
""",
918-
// PROTOTYPE: Expected an operator declaration syntax
919915
false => $$"""
920916
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
921917
// {{CodeAnalysisResources.InMemoryAssembly}}

‎src/EditorFeatures/Test2/FindReferences/FindReferencesTests.OperatorSymbols.vb

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class A
154154
Await TestAPIAndFeature(input, kind, host)
155155
End Function
156156

157-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
157+
<WpfTheory(Skip:="Yes"), CombinatorialData>
158158
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
159159
Dim input =
160160
<Workspace>
@@ -175,7 +175,7 @@ class A
175175
Await TestAPIAndFeature(input, kind, host)
176176
End Function
177177

178-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
178+
<WpfTheory(Skip:="Yes"), CombinatorialData>
179179
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators_Checked(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=")> op As String) As Task
180180
Dim input =
181181
<Workspace>
@@ -286,7 +286,7 @@ class A
286286
Await TestAPIAndFeature(input, kind, host)
287287
End Function
288288

289-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
289+
<WpfTheory(Skip:="Yes"), CombinatorialData>
290290
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators_FromDefinition(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
291291
Dim input =
292292
<Workspace>
@@ -307,7 +307,7 @@ class A
307307
Await TestAPIAndFeature(input, kind, host)
308308
End Function
309309

310-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
310+
<WpfTheory(Skip:="Yes"), CombinatorialData>
311311
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators_FromDefinition_Checked(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=")> op As String) As Task
312312
Dim input =
313313
<Workspace>
@@ -703,8 +703,6 @@ class A
703703
</Project>
704704
</Workspace>
705705
Await TestAPIAndFeature(input, kind, host)
706-
707-
' PROTOTYPE: Do we need similar tests for instance increment/compound assignment operators?
708706
End Function
709707

710708
<WpfTheory, CombinatorialData>
@@ -922,7 +920,7 @@ class C4_2 : I4<C4_2>
922920
Await TestAPIAndFeature(input, kind, host)
923921
End Function
924922

925-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
923+
<WpfTheory(Skip:="Yes"), CombinatorialData>
926924
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface(kind As TestKind, host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
927925
Dim input =
928926
<Workspace>
@@ -949,7 +947,7 @@ class C4_2 : I4<C4_2>
949947
Await TestAPIAndFeature(input, kind, host)
950948
End Function
951949

952-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
950+
<WpfTheory(Skip:="Yes"), CombinatorialData>
953951
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface(kind As TestKind, host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
954952
Dim input =
955953
<Workspace>
@@ -976,7 +974,7 @@ class C4_2 : I4<C4_2>
976974
Await TestAPIAndFeature(input, kind, host)
977975
End Function
978976

979-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
977+
<WpfTheory(Skip:="Yes"), CombinatorialData>
980978
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
981979
Dim input =
982980
<Workspace>
@@ -1084,7 +1082,7 @@ class C4_2 : I4<C4_2>
10841082
Await TestAPI(input, host)
10851083
End Function
10861084

1087-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1085+
<WpfTheory(Skip:="Yes"), CombinatorialData>
10881086
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface_ViaApi(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
10891087
Dim input =
10901088
<Workspace>
@@ -1111,7 +1109,7 @@ class C4_2 : I4<C4_2>
11111109
Await TestAPI(input, host)
11121110
End Function
11131111

1114-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1112+
<WpfTheory(Skip:="Yes"), CombinatorialData>
11151113
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface_ViaApi(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
11161114
Dim input =
11171115
<Workspace>
@@ -1138,7 +1136,7 @@ class C4_2 : I4<C4_2>
11381136
Await TestAPI(input, host)
11391137
End Function
11401138

1141-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1139+
<WpfTheory(Skip:="Yes"), CombinatorialData>
11421140
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface_ViaApi(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
11431141
Dim input =
11441142
<Workspace>
@@ -1219,7 +1217,7 @@ class C4_2 : I4<C4_2>
12191217
Await TestStreamingFeature(input, host)
12201218
End Function
12211219

1222-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1220+
<WpfTheory(Skip:="Yes"), CombinatorialData>
12231221
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface_ViaFeature_1(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
12241222
Dim input =
12251223
<Workspace>
@@ -1246,7 +1244,7 @@ class C4_2 : I4<C4_2>
12461244
Await TestStreamingFeature(input, host)
12471245
End Function
12481246

1249-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1247+
<WpfTheory(Skip:="Yes"), CombinatorialData>
12501248
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface_ViaFeature_1(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
12511249
Dim input =
12521250
<Workspace>
@@ -1273,7 +1271,7 @@ class C4_2 : I4<C4_2>
12731271
Await TestStreamingFeature(input, host)
12741272
End Function
12751273

1276-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1274+
<WpfTheory(Skip:="Yes"), CombinatorialData>
12771275
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface_ViaFeature_1(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
12781276
Dim input =
12791277
<Workspace>
@@ -1525,7 +1523,7 @@ class C4_2 : I4<C4_2>
15251523
Await TestStreamingFeature(input, host)
15261524
End Function
15271525

1528-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1526+
<WpfTheory(Skip:="Yes"), CombinatorialData>
15291527
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface_ViaFeature_2(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
15301528
Dim input =
15311529
<Workspace>
@@ -1552,7 +1550,7 @@ class C4_2 : I4<C4_2>
15521550
Await TestStreamingFeature(input, host)
15531551
End Function
15541552

1555-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1553+
<WpfTheory(Skip:="Yes"), CombinatorialData>
15561554
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface_ViaFeature_2(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
15571555
Dim input =
15581556
<Workspace>
@@ -1579,7 +1577,7 @@ class C4_2 : I4<C4_2>
15791577
Await TestStreamingFeature(input, host)
15801578
End Function
15811579

1582-
<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
1580+
<WpfTheory(Skip:="Yes"), CombinatorialData>
15831581
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface_ViaFeature_2(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
15841582
Dim input =
15851583
<Workspace>

‎src/EditorFeatures/Test2/GoToImplementation/GoToImplementationTests.vb

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ class D : C
456456
Await TestAsync(workspace, host)
457457
End Function
458458

459-
<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
459+
<Theory(Skip:="Yes"), CombinatorialData>
460460
Public Async Function TestWithOverridableInstanceIncrementOperatorsOnBase(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
461461
Dim workspace =
462462
<Workspace>
@@ -478,7 +478,7 @@ class D : C
478478
Await TestAsync(workspace, host)
479479
End Function
480480

481-
<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
481+
<Theory(Skip:="Yes"), CombinatorialData>
482482
Public Async Function TestWithOverridableInstanceCompoundAssignmentOperatorsOnBase(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
483483
Dim workspace =
484484
<Workspace>
@@ -524,7 +524,7 @@ class D : C
524524
Await TestAsync(workspace, host)
525525
End Function
526526

527-
<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
527+
<Theory(Skip:="Yes"), CombinatorialData>
528528
Public Async Function TestWithOverridableInstanceIncrementOperatorsOnImplementation(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
529529
' Our philosophy is to only show derived in this case
530530
Dim workspace =
@@ -547,7 +547,7 @@ class D : C
547547
Await TestAsync(workspace, host)
548548
End Function
549549

550-
<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
550+
<Theory(Skip:="Yes"), CombinatorialData>
551551
Public Async Function TestWithOverridableInstanceCompoundAssignmentOperatorsOnImplementation(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
552552
' Our philosophy is to only show derived in this case
553553
Dim workspace =
@@ -595,8 +595,6 @@ class D : C
595595
</Workspace>
596596

597597
Await TestAsync(workspace, host)
598-
599-
' PROTOTYPE: Test similar scenarios for instance operators
600598
End Function
601599

602600
<Theory, CombinatorialData>
@@ -850,7 +848,7 @@ interface I&lt;T&gt; { abstract void operator checked $$<%= op %>(); }
850848
Await TestAsync(workspace, host)
851849
End Function
852850

853-
<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
851+
<Theory(Skip:="Yes"), CombinatorialData>
854852
Public Async Function TestInstanceCompoundAssignmentOperatorsImplementation_01(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
855853
Dim workspace =
856854
<Workspace>
@@ -910,7 +908,7 @@ interface I&lt;T&gt; { abstract void operator checked $$<%= op %>(); }
910908
Await TestAsync(workspace, host)
911909
End Function
912910

913-
<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
911+
<Theory(Skip:="Yes"), CombinatorialData>
914912
Public Async Function TestInstanceCompoundAssignmentOperatorsImplementation_02(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
915913
Dim workspace =
916914
<Workspace>

0 commit comments

Comments
 (0)