Skip to content

Removed PROTOTYPE comments in features/UserDefinedCompoundAssignment #78389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Removed PROTOTYPE comments in features/UserDefinedCompoundAssignment #78389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20fe0fb
removed PROTOTYPE
akhera99 Apr 30, 2025
a6c306e
revert
akhera99 Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.CSharp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,6 @@ public class C
public void operator [|{{op}}|]();
}
""",
// PROTOTYPE: Not sure whether 'CompilerFeatureRequired' attribute is expected
false => $$"""
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
// {{CodeAnalysisResources.InMemoryAssembly}}
Expand Down Expand Up @@ -796,7 +795,6 @@ public class C
public void operator {{op}}();
}
""",
// PROTOTYPE: Not sure whether 'CompilerFeatureRequired' attribute is expected
false => $$"""
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
// {{CodeAnalysisResources.InMemoryAssembly}}
Expand Down Expand Up @@ -851,7 +849,6 @@ public class C
public void operator [|{{op}}|](int x);
}
""",
// PROTOTYPE: Expected an operator declaration syntax
false => $$"""
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
// {{CodeAnalysisResources.InMemoryAssembly}}
Expand Down Expand Up @@ -915,7 +912,6 @@ public class C
public void operator {{op}}(int x);
}
""",
// PROTOTYPE: Expected an operator declaration syntax
false => $$"""
#region {{FeaturesResources.Assembly}} ReferencedAssembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
// {{CodeAnalysisResources.InMemoryAssembly}}
Expand Down
34 changes: 16 additions & 18 deletions src/EditorFeatures/Test2/FindReferences/FindReferencesTests.OperatorSymbols.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class A
Await TestAPIAndFeature(input, kind, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the tests be unskipped @AlekseyTs ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the tests be unskipped

If they don't fail, that would be the right thing to do. Otherwise, these are IDE tests, so consider utilizing whatever system you use to tracked skipped tests. Compiler team usually opens an issue and places the link as Skip:= value, plus WorkItem attribute.

Copy link
Member Author

@akhera99 akhera99 Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add tracking items in a follow-up

<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -175,7 +175,7 @@ class A
Await TestAPIAndFeature(input, kind, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators_Checked(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=")> op As String) As Task
Dim input =
<Workspace>
Expand Down Expand Up @@ -286,7 +286,7 @@ class A
Await TestAPIAndFeature(input, kind, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators_FromDefinition(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -307,7 +307,7 @@ class A
Await TestAPIAndFeature(input, kind, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpFindReferencesOnInstanceCompoundAssignmentOperators_FromDefinition_Checked(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=")> op As String) As Task
Dim input =
<Workspace>
Expand Down Expand Up @@ -703,8 +703,6 @@ class A
</Project>
</Workspace>
Await TestAPIAndFeature(input, kind, host)

' PROTOTYPE: Do we need similar tests for instance increment/compound assignment operators?
End Function

<WpfTheory, CombinatorialData>
Expand Down Expand Up @@ -922,7 +920,7 @@ class C4_2 : I4<C4_2>
Await TestAPIAndFeature(input, kind, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface(kind As TestKind, host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -949,7 +947,7 @@ class C4_2 : I4<C4_2>
Await TestAPIAndFeature(input, kind, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface(kind As TestKind, host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -976,7 +974,7 @@ class C4_2 : I4<C4_2>
Await TestAPIAndFeature(input, kind, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface(kind As TestKind, host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim input =
<Workspace>
Expand Down Expand Up @@ -1084,7 +1082,7 @@ class C4_2 : I4<C4_2>
Await TestAPI(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface_ViaApi(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -1111,7 +1109,7 @@ class C4_2 : I4<C4_2>
Await TestAPI(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface_ViaApi(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -1138,7 +1136,7 @@ class C4_2 : I4<C4_2>
Await TestAPI(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface_ViaApi(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim input =
<Workspace>
Expand Down Expand Up @@ -1219,7 +1217,7 @@ class C4_2 : I4<C4_2>
Await TestStreamingFeature(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface_ViaFeature_1(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -1246,7 +1244,7 @@ class C4_2 : I4<C4_2>
Await TestStreamingFeature(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface_ViaFeature_1(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -1273,7 +1271,7 @@ class C4_2 : I4<C4_2>
Await TestStreamingFeature(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface_ViaFeature_1(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim input =
<Workspace>
Expand Down Expand Up @@ -1525,7 +1523,7 @@ class C4_2 : I4<C4_2>
Await TestStreamingFeature(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractStaticIncrementOperatorsInInterface_ViaFeature_2(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -1552,7 +1550,7 @@ class C4_2 : I4<C4_2>
Await TestStreamingFeature(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceIncrementOperatorsInInterface_ViaFeature_2(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim input =
<Workspace>
Expand All @@ -1579,7 +1577,7 @@ class C4_2 : I4<C4_2>
Await TestStreamingFeature(input, host)
End Function

<WpfTheory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test 'checked' flavor? Test overriding scenarios too.
<WpfTheory(Skip:="Yes"), CombinatorialData>
Public Async Function TestCSharpAbstractInstanceCompoundAssignmentOperatorsInInterface_ViaFeature_2(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim input =
<Workspace>
Expand Down
14 changes: 6 additions & 8 deletions src/EditorFeatures/Test2/GoToImplementation/GoToImplementationTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ class D : C
Await TestAsync(workspace, host)
End Function

<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
<Theory(Skip:="Yes"), CombinatorialData>
Public Async Function TestWithOverridableInstanceIncrementOperatorsOnBase(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
Dim workspace =
<Workspace>
Expand All @@ -478,7 +478,7 @@ class D : C
Await TestAsync(workspace, host)
End Function

<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
<Theory(Skip:="Yes"), CombinatorialData>
Public Async Function TestWithOverridableInstanceCompoundAssignmentOperatorsOnBase(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim workspace =
<Workspace>
Expand Down Expand Up @@ -524,7 +524,7 @@ class D : C
Await TestAsync(workspace, host)
End Function

<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
<Theory(Skip:="Yes"), CombinatorialData>
Public Async Function TestWithOverridableInstanceIncrementOperatorsOnImplementation(host As TestHost, <CombinatorialValues("++", "--")> op As String) As Task
' Our philosophy is to only show derived in this case
Dim workspace =
Expand All @@ -547,7 +547,7 @@ class D : C
Await TestAsync(workspace, host)
End Function

<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
<Theory(Skip:="Yes"), CombinatorialData>
Public Async Function TestWithOverridableInstanceCompoundAssignmentOperatorsOnImplementation(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
' Our philosophy is to only show derived in this case
Dim workspace =
Expand Down Expand Up @@ -595,8 +595,6 @@ class D : C
</Workspace>

Await TestAsync(workspace, host)

' PROTOTYPE: Test similar scenarios for instance operators
End Function

<Theory, CombinatorialData>
Expand Down Expand Up @@ -850,7 +848,7 @@ interface I&lt;T&gt; { abstract void operator checked $$<%= op %>(); }
Await TestAsync(workspace, host)
End Function

<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
<Theory(Skip:="Yes"), CombinatorialData>
Public Async Function TestInstanceCompoundAssignmentOperatorsImplementation_01(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim workspace =
<Workspace>
Expand Down Expand Up @@ -910,7 +908,7 @@ interface I&lt;T&gt; { abstract void operator checked $$<%= op %>(); }
Await TestAsync(workspace, host)
End Function

<Theory(Skip:="Yes"), CombinatorialData> ' PROTOTYPE: Something doesn't work. Test checked version as well.
<Theory(Skip:="Yes"), CombinatorialData>
Public Async Function TestInstanceCompoundAssignmentOperatorsImplementation_02(host As TestHost, <CombinatorialValues("+=", "-=", "*=", "/=", "%=", "&=", "|=", "^=", "<<=", ">>=", ">>>=")> op As String) As Task
Dim workspace =
<Workspace>
Expand Down
Loading