Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter] Fix incorrect reference to model serving endpoint #4588

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Mar 19, 2025

Changes

Also, remove reference to unsupported resources in databricks_mount.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners March 19, 2025 07:25
@alexott alexott requested review from renaudhartert-db and removed request for a team March 19, 2025 07:25
@alexott alexott temporarily deployed to test-trigger-is March 19, 2025 07:25 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is March 19, 2025 07:26 — with GitHub Actions Inactive
@alexott alexott requested a review from Copilot March 20, 2025 15:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the reference for the model serving endpoint and removes unsupported resource references from the exporter.

  • Update the resource name from "databricks_serving_endpoint" to "databricks_model_serving" in the importables map.
  • Remove unsupported resource references (S3, Azure, etc.) to align with current support.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
exporter/importables.go Corrects the serving endpoint reference and removes unsupported resource references.
NEXT_CHANGELOG.md Adds a changelog entry documenting the fix for the model serving endpoint reference.

Also, remove reference to unsupported resources in `databricks_mount`.
@nkvuong nkvuong force-pushed the exporter/fix-references branch from 88ce012 to 1b366f1 Compare March 21, 2025 08:26
@nkvuong nkvuong temporarily deployed to test-trigger-is March 21, 2025 08:26 — with GitHub Actions Inactive
@nkvuong nkvuong enabled auto-merge March 21, 2025 08:26
@nkvuong nkvuong temporarily deployed to test-trigger-is March 21, 2025 08:27 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is March 26, 2025 14:12 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4588
  • Commit SHA: e767b1f13ee4e2cbb44c9db07cad0bdc147d2d43

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is March 26, 2025 14:13 — with GitHub Actions Inactive
@nkvuong nkvuong added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 45e8ca0 Mar 26, 2025
12 checks passed
@nkvuong nkvuong deleted the exporter/fix-references branch March 26, 2025 17:29
deco-sdk-tagging bot added a commit that referenced this pull request Apr 1, 2025
## Release v1.71.0

### New Features and Improvements

 * Mark GKE-related fields for `databricks_mws_workspaces` and `databricks_mws_networks` as deprecated([#4531](#4531)).
 * Add support for `CAN_VIEW` permission level in `databricks_permissions`, which can be assigned to `databricks_sql_endpoint` ([#4464](#4464)).
 * Add support for `aws-us-gov-dod` (AWS Govcloud DoD shard) ([#4594](5ac0111))

### Bug Fixes

 * Recreate `databricks_access_control_rule_set` when the `name` changes ([#4572](#4572)).
 * Avoid timeouts during `databricks_mount` state refresh and creation ([#4590](#4590)).

### Documentation

 * Improve documentation for `databricks_access_control_rule_set` ([#4580](#4580)).
 * Correct `first_on_demand` documentation for `aws_attributes` in `databricks_cluster`.
 * Added file events permissions to GCP external location documentation. ([#4415](#4415)).
 * Improve description of `metric` field in `databricks_job` resource [#4595](#4595)

### Exporter

 * Add support for special selectors in `-listing` and `-services` [#4573](#4573)
 * Fix incorrect reference to model serving endpoint [#4588](#4588)
 * Allow the selective export of `databricks_mws_permission_assignment`, and change its service name to `idfed` instead of `access` ([#4571](#4571))
  * Fix panic caused by incorrect values in the cluster policies ([#4585](#4585))

### Internal Changes

* Bump Go SDK version to 0.61.0 ([#4602](#4602))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants